Fix input not auto-focused on mWeb#55823
Merged
MonilBhavsar merged 2 commits intoFeb 3, 2025
Merged
Conversation
|
@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
@rayane-djouah Could you help review this when you have a chance? Thanks! |
Contributor
|
Apologies for the delay, I was out sick the end of last week. reviewing now |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid_native.mp4Android: mWeb ChromeBefore:screen-20250123-234832.mp4After:screen-20250123-234957.mp4iOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-02-03.at.10.46.06.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-02-03.at.10.47.54.mp4MacOS: Chrome / SafariScreen.Recording.2025-02-03.at.10.53.57.AM.movMacOS: DesktopScreen.Recording.2025-02-03.at.10.52.57.AM.mov |
Contributor
Author
|
No worries, hope you're feeling better! |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
95 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.94-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀
|
8 tasks
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀
|
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
On some devices, the Lottie animation runs with high CPU usage, preventing
runAfterInteractionsfrom executing (in this case, the Text focus logic runs insiderunAfterInteractions). To address this, we need to pause the animation when the screen is blurred to improve performance and prevent memory leaks. Previously, this was handled for web/desktop, but the case formWebwas missed. This PR covers that missing case.Fixed Issues
$ #53208
PROPOSAL: #53208 (comment)
Tests
Offline tests
Same above
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
No, this change applies only to mWeb
Android: mWeb Chrome
media_20250128_080316_4531439591937098808.mp4
iOS: Native
No, this change applies only to mWeb
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-28.at.08.00.08.mp4
MacOS: Chrome / Safari
No, this change applies only to mWeb
MacOS: Desktop
No, this change applies only to mWeb