Change design of WorkspaceMoreFeaturePage sections. by parasharrajat · Pull Request #55556 · Expensify/App

parasharrajat · 2025-01-21T18:25:43Z

Explanation of Change

Fixed Issues

$ #55390
PROPOSAL: #55390 (comment)

Tests

Login to a account which have a workspace.
Go to Settings> Workspaces> [Workspace] > More Features.
Observe the design of the page.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

21.01.2025_23.55.16_REC.mp4

Android: mWeb Chrome

21.01.2025_23.49.19_REC.mp4

iOS: Native

21.01.2025_23.47.24_REC.mp4

iOS: mWeb Safari

21.01.2025_23.48.26_REC.mp4

MacOS: Chrome / Safari

21.01.2025_23.45.34_REC.mp4

MacOS: Desktop

21.01.2025_23.51.59_REC.mp4

melvin-bot · 2025-01-21T18:25:50Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2025-01-21T18:30:04Z

+            borderRadius: variables.componentBorderRadiusLarge,
+            paddingHorizontal: 16,
+            paddingVertical: 20,
+            minWidth: 350,


I kept a 350 width minimum width till it be a column layout.

Do we have any breakpoints we already use in the product? Like the same way we would use a media query... if we are at a "tablet" size, maybe that's when we switch to a single column.

Just throwing it out there in case we can kind of align on how the app responds to different widths.

Do we want to force 1 column on tablet portraits where the screen width is less than 800px?

Currently, 350 will allow it to be fit two rows in 760 < screenwidth >= 800.

Can you show me what 1 column looks like at 800px screen width? Just to compare. Thanks!

Enabled 1-column on < 800 Screens.

@parasharrajat, I have one doubt here. Passing minWidth: 350 might cause some UI distortion on devices with smaller widths. While testing using Chrome's Inspect tool on the Fold 5 (a virtual device in Chrome Inspect, not an actual one), I noticed a UI issue where the card extends beyond the screen since the width for that device is 344px.

Let me fix that.

@jayeshmangwani Done. Check now.

shawnborton · 2025-01-21T18:31:04Z

Can we make the gap between the toggle cards 12px? Both horizontally and vertically:

Can we make the border radius for each toggle card use 8px?

Can we use 32px spacing between sections? It should look more like this:

Thanks!

parasharrajat · 2025-01-21T18:53:46Z

Done.

22.01.2025_00.23.27_REC.mp4

shawnborton · 2025-01-22T06:02:13Z

The labels above the sections do not look correct:

They should be using our label font size (13px) with textSupporting color, and in regular font weight.

parasharrajat · 2025-01-22T09:01:24Z

All requested changes are done. Ready for review.

shawnborton · 2025-01-22T09:04:50Z

Sweet! Will run a test build now. Thanks for the quick turnaround on my feedback!

github-actions · 2025-01-22T09:05:29Z

🚧 @shawnborton has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-22T09:33:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55556/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55556/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55556/NewExpensify.dmg	https://55556.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-01-22T10:15:17Z

Tested on web and it feels great, let's get this into final review @jayeshmangwani !

jayeshmangwani · 2025-01-22T10:18:40Z

Thanks for reviewing the design, @shawnborton. I’m on the final review now

jayeshmangwani · 2025-01-22T12:01:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani

LGTM 🚀

OSBotify · 2025-01-22T14:30:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T18:29:46Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-28T01:53:15Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

parasharrajat added 6 commits January 21, 2025 00:22

use named imports

6a84555

Merge branch 'main' into parasharrajat/MoreFeaturesView

efc3e08

New WorkspaceMore features page design

e3e033f

More design changes

37ce87f

change position of sections

741b176

Remove extra import

5d41dbd

parasharrajat requested review from a team as code owners January 21, 2025 18:25

melvin-bot Bot requested review from jayeshmangwani and removed request for a team January 21, 2025 18:25

parasharrajat commented Jan 21, 2025

View reviewed changes

Fix Spacing

30a5c84

parasharrajat added 2 commits January 22, 2025 14:21

Force single column layout on Narrow screens

73a998c

Update section title styles

e88b0fd

shawnborton added the Ready To Build label Jan 22, 2025

MinWidth issue fix for small screen devices

a90e931

jayeshmangwani approved these changes Jan 22, 2025

View reviewed changes

melvin-bot Bot requested a review from carlosmiceli January 22, 2025 14:15

carlosmiceli approved these changes Jan 22, 2025

View reviewed changes

carlosmiceli merged commit 9018751 into Expensify:main Jan 22, 2025

github-actions Bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

melvin-bot Bot mentioned this pull request Jan 28, 2025

[HOLD for payment 2025-02-04] Update the design of the More Features page in the Workspace editor #55390

Closed

Conversation

parasharrajat commented Jan 21, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Jan 21, 2025

Uh oh!

parasharrajat commented Jan 21, 2025

Uh oh!

shawnborton commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Jan 22, 2025

Uh oh!

shawnborton commented Jan 22, 2025

Uh oh!

github-actions Bot commented Jan 22, 2025

Uh oh!

github-actions Bot commented Jan 22, 2025

Uh oh!

shawnborton commented Jan 22, 2025

Uh oh!

jayeshmangwani commented Jan 22, 2025

Uh oh!

jayeshmangwani commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 22, 2025

Uh oh!

github-actions Bot commented Jan 23, 2025

Uh oh!

github-actions Bot commented Jan 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shawnborton commented Jan 22, 2025 •

edited

Loading

jayeshmangwani commented Jan 22, 2025 •

edited

Loading