Skip to content

Encode encryptedAuthToken in front end #5543

Merged
jasperhuangg merged 1 commit into
mainfrom
marcaaron-encodeEncryptedAuthToken
Sep 29, 2021
Merged

Encode encryptedAuthToken in front end #5543
jasperhuangg merged 1 commit into
mainfrom
marcaaron-encodeEncryptedAuthToken

Conversation

@marcaaron

@marcaaron marcaaron commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Details

This is a necessary step so we can switch off of passing the encryptedAuthToken in the /transition links when moving from OldDot to NewDot. In the changes here we will no longer be url encoding the encryptedAuthToken before sending it via JSON response to Expensify/App. Tested this change and there are no negative effects of "double encoding" since the urls should already arrive urlencoded.

Fixed Issues (Related to)

https://github.com/Expensify/Expensify/issues/178434

Tests

  1. Test against current Web-Expensify master (npm run grunt first)
  2. Do QA steps

QA Steps

  1. Sign up for a new account in OldDot (mobile user agent)
  2. Tap "Join"
  3. Tap "Set up my company for free"
    2021-09-27_09-36-44
  4. Verify NewDot opens up to a workspace
  5. Close the workspace window and navigate to the Concierge chat
  6. Upload an attachment
  7. Verify the attachment is visible
    2021-09-27_09-44-30

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Sep 27, 2021
@marcaaron marcaaron marked this pull request as ready for review September 27, 2021 19:45
@marcaaron marcaaron requested a review from a team as a code owner September 27, 2021 19:45
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team September 27, 2021 19:45
@jasperhuangg jasperhuangg merged commit cfb28ce into main Sep 29, 2021
@jasperhuangg jasperhuangg deleted the marcaaron-encodeEncryptedAuthToken branch September 29, 2021 18:22
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @jasperhuangg in version: 1.1.3-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico

Copy link
Copy Markdown

@marcaaron Hello! I think this one needs to be internal QA. We currently don't have access to the 3 options on log in for step 3 (with gmail accounts)

@marcaaron

Copy link
Copy Markdown
Contributor Author

Tested and works great feel free to check it off :)

@isagoico

Copy link
Copy Markdown

Thank you so much!

@OSBotify

OSBotify commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.4-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants