Fix broken feed connection error display on the Company Cards page by VickyStash · Pull Request #55286 · Expensify/App

VickyStash · 2025-01-15T15:42:36Z

Explanation of Change

Fix the broken feed connection error display on the Company Cards page by checking feed's cards lastScrapeResult

Fixed Issues

$ #55103
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Ask to be added as an admin to the workspace with a direct feed with a broken connection.
Open the workspace -> Company Cards page.
Make sure broken connection indication is shown:

red dot indicator in the workspace menu next to Company Cards option
error message below feed selector. login to your bank link should lead to the bank page to enter credentials
red dot indicator in the feed selector

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Same, as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…nnection-error-display

…Y_CARDS_BANK_CONNECTION route

…nnection-error-display # Conflicts: # src/libs/actions/CompanyCards.ts # src/types/onyx/CardFeeds.ts

melvin-bot · 2025-01-16T16:52:30Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…nnection-error-display # Conflicts: # src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx # src/pages/workspace/companyCards/addNew/BankConnection/index.tsx

VickyStash · 2025-01-20T08:10:49Z

@getusha kind bump 🙂
I'm going to be OOO 22-26 January, so it would be great to progress it before that

…nnection-error-display # Conflicts: # src/pages/workspace/companyCards/WorkspaceCompanyCardsListHeaderButtons.tsx

VickyStash · 2025-01-27T08:18:05Z

@getusha I've applied your feedback, please take another look

getusha · 2025-01-27T14:26:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-27.at.5.24.31.in.the.afternoon.mov

Android: mWeb Chrome

Screen.Recording.2025-01-27.at.4.26.52.in.the.afternoon.mov

iOS: Native

Screen.Recording.2025-01-27.at.4.44.21.in.the.afternoon.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Screen.Recording.2025-01-27.at.4.31.13.in.the.afternoon.mov

Co-authored-by: Getabalew <75031127+getusha@users.noreply.github.com>

mountiny · 2025-01-27T14:43:56Z

    API.read(READ_COMMANDS.OPEN_POLICY_COMPANY_CARDS_FEED, parameters);
 }

+function flatAllCardsList(allCardsList: OnyxCollection<WorkspaceCardsList>, workspaceAccountID: number): Record<string, Card> | undefined {


I think this method would deserve some plain English explanation of what its used for and what is the expected output format (unit test possibly too)

mountiny · 2025-01-27T14:48:57Z

+    }, {});
+}
+
+function checkIfFeedConnectionIsBroken(feedCards: Record<string, Card> | undefined, feedToExclude?: string): boolean {


Could you please add docs here as well and try to explain why the feedToExclude might be needed? Thanks!

mountiny

@VickyStash Thanks, lets add the unit tests in a follow up

mountiny · 2025-01-27T15:55:10Z

+}
+
+/**
+ * Check if any feed card has a broken connection


Suggested change

* Check if any feed card has a broken connection

* Check if any card from the provided feed(s) has a broken connection

OSBotify · 2025-01-27T16:18:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-28T02:16:01Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.90-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

joekaufmanexpensify · 2025-01-28T14:44:20Z

Looks great!

github-actions · 2025-01-29T06:23:49Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

grgia · 2026-03-17T16:51:03Z

        domainName: PolicyUtils.getDomainNameForPolicy(policyID),
        isCorporate: 'true',
-        scrapeMinDate: scrapeMinDate ?? '',
+        scrapeMinDate: '',


hey @VickyStash do you remember why this was removed?

I'm looking at #84401

Sorry, but I don't remember
Maybe, cause the scrapeMinDate wasn't passed to this function, but I'm not sure

VickyStash added 3 commits January 15, 2025 12:21

Make isLoading be always boolean to prevent extra calls of the useEffect

8c3091c

Use cards lastScrapeResult to check if connection is broken

40daa37

Lint fixes pt1

fc70fd9

VickyStash mentioned this pull request Jan 15, 2025

[HOLD for payment 2025-02-07] [HOLD for payment 2025-02-05] We aren't showing broken connection error on the feed when the connection is broken #55103

Closed

8 tasks

VickyStash added 6 commits January 16, 2025 11:26

Merge branch 'refs/heads/main' into VickyStash/bugfix/55103-broken-co…

4e83054

…nnection-error-display

Import updates to fix lint errors

67cd525

Change the broken connection message display and add WORKSPACE_COMPAN…

eef9e26

…Y_CARDS_BANK_CONNECTION route

Update BankConnection page to support its direct open

291bbb2

Fix lint errors

76f8777

Merge branch 'refs/heads/main' into VickyStash/bugfix/55103-broken-co…

a22be65

…nnection-error-display # Conflicts: # src/libs/actions/CompanyCards.ts # src/types/onyx/CardFeeds.ts

VickyStash changed the title ~~Fix broken feed connection error display on the Company Cards page~~ [WIP] Fix broken feed connection error display on the Company Cards page Jan 16, 2025

VickyStash added 6 commits January 16, 2025 15:16

Minor lint fix

07bfde8

Fix bank connection

7749530

Reuse existing getBankName method

fc686e0

Lint fix

40fc52c

Fix all cards processing

16b2397

Lint fix

7a3f80a

VickyStash changed the title ~~[WIP] Fix broken feed connection error display on the Company Cards page~~ Fix broken feed connection error display on the Company Cards page Jan 16, 2025

VickyStash marked this pull request as ready for review January 16, 2025 16:52

VickyStash requested a review from a team as a code owner January 16, 2025 16:52

melvin-bot Bot requested review from getusha and removed request for a team January 16, 2025 16:52

Merge branch 'refs/heads/main' into VickyStash/bugfix/55103-broken-co…

afeda3f

…nnection-error-display # Conflicts: # src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx # src/pages/workspace/companyCards/addNew/BankConnection/index.tsx

mountiny assigned VickyStash Jan 24, 2025

mountiny self-requested a review January 24, 2025 15:27

getusha reviewed Jan 24, 2025

View reviewed changes

Comment thread src/pages/workspace/companyCards/addNew/BankConnection/index.tsx

Comment thread src/pages/workspace/companyCards/addNew/BankConnection/index.native.tsx

Comment thread src/libs/actions/CompanyCards.ts Outdated

Comment thread src/libs/actions/CompanyCards.ts Outdated

VickyStash added 2 commits January 27, 2025 08:54

Merge branch 'refs/heads/main' into VickyStash/bugfix/55103-broken-co…

1942215

…nnection-error-display # Conflicts: # src/pages/workspace/companyCards/WorkspaceCompanyCardsListHeaderButtons.tsx

Code improvements

befa0c3

VickyStash requested a review from getusha January 27, 2025 08:17

getusha approved these changes Jan 27, 2025

View reviewed changes

Comment thread src/pages/workspace/companyCards/WorkspaceCompanyCardsListHeaderButtons.tsx Outdated

Align dot indicator

3081c3c

Co-authored-by: Getabalew <75031127+getusha@users.noreply.github.com>

mountiny added the InternalQA This pull request required internal QA label Jan 27, 2025

mountiny reviewed Jan 27, 2025

View reviewed changes

Add functions description

d3d365d

mountiny approved these changes Jan 27, 2025

View reviewed changes

mountiny merged commit 9cadcd2 into Expensify:main Jan 27, 2025

github-actions Bot mentioned this pull request Jan 28, 2025

Deploy Checklist: New Expensify 2025-01-28 #55824

Closed

82 tasks

VickyStash mentioned this pull request Jan 28, 2025

[No QA] Follow-up: add unit tests for broken feed connection utility functions #55866

Merged

50 tasks

grgia reviewed Mar 17, 2026

View reviewed changes

	* Check if any feed card has a broken connection
	* Check if any card from the provided feed(s) has a broken connection

Conversation

VickyStash commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 16, 2025

Uh oh!

VickyStash commented Jan 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VickyStash commented Jan 27, 2025

Uh oh!

getusha commented Jan 27, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

mountiny Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 27, 2025

Uh oh!

github-actions Bot commented Jan 28, 2025

Uh oh!

joekaufmanexpensify commented Jan 28, 2025

Uh oh!

github-actions Bot commented Jan 29, 2025

Uh oh!

grgia Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

VickyStash Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

VickyStash commented Jan 15, 2025 •

edited

Loading