Skip to content

[CP Staging] Revert "fix: dismiss keyboard once open modal"#55144

Merged
srikarparsi merged 1 commit into
mainfrom
revert-54276-fix-53572
Jan 12, 2025
Merged

[CP Staging] Revert "fix: dismiss keyboard once open modal"#55144
srikarparsi merged 1 commit into
mainfrom
revert-54276-fix-53572

Conversation

@mountiny

@mountiny mountiny commented Jan 12, 2025

Copy link
Copy Markdown
Contributor

Straight reverts #54276

Fixes #55119

Confirmed here #55119 (comment)

@mountiny mountiny self-assigned this Jan 12, 2025
@mountiny mountiny requested a review from a team as a code owner January 12, 2025 23:09
@melvin-bot melvin-bot Bot requested review from cristipaval and removed request for a team January 12, 2025 23:09
@melvin-bot

melvin-bot Bot commented Jan 12, 2025

Copy link
Copy Markdown

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@srikarparsi srikarparsi merged commit c30c298 into main Jan 12, 2025
@srikarparsi srikarparsi deleted the revert-54276-fix-53572 branch January 12, 2025 23:46
@melvin-bot melvin-bot Bot added the Emergency label Jan 12, 2025
@melvin-bot

melvin-bot Bot commented Jan 12, 2025

Copy link
Copy Markdown

@srikarparsi looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@srikarparsi

srikarparsi commented Jan 12, 2025

Copy link
Copy Markdown
Contributor

didn't do checklists because it was a straight revert

@OSBotify

OSBotify commented Jan 12, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Beamanator Beamanator mentioned this pull request Jan 13, 2025
Closed
8 tasks
OSBotify pushed a commit that referenced this pull request Jan 13, 2025
@srikarparsi @OSBotify
Merge pull request #55144 from Expensify/revert-54276-fix-53572
df0f2b4 
[CP Staging] Revert "fix: dismiss keyboard once open modal"

(cherry picked from commit c30c298)

(CP triggered by mountiny)
@github-actions github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Jan 13, 2025
@github-actions github-actions Bot mentioned this pull request Jan 13, 2025
Closed
39 tasks
@github-actions

github-actions Bot commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.84-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions

github-actions Bot commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.84-7 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@github-actions

github-actions Bot commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.84-7 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristipaval cristipaval Awaiting requested review from cristipaval

1 more reviewer

@srikarparsi srikarparsi srikarparsi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mountiny mountiny

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search - Search field is not auto focused when opened

3 participants

@mountiny @srikarparsi @OSBotify