[No QA]Add Firebase distribution for iOS and Android staging builds#55037
Merged
Conversation
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
AndrewGable
commented
Jan 9, 2025
| desc "Upload app to Firebase distribution" | ||
| lane :upload_firebase_distribution do | ||
| firebase_app_distribution( | ||
| app: "1:1008697809946:android:2e48f9ffe8d0b6a2", |
Contributor
Author
There was a problem hiding this comment.
FYI - This is not a secret and already open source.
AndrewGable
commented
Jan 9, 2025
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
OSBotify
pushed a commit
that referenced
this pull request
Jan 9, 2025
[No QA]Add Firebase distribution for iOS and Android staging builds (cherry picked from commit de03389) (CP triggered by AndrewGable)
60 tasks
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.0.82-8 🚀
|
This was referenced Jan 10, 2025
Contributor
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.82-12 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
We are running into issues with the number of users and time required for releases for the QA team. We have discussed Firebase app distribution being a vendor we could use for this. This adds this as a test to confirm that it will help solve both of those problems.
Fixed Issues
N/A
Tests
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop