[CP Staging] fix: dispatch callback after dismissing modal by WoLewicki · Pull Request #55011 · Expensify/App

WoLewicki · 2025-01-09T14:40:21Z

Explanation of Change

Image picker (showing the image gallery) fires its callback when we click on the image, not when its modal is hidden. This way, in release env where everything is fast, the callbacks is run in JS, which in turn tries to open modal with attachment. This can happen before the native modal hides.

Fixed Issues

$ #54970
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Launch ND or hybrid app.
Open chat.
Tap + > Add attachment .
Tap Choose from gallery.
Select an image.
Make sure the selection works and you can upload the image
Repeat multiple times
Ensure it works

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-01-09T14:40:55Z

@johnmlee101 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-01-09T14:44:37Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-09T15:09:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55011/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55011/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55011/NewExpensify.dmg	https://55011.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

marcochavezf

Tested out the ad-hoc build and looks good, thanks!

marcochavezf · 2025-01-09T16:50:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

marcochavezf · 2025-01-09T16:52:35Z

Merging to unblock the deploy

…mage-gallery-picker fix: dispatch callback after dismissing modal (cherry picked from commit a6ccbd0) (CP triggered by mountiny)

OSBotify · 2025-01-09T17:01:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-09T17:38:40Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.82-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

mvtglobally · 2025-01-09T23:09:06Z

@marcochavezf @WoLewicki Anything needed to QA on this one?

mountiny · 2025-01-09T23:28:21Z

@mvtglobally updated with the steps

github-actions · 2025-01-10T03:39:48Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.82-12 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

eh2077 · 2025-09-29T10:45:35Z

There seems no upstream issue for the react-native-image-picker patch.

mountiny · 2025-09-29T18:38:14Z

@WoLewicki would you be able to create one and link it to the patch details?

fix: dispatch callback after dismissing modal

ba37e37

WoLewicki requested a review from a team as a code owner January 9, 2025 14:40

melvin-bot Bot requested review from johnmlee101 and removed request for a team January 9, 2025 14:40

mountiny added the Ready To Build label Jan 9, 2025

marcochavezf approved these changes Jan 9, 2025

View reviewed changes

marcochavezf merged commit a6ccbd0 into Expensify:main Jan 9, 2025

marcochavezf mentioned this pull request Jan 9, 2025

[HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] [$125] iOS - Unable to add attachment to chat and upload avatar #54970

Closed

8 tasks

mountiny changed the title ~~fix: dispatch callback after dismissing modal~~ [CP Staging] fix: dispatch callback after dismissing modal Jan 9, 2025

OSBotify pushed a commit that referenced this pull request Jan 9, 2025

Merge pull request #55011 from software-mansion-labs/@wolewicki/fix-i…

1a32aa8

…mage-gallery-picker fix: dispatch callback after dismissing modal (cherry picked from commit a6ccbd0) (CP triggered by mountiny)

github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Jan 9, 2025

github-actions Bot mentioned this pull request Jan 9, 2025

Deploy Checklist: New Expensify 2025-01-08 #54928

Closed

60 tasks

Uh oh!

Conversation

WoLewicki commented Jan 9, 2025 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 9, 2025

Uh oh!

github-actions Bot commented Jan 9, 2025

Uh oh!

github-actions Bot commented Jan 9, 2025

Uh oh!

marcochavezf left a comment

Choose a reason for hiding this comment

Uh oh!

marcochavezf commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

marcochavezf commented Jan 9, 2025

Uh oh!

OSBotify commented Jan 9, 2025

Uh oh!

github-actions Bot commented Jan 9, 2025

Uh oh!

mvtglobally commented Jan 9, 2025

Uh oh!

mountiny commented Jan 9, 2025

Uh oh!

github-actions Bot commented Jan 10, 2025

Uh oh!

eh2077 commented Sep 29, 2025

Uh oh!

mountiny commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

WoLewicki commented Jan 9, 2025 •

edited by mountiny

Loading

marcochavezf commented Jan 9, 2025 •

edited

Loading