fix: Hide invoice menu if the user can't send an invoice or has an invoice report by etCoderDysto · Pull Request #54945 · Expensify/App

etCoderDysto · 2025-01-08T09:12:02Z

Explanation of Change

If Invoice feature is enabled in a workspace, hide Invoices menu in Reports page if a user is only a member of a workspace and have no invoice report.

Fixed Issues

$ #54562
PROPOSAL: #54562 (comment)

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

Same as QA steps

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Test 1

Precondition: Sign in with two new accounts in separate devices

User 1 - Create a workspace
User 1 - Enable Invoice in more features page
User 1 - Invite User 2 to the workspace
User 2 - Click on Reports bottom tab menu and navigate to Reports page
User 2 - Verify that there is no Invoice menu in Left hand navigation
User 1 - Make User 2 admin of the workspace
User 2 - Verify that now Invoice menu is displayed
User 2 - Click on Invoices
User 2 - Verify there is message that says "You haven't created any
invoices yet"

Test 2

Precondition: Sign in with two new accounts in separate devices

User 1 - Create a workspace
User 1 - Enable Invoice in more features page
User 1 - Invite User 2 to the workspace
User 2 - Click on Reports bottom tab menu and navigate to Reports page
User 2 - Verify that there is no Invoice menu in Left hand navigation
User 1 - Send an invoice to User 2
User 2 - Navigate to Reports page
User 2 - Verify that you see Invoices menu
User 2- Click on Invoices
User 2 - Verify that you see the invoice User 1 has sent you

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.10.in.the.morning.mp4

Android: mWeb Chrome

Android.chrome.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.safari.mp4

MacOS: Chrome / Safari

Web.Screen.Recording.2025-01-07.at.9.33.53.in.the.morning.mp4

MacOS: Desktop

Destop.Screen.Recording.2025-01-07.at.9.42.48.in.the.morning.mp4

…'t create invoice

melvin-bot · 2025-01-09T15:02:48Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2025-01-09T17:23:24Z

 import useThemeStyles from '@hooks/useThemeStyles';
 import * as SearchActions from '@libs/actions/Search';
 import Navigation from '@libs/Navigation/Navigation';
-import {getAllTaxRates, hasWorkspaceWithInvoices} from '@libs/PolicyUtils';


hasWorkspaceWithInvoices is now unused. Let's remove that function definition

I have removed the function definition 🙏.

Pujan92 · 2025-01-09T19:06:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-01-10.at.00.56.45.mov

MacOS: Desktop

Pujan92 · 2025-01-09T19:34:23Z

@luacmartins do you think we should handle the navigation case when user B is demoted from Admin to Member?
we should navigate to another option if user B is on Invoices screen but Invoices menu item won't be there anymore?

Screen.Recording.2025-01-10.at.00.58.48.mov

Pujan92 · 2025-01-09T20:15:36Z

@etCoderDysto can you plz look into above^ issue

etCoderDysto · 2025-01-09T20:20:59Z

@etCoderDysto can you plz look into above^ issue

@Pujan92 I have tried to reproduce the issue, and it is also reproducible on staging when you remove a member from a workspace.

Sing up with a new member account
Sign up with an admin account
Create workspace
Enable invoice
Invite the member account
Then remove the member account
You will see the same behaviour.

I can put up a follow up PR if needed as this is already reproducible on staging and probably on production too.

Pujan92 · 2025-01-09T20:25:09Z

Maybe navigating to the other existing page is a different issue and needs to be solved in other PR, better to clarify with @luacmartins once.

luacmartins · 2025-01-09T21:27:14Z

Not sure if we need to address that since it's a pretty small edge case. Either way, I think we can do that in a follow up if needed.

Pujan92 · 2025-01-10T10:48:21Z

Ok, Thanks @luacmartins

Pujan92

LGTM!

OSBotify · 2025-01-10T15:36:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-11T03:37:36Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.84-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-14T13:36:20Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.84-7 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-14T13:58:16Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.84-7 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

hide invoice menu when there is no invoice report for a user that can…

c409371

…'t create invoice

etCoderDysto mentioned this pull request Jan 8, 2025

[HOLD for payment 2025-01-21] [$250] Invoice - Send invoice button appears in Reports empty state when invited member is not an admin #54562

Closed

8 tasks

luacmartins self-requested a review January 8, 2025 16:38

Merge branch 'main' into invoice_menu

59e702b

etCoderDysto marked this pull request as ready for review January 9, 2025 15:02

etCoderDysto requested a review from a team as a code owner January 9, 2025 15:02

melvin-bot Bot requested a review from Pujan92 January 9, 2025 15:02

melvin-bot Bot removed the request for review from a team January 9, 2025 15:02

luacmartins requested changes Jan 9, 2025

View reviewed changes

delete hasWorkspaceWithInvoices function definition

dc1b5be

luacmartins approved these changes Jan 9, 2025

View reviewed changes

Pujan92 approved these changes Jan 10, 2025

View reviewed changes

melvin-bot Bot requested a review from luacmartins January 10, 2025 10:49

luacmartins approved these changes Jan 10, 2025

View reviewed changes

luacmartins merged commit 3541c89 into Expensify:main Jan 10, 2025

github-actions Bot mentioned this pull request Jan 11, 2025

Deploy Checklist: New Expensify 2025-01-11 #55109

Closed

39 tasks

Uh oh!

Conversation

etCoderDysto commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

Test 1

Test 2

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 9, 2025

Uh oh!

luacmartins Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

etCoderDysto Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pujan92 commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 commented Jan 9, 2025

Uh oh!

Pujan92 commented Jan 9, 2025

Uh oh!

etCoderDysto commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pujan92 commented Jan 9, 2025

Uh oh!

luacmartins commented Jan 9, 2025

Uh oh!

Pujan92 commented Jan 10, 2025

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 10, 2025

Uh oh!

github-actions Bot commented Jan 11, 2025

Uh oh!

github-actions Bot commented Jan 14, 2025

Uh oh!

github-actions Bot commented Jan 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

etCoderDysto commented Jan 8, 2025 •

edited

Loading

etCoderDysto Jan 9, 2025 •

edited

Loading

Pujan92 commented Jan 9, 2025 •

edited

Loading

etCoderDysto commented Jan 9, 2025 •

edited

Loading