Skip to content

Fix: hint text for Vendor bill is not below the toggle #54854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julesssss merged 2 commits into from
Jan 7, 2025
Merged

Fix: hint text for Vendor bill is not below the toggle #54854

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c27b68
fix: hint text for Vendor bill is not below the toggle
mkzie2 Jan 7, 2025
feae18d
fix lint error
mkzie2 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import ROUTES from '@src/ROUTES';
function QuickbooksCompanyCardExpenseAccountPage({policy}: WithPolicyConnectionsProps) {
const {translate} = useLocalize();
const styles = useThemeStyles();
const policyID = policy?.id ?? '-1';
const policyID = policy?.id ?? `${CONST.DEFAULT_NUMBER_ID}`;

@s77rt s77rt Jan 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still violates the lint rule. Please check https://expensify.slack.com/archives/C01GTK53T8Q/p1737913879440099

@Julesssss Julesssss Jan 27, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thank you. I only recently learnt that the rule doesn't apply for strings.

@Julesssss Julesssss Jan 27, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair this was implemented not long after the rule was implemented 😄

@Julesssss Julesssss Jan 27, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR: #55804

const qboConfig = policy?.connections?.quickbooksOnline?.config;
const {vendors} = policy?.connections?.quickbooksOnline?.data ?? {};
const nonReimbursableBillDefaultVendorObject = vendors?.find((vendor) => vendor.id === qboConfig?.nonReimbursableBillDefaultVendor);
Expand Down Expand Up @@ -73,6 +73,7 @@ function QuickbooksCompanyCardExpenseAccountPage({policy}: WithPolicyConnections
switchAccessibilityLabel={translate('workspace.qbo.defaultVendorDescription')}
wrapperStyle={[styles.ph5, styles.mb3, styles.mt1]}
isActive={!!qboConfig?.autoCreateVendor}
shouldPlaceSubtitleBelowSwitch
pendingAction={PolicyUtils.settingsPendingAction([CONST.QUICKBOOKS_CONFIG.AUTO_CREATE_VENDOR], qboConfig?.pendingFields)}
errors={ErrorUtils.getLatestErrorField(qboConfig, CONST.QUICKBOOKS_CONFIG.AUTO_CREATE_VENDOR)}
onToggle={(isOn) =>
Expand Down