fix: Status message not cleared by nkdengineer · Pull Request #53810 · Expensify/App

nkdengineer · 2024-12-10T07:43:03Z

Explanation of Change

Fixed Issues

$ #53518
PROPOSAL: #53518 (comment)

Tests

Set a status message with a "Clear after" date in the profile.
Wait until the specified "Clear after" date has passed.
Check if the status message is automatically cleared.
Verify that: The status message should be automatically cleared once the "Clear after" date is reached, ensuring timely updates to the display.

Verify that no errors appear in the JS console

Offline tests

same as above

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-12-11T07:33:38Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eh2077 · 2024-12-11T16:23:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mobile-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mobile-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

nkdengineer · 2024-12-17T09:54:33Z

@eh2077 i updated, please check again

eh2077 · 2024-12-17T13:00:14Z

@rlinoz Can you help add pusher event for the expired status?

I was testing this the other day and I think we already have it? Isn't it working?

@rlinoz No, it doesn’t work from my end. I tested on production iOS app and the Web, the expired status is not cleared even if I reopen the App or refresh the page.

eh2077 · 2024-12-17T12:51:11Z

+        const currentTime = format(new Date(), 'yyyy-MM-dd HH:mm:ss');
+        if (!currentUserPersonalDetails.status?.clearAfter) {
+            return;
+        }
+        if (new Date(currentUserPersonalDetails.status?.clearAfter).getTime() > new Date(currentTime).getTime()) {
+            const subMilisecondsTime = new Date(currentUserPersonalDetails.status?.clearAfter).getTime() - new Date(currentTime).getTime();


I think we can make the code cleaner like

if (!currentUserPersonalDetails.status?.clearAfter) { return; } const currentTime = new Date(); const clearAfterTime = new Date(currentUserPersonalDetails.status.clearAfter); if (isNaN(clearAfterTime.getTime())) { return; } const timeDifference = clearAfterTime.getTime() - currentTime.getTime(); if (subMilisecondsTime > 0) {

@eh2077 i updated

rlinoz · 2024-12-17T13:11:01Z

@eh2077 interesting, when I set it up to clear after 2 minutes or so it works, can you share the steps you are taking please?

eh2077 · 2024-12-17T13:25:32Z

@rlinoz Below are recordings from my devices

0-ios.mp4

0-web.mp4

expired_status_is_not_clear_after_refresh_page.mov

eh2077 · 2024-12-19T15:54:59Z

@nkdengineer There're conflicts need to be resolved.

nkdengineer · 2024-12-23T07:50:08Z

@eh2077 i resolved

nkdengineer · 2024-12-30T02:39:33Z

friendly bump @eh2077

eh2077 · 2025-01-03T16:40:37Z

I'll update tmr

eh2077 · 2025-01-06T16:52:09Z

@nkdengineer After the status is cleared, the default option of Clear after is Never instead of Today.

If reopen it, then the default option changes to Today

Screen.Recording.2025-01-07.at.12.50.53.AM.mov

rlinoz · 2025-01-08T11:48:32Z

@nkdengineer bump on the above

nkdengineer · 2025-01-09T04:08:56Z

Will give an update soon

nkdengineer · 2025-01-09T09:47:28Z

@eh2077 i fixed

eh2077 · 2025-01-09T12:43:55Z

@nkdengineer Can you please fix the lint check?

eh2077 · 2025-01-09T13:21:52Z

+        User.updateDraftCustomStatus({
+            text: '',
+            emojiCode: '',
+            clearAfter: '',
+        });


Suggested change

User.updateDraftCustomStatus({

text: '',

emojiCode: '',

clearAfter: '',

});

User.clearDraftCustomStatus();

@eh2077 we need to add empty string value here to reset the value

@nkdengineer I suggested replacing the update method with the clear draft method. Can you check it again?

ohh, i updated, thanks @eh2077

eh2077 · 2025-01-10T13:57:30Z

@nkdengineer Please help to fix the lint check and address the minor comment, thank you!

eh2077

LGTM!

rlinoz

Thanks!

OSBotify · 2025-01-13T13:28:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-14T13:59:38Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-14T14:15:39Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-14T14:41:01Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-14T15:24:42Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-14T15:48:53Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	cancelled 🔪

github-actions · 2025-01-15T13:47:45Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.85-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-15T15:48:41Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.85-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

nkdengineer added 2 commits December 10, 2024 14:42

fix: Status message not cleared

88d93f3

Merge branch 'main' into fix/53518

3151be8

nkdengineer marked this pull request as ready for review December 11, 2024 07:33

nkdengineer requested a review from a team as a code owner December 11, 2024 07:33

melvin-bot Bot requested review from eh2077 and removed request for a team December 11, 2024 07:33

eh2077 reviewed Dec 16, 2024

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/AuthScreens.tsx

Comment thread src/libs/Navigation/AppNavigator/AuthScreens.tsx Outdated

nkdengineer added 2 commits December 17, 2024 16:47

Merge branch 'main' into fix/53518

1ab2da2

fix logic update clear status

bf668de

eh2077 reviewed Dec 17, 2024

View reviewed changes

nkdengineer added 2 commits December 18, 2024 15:04

fix: lint and logic useEffect

81f81d2

fix lint

9897d39

fix conflist

839ff0f

nkdengineer added 4 commits January 9, 2025 15:42

Merge branch 'main' into fix/53518

38b66b9

fix the default option

edcc53d

fix chore

24eba35

fix logic clear status

84973de

eh2077 reviewed Jan 9, 2025

View reviewed changes

nkdengineer added 2 commits January 13, 2025 11:49

fix lint

374a6a6

using clear draft custom status

7e4892d

eh2077 approved these changes Jan 13, 2025

View reviewed changes

melvin-bot Bot requested a review from rlinoz January 13, 2025 12:23

rlinoz approved these changes Jan 13, 2025

View reviewed changes

rlinoz merged commit edb7390 into Expensify:main Jan 13, 2025

github-actions Bot mentioned this pull request Jan 14, 2025

Deploy Checklist: New Expensify 2025-01-14 #55208

Closed

38 tasks

melvin-bot Bot mentioned this pull request Jan 15, 2025

[HOLD for payment 2025-01-22] [$250] Status message not cleared after the specified "Clear after" date #53518

Closed

8 tasks

Uh oh!

Conversation

nkdengineer commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 11, 2024

Uh oh!

eh2077 commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

nkdengineer commented Dec 17, 2024

Uh oh!

eh2077 commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eh2077 Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

nkdengineer Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

rlinoz commented Dec 17, 2024

Uh oh!

eh2077 commented Dec 17, 2024

Uh oh!

eh2077 commented Dec 19, 2024

Uh oh!

nkdengineer commented Dec 23, 2024

Uh oh!

nkdengineer commented Dec 30, 2024

Uh oh!

eh2077 commented Jan 3, 2025

Uh oh!

eh2077 commented Jan 6, 2025

Uh oh!

rlinoz commented Jan 8, 2025

Uh oh!

nkdengineer commented Jan 9, 2025

Uh oh!

nkdengineer commented Jan 9, 2025

Uh oh!

eh2077 commented Jan 9, 2025

Uh oh!

eh2077 Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

eh2077 Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

eh2077 commented Jan 10, 2025

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 13, 2025

Uh oh!

github-actions Bot commented Jan 14, 2025

Uh oh!

github-actions Bot commented Jan 14, 2025

Uh oh!

nkdengineer commented Dec 10, 2024 •

edited

Loading

eh2077 commented Dec 11, 2024 •

edited

Loading

eh2077 commented Dec 17, 2024 •

edited

Loading