Skip to content

Remove Zip Code validation from Add a payment card page #53178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieldoglas merged 3 commits into from
Dec 4, 2024
Merged

Remove Zip Code validation from Add a payment card page #53178

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6990c38
Remove payment card form Zip Code validation
ikevin127 Nov 26, 2024
0e29ba1
Removed inputMode to allow non-numeric Zip Codes (UK)
ikevin127 Nov 26, 2024
2ad0ddf
updated postcode input label
ikevin127 Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/components/AddPaymentCard/PaymentCardForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,6 @@ function PaymentCardForm({
errors.addressStreet = translate(label.error.addressStreet);
}

if (values.addressZipCode && !ValidationUtils.isValidZipCode(values.addressZipCode)) {

@getusha getusha Dec 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a comment to prevent others reverting this change?

@ikevin127 ikevin127 Dec 3, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change will be visible in blame which will lead to this PR / issue and it's self explanatory that we removed the specific Zip Code validation for time being, the explanation being visible in the PRs description.

errors.addressZipCode = translate(label.error.addressZipCode);
}

if (!values.acceptTerms) {
errors.acceptTerms = translate('common.error.acceptTerms');
}
Expand Down Expand Up @@ -283,10 +279,9 @@ function PaymentCardForm({
InputComponent={TextInput}
defaultValue={data?.addressZipCode}
inputID={INPUT_IDS.ADDRESS_ZIP_CODE}
label={translate('common.zip')}
aria-label={translate('common.zip')}
label={translate('common.zipPostCode')}
aria-label={translate('common.zipPostCode')}
role={CONST.ROLE.PRESENTATION}
inputMode={CONST.INPUT_MODE.NUMERIC}

@ikevin127 ikevin127 Nov 26, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this line because on mWeb platforms this would only allow numeric input which would restrict users from typing UK Zip Codes what contain characters and numbers (ex. SW8 4LT). The issue was present on iOS: mWeb as well, here's an example from Android: mWeb before and after removing the line:

Before After
android-mweb-before android-mweb-after

@getusha getusha Dec 3, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense, thanks

maxLength={CONST.BANK_ACCOUNT.MAX_LENGTH.ZIP_CODE}
containerStyles={[styles.mt5]}
/>
Expand Down