[CP Staging] Revert "Fix pay someone flow for unvalidated accounts"#52469
Closed
mountiny wants to merge 1 commit into
Closed
[CP Staging] Revert "Fix pay someone flow for unvalidated accounts"#52469mountiny wants to merge 1 commit into
mountiny wants to merge 1 commit into
Conversation
mountiny
marked this pull request as ready for review
November 13, 2024 12:37
melvin-bot
Bot
requested review from
allroundexperts and
youssef-lr
and removed request for
a team
November 13, 2024 12:37
|
@allroundexperts @youssef-lr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
It fixes correctly the issue #52454 Screen.Recording.2024-11-13.at.13.42.21.mov |
Contributor
There was a problem hiding this comment.
Screen.Recording.2024-11-13.at.18.24.26.mov
#52453 : Reverts back to the condition where user is logged out.
Screen.Recording.2024-11-13.at.18.29.40.mov
I can still reproduce these issues with slightly different steps:
- Go to https://staging.new.expensify.com/ and log in with a new account
- Select Something else on the onboarding modal
- Click on FAB > Start chat and enter an email of another user
- In 1:1 chat click on + > Pay someone
- Enter the amount and proceed to the next step
- Select Pay with Expensify
- Go offline
- Go online
Screen.Recording.2024-11-13.at.18.37.55.mov
lakchote
approved these changes
Nov 13, 2024
Contributor
|
@mountiny It fixes #52454 But I can still reproduce #52456 and #52455 More details #52469 (review) |
Contributor
Author
|
We went ahead with demoting nd fixing the one real blocker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Straight Reverts #50835
cc @arosiclair
Details
Fixes the pay someone flow when attempting to validate the account. When there is a Onyx update gap detected after calling
ValidateLogin, we use the newauthTokenin the response before attempting to fetch missing updates since the current authToken is invalidated.Fixed Issues
$ #52454
$ #52456
$ #52455
$ #52453
Tests
Confirm the linked blockers are no longer reproducible
Offline tests
None
QA Steps
Same as Tests