Skip to content

fix bug with default exporter #52307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lakchote merged 2 commits into from
Nov 12, 2024
Merged

fix bug with default exporter #52307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd2056d
fix bug with default exporter
ZhenjaHorbach Nov 11, 2024
479d368
add comments for new changes
ZhenjaHorbach Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/pages/workspace/accounting/qbd/export/QuickbooksDesktopExportPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ function QuickbooksDesktopExportPage({policy}: WithPolicyConnectionsProps) {
{
description: translate('workspace.accounting.preferredExporter'),
onPress: () => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_PREFERRED_EXPORTER.getRoute(policyID)),
title: qbdConfig?.export?.exporter ?? policyOwner,
// We use the logical OR (||) here instead of ?? because `exporter` could be an empty string
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
Comment thread
lakchote marked this conversation as resolved.
title: qbdConfig?.export?.exporter || policyOwner,
subscribedSettings: [CONST.QUICKBOOKS_DESKTOP_CONFIG.EXPORTER],
},
{
Expand Down
4 changes: 3 additions & 1 deletion ...s/workspace/accounting/qbd/export/QuickbooksDesktopPreferredExporterConfigurationPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ function QuickbooksDesktopPreferredExporterConfigurationPage({policy}: WithPolic
value: exporter.email,
text: exporter.email,
keyForList: exporter.email,
isSelected: (currentExporter ?? policy?.owner) === exporter.email,
// We use the logical OR (||) here instead of ?? because `exporter` could be an empty string
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
Comment thread
ZhenjaHorbach marked this conversation as resolved.
isSelected: (currentExporter || policy?.owner) === exporter.email,
});
return options;
}, []),
Expand Down