fix display of undefined on card name after page refresh by huult · Pull Request #52301 · Expensify/App

huult · 2024-11-11T06:27:31Z

Details

Fixed Issues

$ #52140
PROPOSAL: #52140 (comment)

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the Expensify app.
Create a workspace, click on More features, and enable Company cards.
Add a company card.
Click on the Settings button on the newly added company card.
Click Card feed name.
Refresh the page.
Verify that the card name is displayed correctly without showing "Undefined Card." on input.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-12.at.12.34.51.mp4

Android: mWeb Chrome

Screen.Recording.2024-11-12.at.12.35.49.mp4

iOS: Native

Screen.Recording.2024-11-12.at.12.37.54.mp4

iOS: mWeb Safari

Screen.Recording.2024-11-12.at.12.39.05.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-11-12.at.12.29.45.mp4

MacOS: Desktop

Screen.Recording.2024-11-12.at.12.32.00.mp4

melvin-bot · 2024-11-11T06:27:36Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-11-11T07:08:03Z

@huult As this comment, I mean that we pass feedName to route when navigating to Setting Page. Let's that we did in card detail screen or the add card screen

huult · 2024-11-11T08:02:28Z

@DylanDylann I've updated it. Sorry for missing that.

DylanDylann · 2024-11-11T08:05:17Z


    const navigateToChangeFeedName = () => {
-        Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_SETTINGS_FEED_NAME.getRoute(policyID));
+        Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_SETTINGS_FEED_NAME.getRoute(policyID, feedName));


Suggested change

Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_SETTINGS_FEED_NAME.getRoute(policyID, feedName));

Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_SETTINGS_FEED_NAME.getRoute(policyID, selectedFeed));

DylanDylann · 2024-11-11T08:06:15Z

    [SCREENS.WORKSPACE.COMPANY_CARDS_SETTINGS_FEED_NAME]: {
        policyID: string;
-        currentFeedName?: string;
+        feedName?: string;


Suggested change

feedName?: string;

selectedFeed: string;

Please update in other places

@DylanDylann We can't use selectedFeed because it will make things more complex. If you want to use selectedFeed, we must also send the cardFeeds object in the parameters.

If we use selectedFeed without passing the cardFeeds object, we encounter an issue like the video below because cardFeeds is retrieved from Onyx.

VIDEO

Screen.Recording.2024-11-11.at.15.30.07.mov

In src/pages/workspace/companyCards/WorkspaceCompanyCardsSettingsFeedNamePage.tsx, we can get cardFeed from Onyx, right?

small note: Never give a video without any description and say it is a bug like in the video. When elaborating on a bug please say detailed steps, actual behavior, and expected behavior or at least a description to other people can understand that you want to say

we encounter an issue like the video below because cardFeeds is retrieved from Onyx.

Are you aware of this, and if so, do you have any suggestions for handling it?

It seems I handled it in my ref branch. Did you check it? Or is there any problem?

we won’t need to set additional parameters.

Also fine, if that we need to handle loading indicator if lastSelectedFeed isn't loaded

Got it. Will update. thank you

Can you test this case on your branch?

@huult It worked. Is there any problem?

Screen.Recording.2024-11-12.at.12.06.11.mov

DylanDylann · 2024-11-11T08:07:44Z

@huult Also please update your videos

DylanDylann · 2024-11-11T08:08:48Z

Please add one more step to verify the route display the correct selected feed when clicking on Card feed name

huult · 2024-11-11T09:55:58Z

Please add one more step to verify the route display the correct selected feed when clicking on Card feed name

@DylanDylann I added that to step 6.

DylanDylann · 2024-11-12T05:10:26Z

@huult

Also fine, if that we need to handle loading indicator if lastSelectedFeed isn't loaded

Could you try this approach if it works well we don't need to add param anymore

…d-name-on-refresh

huult · 2024-11-12T05:43:54Z

@DylanDylann We are able to use the loading indicator, which is my alternative solution that I just updated. I also updated the attachment step and code. Can you review it again?

DylanDylann · 2024-11-12T07:32:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-12.at.14.36.42.mov

Android: mWeb Chrome

Screen.Recording.2024-11-12.at.14.34.55.mov

iOS: Native

Screen.Recording.2024-11-12.at.14.38.11.mov

iOS: mWeb Safari

Screen.Recording.2024-11-12.at.14.37.30.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-12.at.14.31.27.mov

MacOS: Desktop

Screen.Recording.2024-11-12.at.14.37.05.mov

OSBotify · 2024-11-12T14:53:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-13T01:09:25Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.0.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-14T00:40:43Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.61-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

fix display of undefined on card name after page refresh

82ebccf

huult requested a review from a team as a code owner November 11, 2024 06:27

melvin-bot Bot requested review from DylanDylann and removed request for a team November 11, 2024 06:27

Add type parameter for company card setting feed name

487bc09

huult mentioned this pull request Nov 11, 2024

[HOLD for payment 2024-11-21] [$250] Web - Company cards - Undefined cards is displayed on card name when refreshing the page #52140

Closed

8 tasks

pass selected feed name when navigating to Settings Page

ae40ea5

DylanDylann reviewed Nov 11, 2024

View reviewed changes

huult added 2 commits November 12, 2024 12:21

Merge remote-tracking branch 'upstream/main' into 52140-undefined-car…

e67364f

…d-name-on-refresh

Add loading to load Onyx value

09f31d5

DylanDylann approved these changes Nov 12, 2024

View reviewed changes

melvin-bot Bot requested a review from carlosmiceli November 12, 2024 07:40

carlosmiceli approved these changes Nov 12, 2024

View reviewed changes

carlosmiceli merged commit 2fb666e into Expensify:main Nov 12, 2024

github-actions Bot mentioned this pull request Nov 13, 2024

Deploy Checklist: New Expensify 2024-11-13 #52440

Closed

41 tasks

	Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_SETTINGS_FEED_NAME.getRoute(policyID, feedName));
	Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_SETTINGS_FEED_NAME.getRoute(policyID, selectedFeed));

Uh oh!

Conversation

huult commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 11, 2024

Uh oh!

DylanDylann commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huult commented Nov 11, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huult Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann Nov 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Nov 11, 2024

Uh oh!

DylanDylann commented Nov 11, 2024

Uh oh!

huult commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann commented Nov 12, 2024

Uh oh!

huult commented Nov 12, 2024

Uh oh!

DylanDylann commented Nov 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Nov 12, 2024

Uh oh!

github-actions Bot commented Nov 13, 2024

Uh oh!

github-actions Bot commented Nov 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

huult commented Nov 11, 2024 •

edited

Loading

DylanDylann commented Nov 11, 2024 •

edited

Loading

huult Nov 11, 2024 •

edited

Loading

DylanDylann Nov 12, 2024 •

edited

Loading

huult commented Nov 11, 2024 •

edited

Loading

DylanDylann commented Nov 12, 2024 •

edited

Loading