Skip to content

fixes for scroll sync behavior #52291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quinthar merged 2 commits into from
Nov 9, 2024
+7 −1
Merged

fixes for scroll sync behavior #52291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e485359
fixes for scroll sync behavior
tscanlin Nov 9, 2024
db79826
use tocbot from cdn
tscanlin Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion help/_layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@
box-shadow: 2px 0 5px rgba(0, 0, 0, 0.1);
}

.toc-link::before {
display: none;
}

.toc-sidebar ul {
list-style: none;
padding-left: 0;
Expand Down Expand Up @@ -325,7 +329,7 @@ <h3>Get Started</h3>
</div>
</footer>

<script src="https://cdnjs.cloudflare.com/ajax/libs/tocbot/4.27.4/tocbot.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/tocbot/4.32.1/tocbot.min.js"></script>
<script>
function updateURLHashOnScroll() {
const activeLink = document.querySelector('.toc-sidebar .is-active-link');
Expand Down Expand Up @@ -360,6 +364,8 @@ <h3>Get Started</h3>
enableUrlHashUpdateOnScroll: false,
headingsOffset: 80,
scrollSmoothOffset: -80,
tocScrollingWrapper: document.querySelector('.toc-sidebar'),
tocScrollOffset: 80,
headingObjectCallback: function(obj, element) {
const tocTitle = element.getAttribute('data-toc-title');
if (tocTitle) {
Expand Down