[Workspace Feeds] Fix not found display on the company card details page#52107
Closed
VickyStash wants to merge 1 commit into
Closed
[Workspace Feeds] Fix not found display on the company card details page#52107VickyStash wants to merge 1 commit into
VickyStash wants to merge 1 commit into
Conversation
8 tasks
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
This PR is a part of the project, so @allgandalf or @DylanDylann should review it. |
Contributor
Reviewer Checklist
Screenshots/Videos |
allgandalf
approved these changes
Nov 7, 2024
allgandalf
left a comment
Contributor
There was a problem hiding this comment.
LGTM, changes make sense we want all the cards issued for the policy and not the current user (admins) cards.
Also, @mountiny or @VickyStash please mark this on as No QA 🙏
58 tasks
Contributor
Author
|
Closing, as it's a duplicate of #52152 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Explanation of Change
Fix not found display on the company card details page if the card is assigned not to the current user.
Fixed Issues
$ #51916
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same, as in the Tests section
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop