change focus background color of element by nkdengineer · Pull Request #51937 · Expensify/App

nkdengineer · 2024-11-04T07:04:40Z

Explanation of Change

Fixed Issues

$ #50779
#51784
#51788
#51786
PROPOSAL: #50779 (comment)

Tests

Log in as a copilot.
Go to Account settings.
Click on the account switcher.
Navigate through the account list via keyboard.
Verify that: The current account and the selected account will be highlighted
Do the same with workspace switcher, emoji suggestion, emoji picker
Go to the WS member/search page/New chat page and focus on an element via the keyboard
Verify that the background color is the same with the hovered element

Verify that no errors appear in the JS console

Offline tests

same as above

QA Steps

same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web-resize.mp4

Screen.Recording.2024-11-04.at.14.35.15.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-11-04T07:36:13Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkdengineer · 2024-11-04T07:43:37Z

@jjcoffee The jest test is failing on the latest main.

shawnborton · 2024-11-04T07:46:26Z

Can someone give Design a quick overview of what this PR is fixing? I thought we had already implemented this so just want to make sure I understand what bug it is fixing... thanks!

nkdengineer · 2024-11-04T07:52:22Z

We're fixing some related bugs here

Before (the previous PR)

After (This PR)

shawnborton · 2024-11-04T09:00:25Z

Ah okay that looks better. For the second screenshot above though, which color are we using? I thought the idea was to use the same color we use for hover for the arrow/keypress :focus?

jjcoffee · 2024-11-04T09:01:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2024-11-04_10.54.21.mp4

Android: mWeb Chrome

android-chrome-2024-11-04_10.57.06.mp4

iOS: Native

ios-app-2024-11-04_11.04.20.mp4

iOS: mWeb Safari

ios-safari-2024-11-04_11.06.30.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-11-04_10.28.37.mp4

MacOS: Desktop

desktop-app-2024-11-04_10.50.20.mp4

Beamanator · 2024-11-04T09:58:58Z

@nkdengineer bump on the question above - it would be GREAT to get this reviewed & merged quickly since this fixes so many blockers!

nkdengineer · 2024-11-04T10:00:37Z

@Beamanator My PR is reverted and the blocker is fixed. We're creating it again and avoiding the blockers here.

nkdengineer · 2024-11-04T10:03:30Z

Ah okay that looks better. For the second screenshot above though, which color are we using? I thought the idea was to use the same color we use for hover for the arrow/keypress :focus?

Yes, I use the hover background color.

jjcoffee

LGTM!

Beamanator · 2024-11-04T10:17:27Z

Ahhh reverted in #51795 - sorry bout that, 🏃

mjasikowski · 2024-11-04T10:26:28Z

Looks good, I can confirm it fixes all the previously raised blocker issues.
@Expensify/design would appreciate a review from your side before merging just to be extra safe.

shawnborton · 2024-11-04T10:44:27Z

Videos here look good to me 👍

OSBotify · 2024-11-04T13:52:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-04T14:40:25Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.0.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

luacmartins · 2024-11-04T20:17:38Z

FYI I think this PR caused this regression #51984. It seems like we're not handling the disabled case.

github-actions · 2024-11-06T00:03:58Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.57-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

dukenv0307 · 2024-11-22T03:56:24Z

+    }
+
+    return {
+        backgroundColor,


we should return {} to avoid overriding backgroundColor to undefined. Ref: #52246

nkdengineer added 3 commits November 4, 2024 14:03

change focus background color of element

bc43d39

fix test

a384558

fix lint

8ba8ef9

nkdengineer marked this pull request as ready for review November 4, 2024 07:36

nkdengineer requested review from a team as code owners November 4, 2024 07:36

melvin-bot Bot requested review from jjcoffee and removed request for a team November 4, 2024 07:36

nkdengineer mentioned this pull request Nov 4, 2024

[C+ Checklist Needs Completion] [$250] Copilot - Two accounts are highlighted in account list when navigating via keyboard #50779

Closed

6 tasks

jjcoffee approved these changes Nov 4, 2024

View reviewed changes

melvin-bot Bot requested a review from mjasikowski November 4, 2024 10:12

mjasikowski approved these changes Nov 4, 2024

View reviewed changes

shawnborton self-requested a review November 4, 2024 10:43

shawnborton approved these changes Nov 4, 2024

View reviewed changes

mjasikowski merged commit a3a270d into Expensify:main Nov 4, 2024

mjasikowski assigned mjasikowski and nkdengineer and unassigned mjasikowski Nov 4, 2024

github-actions Bot mentioned this pull request Nov 4, 2024

Deploy Checklist: New Expensify 2024-11-04 #51953

Closed

63 tasks

Nodebrute mentioned this pull request Nov 4, 2024

[HOLD for payment 2024-11-18] mWeb - "Saved" header is also highlighted when saved search is selected #51984

Closed

8 tasks

dukenv0307 reviewed Nov 22, 2024

View reviewed changes

Uh oh!

Conversation

nkdengineer commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 4, 2024

Uh oh!

nkdengineer commented Nov 4, 2024

Uh oh!

shawnborton commented Nov 4, 2024

Uh oh!

nkdengineer commented Nov 4, 2024

Uh oh!

shawnborton commented Nov 4, 2024

Uh oh!

jjcoffee commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Beamanator commented Nov 4, 2024

Uh oh!

nkdengineer commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Nov 4, 2024

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator commented Nov 4, 2024

Uh oh!

mjasikowski commented Nov 4, 2024

Uh oh!

shawnborton commented Nov 4, 2024

Uh oh!

OSBotify commented Nov 4, 2024

Uh oh!

github-actions Bot commented Nov 4, 2024

Uh oh!

luacmartins commented Nov 4, 2024

Uh oh!

github-actions Bot commented Nov 6, 2024

Uh oh!

dukenv0307 Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

nkdengineer commented Nov 4, 2024 •

edited

Loading

jjcoffee commented Nov 4, 2024 •

edited

Loading

nkdengineer commented Nov 4, 2024 •

edited

Loading