[NO QA]: Add new object to pick assign cards by narefyev91 · Pull Request #51791 · Expensify/App

narefyev91 · 2024-10-31T14:10:31Z

Explanation of Change

For Feed V1 we should pick available account cards from cardList object. For Feed V2 - when we introduce bank connections - we should pick all available card accounts from new API object - oAuthAccountDetails. Under this object user will have available accounts based on selected feed (Ex. oauth.chase.com).
Currently we will support both approaches in one component.

Fixed Issues

$ #51726
PROPOSAL: https://callstack-hq.slack.com/archives/C06ML6X0W9L/p1730279280761759?thread_ts=1729596921.819569&cid=C06ML6X0W9L

Tests

Use Onyx.set with mock data:

useEffect(() => { Onyx.set(${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${workspaceAccountID}, { settings: { accountManager: 9666036, accountManagerAssignmentDate: '2023-11-02 14:17:44', companyCardNicknames: { 'ofx.chase.com': '', }, companyCards: { 'Expensify Card': { asrEnabled: false, forceReimbursable: 'force_no', liabilityType: 'personal', preferredPolicy: '', reportTitleFormat: '', statementPeriodEndDay: 1, uploadLayoutSettings: null, }, 'oauth.chase.com': { asrEnabled: false, forceReimbursable: 'force_no', liabilityType: 'personal', preferredPolicy: '', reportTitleFormat: '', statementPeriodEndDay: 1, uploadLayoutSettings: null, }, }, oAuthAccountDetails: { 'oauth.chase.com': { accountList: ['C. DUNBAR...0546', 'J. HAYES...4754', 'K. BAACK...8211', 'L. BORGNINO...9008', 'C. MILES...4129', 'J. BRUSH...8303'], credentials: 'ASDF', expiration: 1730127183, }, }, technicalContactEmail: 'brad.sandt@k12itc.com', twoFactorAuthExemptEmails: ['christi.orem@k12itc.com'], useTechnicalContactBillingCard: true, }, }); }, [workspaceAccountID]);

Have any feed added
Set in code mock feed 'oauth.chase.com'
Assign card
Choose user
Verify that you can see mock cards

Verify that no errors appear in the JS console

Offline tests

Nothing changed here

QA Steps

No QA needed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-31T14:10:37Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

narefyev91 · 2024-10-31T14:11:35Z

@mountiny here changes for correct object pick

mountiny

Can you update the comments to be on one line please?

mountiny

changes look good to me thanks!

DylanDylann · 2024-10-31T17:34:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

DylanDylann · 2024-10-31T17:53:54Z

@narefyev91 Should we update other places that are using cardFeeds?.settings?.companyCards to remove ExpensifyCard

DylanDylann · 2024-10-31T17:54:31Z

I see other places where we haven't removed expensify Card

narefyev91 · 2024-10-31T17:59:36Z

I see other places where we haven't removed expensify Card

Yeah - checked those places as well - but most of them related either to pending fields or error fields or something like companyCards?.[feedType] - we do not really need to remove from that places - nothing will be influence on visibility

DylanDylann · 2024-10-31T18:07:04Z

I think we should do it all for consistency. But this seems to be an urgent PR, we can merge it immediately

@mountiny Leave your final decision

mountiny · 2024-10-31T18:24:27Z

I think we can handle that later if it will cause confusion or problems

OSBotify · 2024-10-31T18:34:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-04T14:39:49Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-06T00:03:22Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.57-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

narefyev91 added 3 commits October 31, 2024 15:44

Add new object to pick Assigned cards

90f136c

add earlier return

21ebfb3

update card name

83dd513

narefyev91 requested a review from a team as a code owner October 31, 2024 14:10

melvin-bot Bot requested review from allgandalf and removed request for a team October 31, 2024 14:10

mountiny assigned narefyev91 Oct 31, 2024

mountiny reviewed Oct 31, 2024

View reviewed changes

Comment thread src/types/onyx/CardFeeds.ts Outdated

narefyev91 added 3 commits October 31, 2024 16:24

update comments

000e44d

combine v1 and v2

94bc81b

clean up

ff23659

mountiny approved these changes Oct 31, 2024

View reviewed changes

DylanDylann approved these changes Oct 31, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny October 31, 2024 18:04

mountiny merged commit db1700a into Expensify:main Oct 31, 2024

github-actions Bot mentioned this pull request Nov 4, 2024

Deploy Checklist: New Expensify 2024-11-04 #51953

Closed

63 tasks

melvin-bot Bot mentioned this pull request Nov 6, 2024

[PAID] [Company cards] Update how we fetch company cards #51726

Closed

Uh oh!

Conversation

narefyev91 commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 31, 2024

Uh oh!

narefyev91 commented Oct 31, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Oct 31, 2024

Uh oh!

DylanDylann commented Oct 31, 2024

Uh oh!

narefyev91 commented Oct 31, 2024

Uh oh!

DylanDylann commented Oct 31, 2024

Uh oh!

mountiny commented Oct 31, 2024

Uh oh!

OSBotify commented Oct 31, 2024

Uh oh!

github-actions Bot commented Nov 4, 2024

Uh oh!

github-actions Bot commented Nov 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

narefyev91 commented Oct 31, 2024 •

edited

Loading

DylanDylann commented Oct 31, 2024 •

edited

Loading