change background color of focus element by nkdengineer · Pull Request #51158 · Expensify/App

nkdengineer · 2024-10-21T08:13:09Z

Details

Fixed Issues

$ #50779
PROPOSAL: #50779 (comment)

Tests

Log in as a copilot.
Go to Account settings.
Click on the account switcher.
Navigate through the account list via keyboard.
Verify that: The current account and the selected account will be highlighted
Do the same with workspace switcher, emoji suggestion, emoji picker

Verify that no errors appear in the JS console

Offline tests

same as above

QA Steps

same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

desktop.mov

melvin-bot · 2024-10-21T09:05:43Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-10-21T09:09:21Z

For this case here where you are using tabs to focus into the currently selected Copilot row:

Can you show us what it looks like when you use mouse hover over that same row? I am wondering if we actually change the background color on :hover of an active/selected row like that...

jjcoffee · 2024-10-21T11:26:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2024-10-21_15.00.36.mp4

Android: mWeb Chrome

android-chrome-2024-10-21_14.57.41.mp4

iOS: Native

ios-app-2024-10-21_15.11.00.mp4

iOS: mWeb Safari

ios-safari-2024-10-21_15.12.24.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-10-21_13.40.38.mp4

MacOS: Desktop

desktop-app-2024-10-21_13.49.14.mp4

jjcoffee · 2024-10-21T11:44:51Z

@shawnborton Here's a bit more detail on how it looks for the account switcher:

desktop-chrome-account-switcher-2024-10-21_13.43.35.mp4

shawnborton · 2024-10-21T12:46:46Z

Yeah, it seems like from your video that the :hover style doesn't override the .active style of the currently selected option row. So I am thinking we should reuse that same behavior here for the keyboard navigation as well.

nkdengineer · 2024-10-23T10:21:03Z

BUG: On a fresh load (or after reloading the page), the initial state of the account switcher "currently selected" account has the hover background colour. Once you interact with the keyboard the correct background colour is shown.

@jjcoffee I fixed this bug. Please help to check again.

nkdengineer · 2024-10-23T10:22:27Z

BUG?: The hovered (via keyboard) item is not cleared when the mouse hovers over another account. Unsure of the expected behaviour here, but it feels a bit strange to have multiple hovered selections.

I don't think it's a bug.

jjcoffee · 2024-10-23T11:53:15Z

@shawnborton Do you have any thoughts on whether this is the correct behaviour here?

dannymcclain · 2024-10-23T13:14:37Z

@shawnborton correct me if I'm wrong, but haven't we talked before about not showing the hover state for active items? I know we at least made that decision for LHN items (chats, search, settings items).

shawnborton · 2024-10-23T17:25:23Z

Yeah, that is the exact behavior I was imagining! Basically the hover style DOES NOT override the .selected/.active row style, no matter if you use the mouse or the keyboard.

jjcoffee · 2024-10-25T07:58:00Z

Basically the hover style DOES NOT override the .selected/.active row style, no matter if you use the mouse or the keyboard.

@nkdengineer Are you able to make this change?

jjcoffee · 2024-10-25T07:59:02Z

@Expensify/design Do you have any thoughts on whether this should be considered a bug?

shawnborton · 2024-10-25T08:26:59Z

I don't think that's considered a bug. The reality is that the row that is selected via the keyboard could still be selected via the enter key right? But at the same time, technically you could use your mouse to hover over a different row and tap on it.

So basically I think we'd just treat the mouse & keyboard as independent input devices and not try to do anything too tricky. Curious what the other designers think too though!

dannymcclain · 2024-10-25T13:42:08Z

I don't think that's considered a bug. The reality is that the row that is selected via the keyboard could still be selected via the enter key right? But at the same time, technically you could use your mouse to hover over a different row and tap on it.

So basically I think we'd just treat the mouse & keyboard as independent input devices and not try to do anything too tricky. Curious what the other designers think too though!

Definitely agree with you. This seems fine as is. I don't think we need to try to get overly complicated and tricky. If a user is weirdly using both their keyboard and mouse at the same time, that's on them 🤷‍♂️

nkdengineer · 2024-10-25T17:50:19Z

@nkdengineer Are you able to make this change?

@jjcoffee Does that mean the background should change to the hover bg if we focus on the selected element?

dannymcclain · 2024-10-25T18:38:48Z

Does that mean the background should change to the hover bg if we focus on the selected element?

No, the selected/active element always has the selected/active background—never the hover background.

nkdengineer · 2024-10-29T09:11:54Z

Got it.

nkdengineer · 2024-10-29T09:31:37Z

@jjcoffee I updated.

jjcoffee

LGTM, thanks for the fix!

OSBotify · 2024-10-30T11:32:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-31T11:40:48Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.0.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

This reverts commit 10336ac, reversing changes made to 95aab1f.

mjasikowski · 2024-10-31T14:24:15Z

Revert PR created

…x/50779 [CP Staging] Revert "Merge pull request #51158 from nkdengineer/fix/50779"

…x/50779 [CP Staging] Revert "Merge pull request #51158 from nkdengineer/fix/50779" (cherry picked from commit 9406610) (CP triggered by Beamanator)

github-actions · 2024-11-04T14:13:32Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.56-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

github-actions · 2024-11-04T14:38:28Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.0.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-06T00:02:01Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.57-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

nkdengineer added 2 commits October 21, 2024 15:12

change background color of focus element

ec1b3de

fix lint

46dad82

nkdengineer marked this pull request as ready for review October 21, 2024 09:05

nkdengineer requested review from a team as code owners October 21, 2024 09:05

melvin-bot Bot requested review from jjcoffee and removed request for a team October 21, 2024 09:05

This comment was marked as resolved.

Sign in to view

nkdengineer added 2 commits October 23, 2024 17:14

Merge branch 'main' into fix/50779

d8c47b9

fix bg for selected item

d270f92

nkdengineer added 2 commits October 23, 2024 17:24

fix prettier

186deb4

Merge branch 'main' into fix/50779

1ef6ff2

This comment was marked as resolved.

Sign in to view

Merge branch 'main' into fix/50779

7d940f9

add shouldRemoveHoverBackground prop

8edc58d

jjcoffee approved these changes Oct 29, 2024

View reviewed changes

melvin-bot Bot requested a review from mjasikowski October 29, 2024 09:56

mjasikowski assigned nkdengineer Oct 29, 2024

mjasikowski approved these changes Oct 29, 2024

View reviewed changes

mjasikowski merged commit 10336ac into Expensify:main Oct 30, 2024

github-actions Bot mentioned this pull request Oct 31, 2024

Deploy Checklist: New Expensify 2024-10-31 #51778

Closed

This was referenced Oct 31, 2024

Web - Search - Group expense box is not highlighted evenly when selected by keyboard #51784

Closed

Workspace - Item (member, category, tag etc) in focus has two shades when selected by keyboard #51788

Closed

mjasikowski added a commit that referenced this pull request Oct 31, 2024

Revert "Merge pull request #51158 from nkdengineer/fix/50779"

ae39b6d

This reverts commit 10336ac, reversing changes made to 95aab1f.

This was referenced Oct 31, 2024

Group chat - Selected user is highlighted after clicking Add to group #51786

Closed

[CP Staging] Revert "Merge pull request #51158 from nkdengineer/fix/50779" #51795

Merged

mountiny added a commit that referenced this pull request Nov 1, 2024

Merge pull request #51795 from Expensify/michal-revert-nkdengineer/fi…

9406610

…x/50779 [CP Staging] Revert "Merge pull request #51158 from nkdengineer/fix/50779"

github-actions Bot mentioned this pull request Nov 4, 2024

Deploy Checklist: New Expensify 2024-11-04 #51953

Closed

63 tasks

melvin-bot Bot mentioned this pull request Nov 4, 2024

[C+ Checklist Needs Completion] [$250] Copilot - Two accounts are highlighted in account list when navigating via keyboard #50779

Closed

6 tasks

Uh oh!

Conversation

nkdengineer commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 21, 2024

Uh oh!

shawnborton commented Oct 21, 2024

Uh oh!

jjcoffee commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee commented Oct 21, 2024

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

shawnborton commented Oct 21, 2024

Uh oh!

nkdengineer commented Oct 23, 2024

Uh oh!

nkdengineer commented Oct 23, 2024

Uh oh!

jjcoffee commented Oct 23, 2024

Uh oh!

This comment was marked as resolved.

dannymcclain commented Oct 23, 2024

Uh oh!

shawnborton commented Oct 23, 2024

Uh oh!

jjcoffee commented Oct 25, 2024

Uh oh!

jjcoffee commented Oct 25, 2024

Uh oh!

shawnborton commented Oct 25, 2024

Uh oh!

dannymcclain commented Oct 25, 2024

Uh oh!

nkdengineer commented Oct 25, 2024

Uh oh!

dannymcclain commented Oct 25, 2024

Uh oh!

nkdengineer commented Oct 29, 2024

Uh oh!

nkdengineer commented Oct 29, 2024

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 30, 2024

Uh oh!

github-actions Bot commented Oct 31, 2024

Uh oh!

mjasikowski commented Oct 31, 2024

Uh oh!

github-actions Bot commented Nov 4, 2024

Uh oh!

github-actions Bot commented Nov 4, 2024

Uh oh!

github-actions Bot commented Nov 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nkdengineer commented Oct 21, 2024 •

edited

Loading

jjcoffee commented Oct 21, 2024 •

edited

Loading