Fix receipt upload size issue by OlimpiaZurek · Pull Request #50329 · Expensify/App

OlimpiaZurek · 2024-10-07T12:02:46Z

Details

This PR fixes an issue where requests fail because the uploaded file size exceeds the 10MB limit after HEIC to JPEG conversion. The fix includes adding a separate const RECEIPT_IMAGE_MAX_SIZE=10MB to align with the backend limit for receipt uploads.

QA steps:

Open the app and log in with valid credentials.
Navigate to the section where you can create an expense.
Upload the a HEIC image larger than 2.5MB.
Verify that the image uploads without triggering an error

Fixed Issues

$ #49999
PROPOSAL: #49999 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-07T12:02:51Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eh2077 · 2024-10-07T13:49:37Z

@OlimpiaZurek Would you mind updating test steps? Thx

eh2077 · 2024-10-07T14:37:24Z

I was able to upload the receipt on my simulator, is it expected?

0-ios.mp4

OlimpiaZurek · 2024-10-07T16:50:30Z

I was able to upload the receipt on my simulator, is it expected?

0-ios.mp4

Hey @eh2077! You should check if the heic image is uploaded correctly. I added QA steps to the PR description.

eh2077 · 2024-10-08T13:42:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

0-ios.mp4

0-ios1.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

eh2077

Tested well, just minor comments

eh2077 · 2024-10-08T14:23:20Z

    const [reportNameValuePairs] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID ?? -1}`);
+    const policy = usePolicy(report?.policyID);
+    const [personalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST);
+    const [skipConfirmation] = useOnyx(`${ONYXKEYS.COLLECTION.SKIP_CONFIRMATION}${transactionID}`);


Is it necessary to have the nullish coalescing? like

Suggested change

const [skipConfirmation] = useOnyx(`${ONYXKEYS.COLLECTION.SKIP_CONFIRMATION}${transactionID}`);

const [skipConfirmation] = useOnyx(`${ONYXKEYS.COLLECTION.SKIP_CONFIRMATION}${transactionID ?? -1}`);

I saw line 67 has similar usage for reportID.

eh2077

LGTM!

mountiny

Thanks! One NAB comment but would be nice to get the styling right before merging

OSBotify · 2024-10-09T11:43:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-09T20:47:59Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.47-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-10T23:03:10Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.47-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dominictb · 2025-01-14T05:08:00Z

                }

-                if (!Str.isImage(file.name ?? '') && (file?.size ?? 0) > CONST.API_ATTACHMENT_VALIDATIONS.MAX_SIZE) {
+                if (!Str.isImage(file.name ?? '') && (file?.size ?? 0) > CONST.API_ATTACHMENT_VALIDATIONS.RECEIPT_MAX_SIZE) {


Should have updated the max size in error message to 10MB (formerly 24MB) as well. Caused this issue #53341.

Fix receipt upload size issue

549d1e2

OlimpiaZurek requested a review from a team as a code owner October 7, 2024 12:02

melvin-bot Bot requested a review from eh2077 October 7, 2024 12:02

melvin-bot Bot removed the request for review from a team October 7, 2024 12:02

fix eslint check

ba54c20

eh2077 reviewed Oct 8, 2024

View reviewed changes

fallback transactionId

cc493e0

eh2077 approved these changes Oct 8, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny October 8, 2024 15:02

mountiny assigned OlimpiaZurek Oct 8, 2024

mountiny previously approved these changes Oct 8, 2024

View reviewed changes

Comment thread src/CONST.ts

small fix

5141a8d

OlimpiaZurek dismissed mountiny’s stale review via 5141a8d October 9, 2024 08:00

mountiny approved these changes Oct 9, 2024

View reviewed changes

mountiny merged commit 3777223 into Expensify:main Oct 9, 2024

github-actions Bot mentioned this pull request Oct 9, 2024

Deploy Checklist: New Expensify 2024-10-09 #50518

Closed

58 tasks

melvin-bot Bot mentioned this pull request Oct 10, 2024

[HOLD for payment 2024-10-17] The Heic format image showing as 2.5MB is uploading with size over 10MB #49999

Closed

6 tasks

dominictb reviewed Jan 14, 2025

View reviewed changes

	const [skipConfirmation] = useOnyx(`${ONYXKEYS.COLLECTION.SKIP_CONFIRMATION}${transactionID}`);
	const [skipConfirmation] = useOnyx(`${ONYXKEYS.COLLECTION.SKIP_CONFIRMATION}${transactionID ?? -1}`);

Uh oh!

Conversation

OlimpiaZurek commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 7, 2024

Uh oh!

eh2077 commented Oct 7, 2024

Uh oh!

eh2077 commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OlimpiaZurek commented Oct 7, 2024

Uh oh!

eh2077 commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

eh2077 Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

OlimpiaZurek Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 9, 2024

Uh oh!

github-actions Bot commented Oct 9, 2024

Uh oh!

github-actions Bot commented Oct 10, 2024

Uh oh!

dominictb Jan 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

OlimpiaZurek commented Oct 7, 2024 •

edited

Loading

eh2077 commented Oct 7, 2024 •

edited

Loading

eh2077 commented Oct 8, 2024 •

edited

Loading