Remove invalid recent waypoint when creating / editing distance request by wildan-m · Pull Request #50323 · Expensify/App

wildan-m · 2024-10-07T06:26:59Z

Details

The PR will fix invalid waypoints aren't cleared when a request fails

Fixed Issues

$ #48631
PROPOSAL: #48631 (comment)

Tests

Open app
Create a workspace
Go to workspace chat
Go offline
Go to submit distance expense
Enter an invalid waypoint and click save
Add another waypoint and continue to submit the expense
Go online
Verify the request fails
Green plus, submit an expense, distance
Go to enter a waypoint
Verify invalid waypoints removed from suggestion list

Verify that no errors appear in the JS console

Offline tests

Same as test

QA Steps

Same as test

PR Author Checklist

Screenshots/Videos

Android: Native

Kapture.2024-10-07.at.13.09.52.mp4

Android: mWeb Chrome

Kapture.2024-10-07.at.13.15.30.mp4

iOS: Native

Kapture.2024-10-07.at.12.57.39.mp4

iOS: mWeb Safari

Kapture.2024-10-07.at.13.05.33.mp4

MacOS: Chrome / Safari

Kapture.2024-10-07.at.11.12.26.mp4

MacOS: Desktop

Kapture.2024-10-07.at.13.18.32.mp4

…x/48631-remove-invalid-recent-waypoint

melvin-bot · 2024-10-07T06:27:04Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

wildan-m · 2024-10-07T06:29:25Z

@suneox @neil-marcellini I use sanitizeRecentWaypoints to remove pendingAction before adding waypoints to the parameters. If BE returns a validated list without pendingAction, the function might not be required.

suneox · 2024-10-07T15:18:27Z

@wildan-m As mentioned earlier, we also need to handle TrackExpense case

Screen.Recording.2024-10-07.at.22.09.39.mp4

…x/48631-remove-invalid-recent-waypoint

wildan-m · 2024-10-08T02:24:29Z

@suneox nice catch! the track expense part has been resolved

suneox · 2024-10-08T14:47:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

Track expense:

Screen.Recording.2024-10-08.at.21.18.35.mp4

Edit expense:

Screen.Recording.2024-10-08.at.20.51.18.mp4

Submit expense

Screen.Recording.2024-10-08.at.21.23.03.mp4

MacOS: Desktop

Screen.Recording.2024-10-08.at.21.25.18.mp4

Android: Native

Screen.Recording.2024-10-08.at.21.40.27.mp4

Android: mWeb Chrome

Screen.Recording.2024-10-08.at.21.37.57.mp4

iOS: Native

Screen.Recording.2024-10-08.at.21.28.11.mp4

iOS: mWeb Safari

Screen.Recording.2024-10-08.at.21.35.18.mp4

suneox

LGTM. Verify it works as expected in the following three cases: track expense, submit expense and edit expense.

neil-marcellini

Looks great, thank you!

neil-marcellini · 2024-10-08T17:58:43Z

+ * @param waypoints - The collection of waypoints to sanitize.
+ * @returns The sanitized collection of waypoints.
+ */
+function sanitizeRecentWaypoints(waypoints: WaypointCollection): WaypointCollection {


Why do we need to do this?

Ah I see, the backend saves the waypoints as is, and we don't want to save the pendingAction property. I'm good with this then.

OSBotify · 2024-10-08T18:17:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-09T20:47:56Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.47-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-10T23:03:07Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.47-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aldo-expensify · 2025-05-07T15:55:10Z

+        const {pendingAction, ...rest} = waypoint as RecentWaypoint;
+        acc[key] = rest;
+        return acc;
+    }, {} as WaypointCollection);


There was no need for casting here, the reducer function just needed the type declared:

(acc: WaypointCollection, [key, waypoint]) => {...}

then the cast is not needed

wildan-m added 5 commits September 23, 2024 11:18

Revert recent waypoints when something failure

097a44b

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

fc8b93b

…x/48631-remove-invalid-recent-waypoint

move failData to updateMoneyRequestDistance

f18311e

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

22565de

…x/48631-remove-invalid-recent-waypoint

Create sanitizeRecentWaypoints before calling any related API, fix lint

c77392a

wildan-m requested a review from a team as a code owner October 7, 2024 06:27

melvin-bot Bot requested a review from suneox October 7, 2024 06:27

melvin-bot Bot removed the request for review from a team October 7, 2024 06:27

wildan-m mentioned this pull request Oct 7, 2024

[HOLD for payment 2024-10-17] [$250] Distance - Invalid waypoints aren't cleared when a request fails #48631

Closed

6 tasks

wildan-m added 3 commits October 8, 2024 05:24

WIP track expense clear invalid waypoints

90b02ef

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

1da67ac

…x/48631-remove-invalid-recent-waypoint

Resolve clear invalid waypoints on track expense

c9f9ad3

suneox approved these changes Oct 8, 2024

View reviewed changes

melvin-bot Bot requested a review from neil-marcellini October 8, 2024 14:49

neil-marcellini approved these changes Oct 8, 2024

View reviewed changes

neil-marcellini merged commit 6d74fe7 into Expensify:main Oct 8, 2024

github-actions Bot mentioned this pull request Oct 9, 2024

Deploy Checklist: New Expensify 2024-10-09 #50518

Closed

58 tasks

aldo-expensify reviewed May 7, 2025

View reviewed changes

Uh oh!

Conversation

wildan-m commented Oct 7, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 7, 2024

Uh oh!

wildan-m commented Oct 7, 2024

Uh oh!

suneox commented Oct 7, 2024

Uh oh!

wildan-m commented Oct 8, 2024

Uh oh!

suneox commented Oct 8, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

suneox left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 8, 2024

Uh oh!

github-actions Bot commented Oct 9, 2024

Uh oh!

github-actions Bot commented Oct 10, 2024

Uh oh!

aldo-expensify May 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

suneox left a comment •

edited

Loading