Skip to content

Allow users to decline/cancel when IOU total balance is 0#5020

Merged
Julesssss merged 1 commit into
Expensify:mainfrom
Santhosh-Sellavel:santhosh_allow_users_reject_requests_when_0_balance
Sep 3, 2021
Merged

Allow users to decline/cancel when IOU total balance is 0#5020
Julesssss merged 1 commit into
Expensify:mainfrom
Santhosh-Sellavel:santhosh_allow_users_reject_requests_when_0_balance

Conversation

@Santhosh-Sellavel

Copy link
Copy Markdown
Collaborator

@Julesssss

Details

Allow users to cancel/decline IOU requests until transactions are settled.

Fixed Issues

$ #4998

Tests & QA Steps

  1. Open New Expensify on two separate devices and login with two different accounts. (Accounts User A & User B)
  2. Settle up if there are any pending IOU transactions between two accounts.
  3. From User A request $100 to User B.
  4. From User B request $100 to User A.
  5. In both devices click view details on the IOU Request

Fix:

Now IOU Details Page will open, Relevant transactions should be able to cancel or decline.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-09-02 at 10 10 30 PM

Mobile Web

Simulator Screen Shot - iPhone 11 - 2021-09-02 at 21 52 57

Desktop

Screenshot 2021-09-02 at 9 48 54 PM

iOS

Simulator Screen Shot - iPhone 12 - 2021-09-02 at 21 46 17

Android

Screenshot_1630599380

@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner September 2, 2021 17:04
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team September 2, 2021 17:04

@Julesssss Julesssss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me on iOS & web

@Julesssss Julesssss merged commit 063311a into Expensify:main Sep 3, 2021
@OSBotify

OSBotify commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.0.92-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify

botify commented Sep 3, 2021

Copy link
Copy Markdown

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-10. 🎊

@OSBotify

OSBotify commented Sep 4, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants