Skip to content

Fetch reimbursementAccount data on Login#5012

Merged
Dal-Papa merged 1 commit into
mainfrom
cmartins-fetch-reimbursmentAccount-on-signin
Sep 3, 2021
Merged

Fetch reimbursementAccount data on Login#5012
Dal-Papa merged 1 commit into
mainfrom
cmartins-fetch-reimbursmentAccount-on-signin

Conversation

@luacmartins

@luacmartins luacmartins commented Sep 2, 2021

Copy link
Copy Markdown
Contributor

Details

Investigating https://github.com/Expensify/Expensify/issues/176091, we found that the problem occurs when users are jumping in and out of accounts. We wipe Onyx data when the user signs out, and those particular keys are only fetched once we click Get Started again, thus updating the text. This PR fetches the data when the user logs in.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/176091

Tests

  1. Login in to New Expensify - make sure your account does not have a Business Account setup yet.
  2. Click Settings > Select a Workspace (or create a new one) > Get Started.
  3. Follow the steps in this SO to add a Pending Account. Stop when you see the Get Started button change to Finish Setup.
  4. Log out and log back in.
  5. Navigate back to Settings > Select the previous Workspace.
  6. Verify that the button still says Finish Setup.

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mWeb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins self-assigned this Sep 2, 2021
@luacmartins luacmartins marked this pull request as ready for review September 2, 2021 17:01
@luacmartins luacmartins requested a review from a team as a code owner September 2, 2021 17:01
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team September 2, 2021 17:01
@Dal-Papa Dal-Papa merged commit 843e215 into main Sep 3, 2021
@Dal-Papa Dal-Papa deleted the cmartins-fetch-reimbursmentAccount-on-signin branch September 3, 2021 10:32
@OSBotify

OSBotify commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Dal-Papa in version: 1.0.92-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@isagoico

isagoico commented Sep 3, 2021

Copy link
Copy Markdown

@Dal-Papa Hello! We're currently blocker from testing this flow, we don't have a testing domain without the expensify card. Can this be tested on your side?

@luacmartins

Copy link
Copy Markdown
Contributor Author

Tested on staging! All good.

@OSBotify

OSBotify commented Sep 4, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants