Fetch reimbursementAccount data on Login#5012
Merged
Merged
Conversation
Dal-Papa
approved these changes
Sep 3, 2021
54 tasks
Contributor
|
@Dal-Papa Hello! We're currently blocker from testing this flow, we don't have a testing domain without the expensify card. Can this be tested on your side? |
Contributor
Author
|
Tested on staging! All good. |
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Investigating https://github.com/Expensify/Expensify/issues/176091, we found that the problem occurs when users are jumping in and out of accounts. We wipe Onyx data when the user signs out, and those particular keys are only fetched once we click Get Started again, thus updating the text. This PR fetches the data when the user logs in.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/176091
Tests
Settings > Select a Workspace (or create a new one) > Get Started.Pending Account. Stop when you see theGet Startedbutton change toFinish Setup.Settings > Select the previous Workspace.Finish Setup.QA Steps
Steps above.
Tested On
Screenshots
Web
web.mov
Mobile Web
mWeb.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov