Updated selected transaction If getting new updates by cretadn22 · Pull Request #49829 · Expensify/App

cretadn22 · 2024-09-27T02:30:05Z

Details

Fixed Issues

$ #49795
PROPOSAL: #49795 (comment)

Tests

Same QA steps

Offline tests

QA Steps

Go to Search Page
Select an expense
Click on "View" and hold expense on report detail page
Back to Search page and click on bulk action
Confirm that the action in the bulk actions displays correctly.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen175.mov

Android: mWeb Chrome

Screen174.mov

iOS: Native

Screen173.mov

iOS: mWeb Safari

Screen172.mov

MacOS: Chrome / Safari

Screen171.mov

MacOS: Desktop

Screen170.mov

melvin-bot · 2024-09-27T02:30:11Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jjcoffee · 2024-09-27T12:12:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2024-10-03_10.55.25.mp4

Android: mWeb Chrome

android-chrome-2024-10-03_10.57.49.mp4

iOS: Native

ios-app-2024-10-03_11.26.32.mp4

iOS: mWeb Safari

ios-safari-2024-10-03_11.28.15.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-10-03_10.45.15.mp4

MacOS: Desktop

desktop-app-2024-10-03_10.49.43.mp4

jjcoffee · 2024-09-27T12:31:20Z

@cretadn22 You have conflicts!

jjcoffee · 2024-09-27T12:39:10Z

This looks good and is testing well. I agree with the approach for the bulk action as it makes sense that once you make an action, your selection is reset.

I'm only unsure about the flow when opening a transaction detail view; here having the selection reset feels a bit unnatural/unusual. @luacmartins Do you have any thoughts, or should we just go with this for now?

desktop-chrome-transaction-detail-2024-09-27_14.38.48.mp4

luacmartins · 2024-09-27T13:24:20Z

I agree that it feels a bit weird to deselect everything when a user takes an action on the report/transaction RHP view. @JmillsExpensify what do you think?

JmillsExpensify · 2024-09-27T14:03:13Z

Yes, agreed that we shouldn't de-select based on a specific user action in the report/transaction, because those are technically actions that are happening elsewhere anyway (specifically the individual report or transaction itself).

jjcoffee · 2024-09-30T07:45:08Z

@cretadn22 Can you look into a solution that addresses this issue?

cretadn22 · 2024-10-01T09:54:56Z

@jjcoffee I am working on another solution. My idea is reset selected transaction when we hold/unhold options

jjcoffee · 2024-10-03T08:51:34Z

@cretadn22 Thanks for the changes, they seem to work well! Can you give a brief explanation of the new approach?

Also, just to flag that now when bulk selecting and choosing an action, the selection will no longer reset as with the previous approach. Are we happy with that? @luacmartins @JmillsExpensify

jjcoffee · 2024-10-03T09:00:00Z

@cretadn22 This is maybe not a blocker, but I feel like the bulk action menu should be optimistically updated. Currently on slower connections the menu item won't switch (e.g. Hold --> Unhold) until the API request completes.

cretadn22 · 2024-10-03T11:28:57Z

@cretadn22 Thanks for the changes, they seem to work well! Can you give a brief explanation of the new approach?

@jjcoffee I forgot to give an update.

Here's my summary: Currently, the SearchPage uses data from ONYXKEYS.COLLECTION.SNAPSHOT, and the selected transaction is stored in the search context. When ONYXKEYS.COLLECTION.SNAPSHOT is updated, we need to updated the selected transaction in the context to ensure the value remains is up-to-date. This PR addresses that.

Also, just to flag that now when bulk selecting and choosing an action, the selection will no longer reset as with the previous approach.

We don't update anything here, keep the old behavior on staging

cretadn22 · 2024-10-03T11:31:45Z

@jjcoffee

Currently on slower connections the menu item won't switch (e.g. Hold --> Unhold) until the API request completes.

I don't quite understand the issue. It worked smoothly on my end. Could you provide a video to help clarify?

cretadn22 · 2024-10-03T11:32:12Z

I will update new videos soon

jjcoffee · 2024-10-03T11:42:14Z

I don't quite understand the issue. It worked smoothly on my end. Could you provide a video to help clarify?

Test with network conditions set to Slow 3G, for example. It might be that the snapshot is not updated optimistically though, in which case fixing would be out of scope for this issue, I think!

luacmartins · 2024-10-03T14:32:09Z

Also, just to flag that now when bulk selecting and choosing an action, the selection will no longer reset as with the previous approach. Are we happy with that? @luacmartins @JmillsExpensify

Yes, I think Jason confirmed that here

jjcoffee · 2024-10-03T14:37:30Z

Yes, I think Jason confirmed that here

That was confirming that we shouldn't deselect after holding from the transaction detail view (in the RHP), which has now been implemented. But with the new approach there's also no deselection after the bulk action is made, which is the same behaviour as on staging so not a big issue but just wanted to raise it in case!

luacmartins · 2024-10-03T14:44:50Z

Ah I see what you're saying. Yea, let's keep the behavior we already have

cretadn22 · 2024-10-03T17:03:11Z

Test with network conditions set to Slow 3G, for example. It might be that the snapshot is not updated optimistically though, in which case fixing would be out of scope for this issue, I think!

Yeah, got it!

cretadn22 · 2024-10-03T17:10:32Z

@jjcoffee I already updated the test steps and all videos.

jjcoffee

LGTM!

luacmartins

LGTM

OSBotify · 2024-10-04T15:48:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-04T21:16:54Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.45-1 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-07T22:33:31Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.45-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ishpaul777 · 2024-10-16T19:04:05Z

+        });
+        setSelectedTransactions(newTransactionList, data);
+        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
+    }, [data, setSelectedTransactions]);


{BZ CHECKLIST} This Caused this regression #49829, Here we only handle the cases where report data was returned but SearchUtils.getSections returns three types of data depending on the condition:

App/src/libs/SearchUtils.ts

Lines 320 to 328 in d03066f

function getSections(type: SearchDataTypes, status: SearchStatus, data: OnyxTypes.SearchResults['data'], metadata: OnyxTypes.SearchResults['search']) {

if (type === CONST.SEARCH.DATA_TYPES.CHAT) {

return getReportActionsSections(data);

}

if (status === CONST.SEARCH.STATUS.EXPENSE.ALL) {

return getTransactionsSections(data, metadata);

}

return getReportSections(data, metadata);

}

Is the link above correct? It's a reference to this PR

oops! Sorry this one #50286

cretadn22 requested a review from a team as a code owner September 27, 2024 02:30

melvin-bot Bot requested review from jjcoffee and removed request for a team September 27, 2024 02:30

luacmartins self-requested a review September 27, 2024 13:25

reset selected transaction if getting new updates

f8769d8

cretadn22 force-pushed the deselect-option-when-bulk-action branch from 4d1ee9c to f8769d8 Compare October 3, 2024 03:13

cretadn22 marked this pull request as draft October 3, 2024 03:14

cretadn22 added 2 commits October 3, 2024 10:32

adjust lint error and TS error

2cecae1

adjust lint

10767d0

cretadn22 marked this pull request as ready for review October 3, 2024 03:45

cretadn22 changed the title ~~deselect on bulk action~~ Updated selected transaction If getting new updates Oct 3, 2024

This comment was marked as outdated.

Sign in to view

jjcoffee approved these changes Oct 4, 2024

View reviewed changes

luacmartins approved these changes Oct 4, 2024

View reviewed changes

luacmartins merged commit fa7c3e6 into Expensify:main Oct 4, 2024

github-actions Bot mentioned this pull request Oct 4, 2024

Deploy Checklist: New Expensify 2024-10-04 #50274

Closed

53 tasks

jaydamani mentioned this pull request Oct 5, 2024

[HOLD for payment 2024-10-16] Search - Selected expense does not remain selected, gets auto deselected #50286

Closed

6 tasks

This was referenced Oct 7, 2024

Revert "Updated selected transaction If getting new updates" #50322

Closed

Updated selected transaction If getting new updates (also fixed for cases where the status is set to ALL) #50347

Merged

melvin-bot Bot mentioned this pull request Oct 7, 2024

[HOLD for payment 2024-10-14] [$250] [Search v1.2] Optimistically update search page when bulk holding/unholding expenses #49795

Closed

ishpaul777 reviewed Oct 16, 2024

View reviewed changes

	function getSections(type: SearchDataTypes, status: SearchStatus, data: OnyxTypes.SearchResults['data'], metadata: OnyxTypes.SearchResults['search']) {
	if (type === CONST.SEARCH.DATA_TYPES.CHAT) {
	return getReportActionsSections(data);
	}
	if (status === CONST.SEARCH.STATUS.EXPENSE.ALL) {
	return getTransactionsSections(data, metadata);
	}
	return getReportSections(data, metadata);
	}

Conversation

cretadn22 commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 27, 2024

Uh oh!

jjcoffee commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee commented Sep 27, 2024

Uh oh!

jjcoffee commented Sep 27, 2024

Uh oh!

luacmartins commented Sep 27, 2024

Uh oh!

JmillsExpensify commented Sep 27, 2024

Uh oh!

jjcoffee commented Sep 30, 2024

Uh oh!

cretadn22 commented Oct 1, 2024

Uh oh!

jjcoffee commented Oct 3, 2024

Uh oh!

jjcoffee commented Oct 3, 2024

Uh oh!

cretadn22 commented Oct 3, 2024

Uh oh!

cretadn22 commented Oct 3, 2024

Uh oh!

cretadn22 commented Oct 3, 2024

Uh oh!

jjcoffee commented Oct 3, 2024

Uh oh!

luacmartins commented Oct 3, 2024

Uh oh!

jjcoffee commented Oct 3, 2024

Uh oh!

luacmartins commented Oct 3, 2024

Uh oh!

This comment was marked as outdated.

cretadn22 commented Oct 3, 2024

Uh oh!

cretadn22 commented Oct 3, 2024

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 4, 2024

Uh oh!

github-actions Bot commented Oct 4, 2024

Uh oh!

github-actions Bot commented Oct 7, 2024

Uh oh!

ishpaul777 Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luacmartins Oct 25, 2024

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Oct 25, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

cretadn22 commented Sep 27, 2024 •

edited

Loading

jjcoffee commented Sep 27, 2024 •

edited

Loading

ishpaul777 Oct 16, 2024 •

edited

Loading