Skip to content

[CP Staging] fix: Distance rates - Change Rate to default leads to app crash. #49475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosmiceli merged 4 commits into from
Sep 19, 2024
Merged

[CP Staging] fix: Distance rates - Change Rate to default leads to app crash. #49475

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d96de1f
fix: Distance rates - Change Rate to default leads to app crash.
Krishna2323 Sep 19, 2024
533bba7
minor update.
Krishna2323 Sep 19, 2024
67e28f5
minor fix.
Krishna2323 Sep 19, 2024
ce02d0e
remove extra space.
Krishna2323 Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/libs/actions/IOU.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3170,13 +3170,13 @@ function updateMoneyRequestDistanceRate(
policy: OnyxEntry<OnyxTypes.Policy>,
policyTagList: OnyxEntry<OnyxTypes.PolicyTagLists>,
policyCategories: OnyxEntry<OnyxTypes.PolicyCategories>,
taxAmount?: number,
taxCode?: string,
updatedTaxAmount?: number,
updatedTaxCode?: string,
) {
const transactionChanges: TransactionChanges = {
customUnitRateID: rateID,
...(taxAmount ? {taxAmount} : {}),
...(taxCode ? {taxCode} : {}),
...(typeof updatedTaxAmount === 'number' ? {taxAmount: updatedTaxAmount} : {}),
...(updatedTaxCode ? {taxCode: updatedTaxCode} : {}),
};
const allReports = ReportConnection.getAllReports();
const transactionThreadReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${transactionThreadReportID}`] ?? null;
Expand All @@ -3188,7 +3188,9 @@ function updateMoneyRequestDistanceRate(
data = getUpdateMoneyRequestParams(transactionID, transactionThreadReportID, transactionChanges, policy, policyTagList, policyCategories, true);
}
const {params, onyxData} = data;
API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_DISTANCE_RATE, params, onyxData);
// `taxAmount` & `taxCode` only needs to be updated in the optimistic data, so we need to remove them from the params
const {taxAmount, taxCode, ...paramsWithoutTaxUpdated} = params;
API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_DISTANCE_RATE, paramsWithoutTaxUpdated, onyxData);
}

/** Edits an existing distance expense */
Expand Down