[Internal QA]: Refactor ChooseTransferAccountPage to use Selection List by allgandalf · Pull Request #49339 · Expensify/App

allgandalf · 2024-09-17T13:35:03Z

Details

Fixed Issues

$ #48974
PROPOSAL: https://expensify.slack.com/archives/C036QM0SLJK/p1726572419734889?thread_ts=1726504612.935849&cid=C036QM0SLJK

Tests

Precondition:

Comment this line of code to shouldShow={false}.
Have 2 bank accounts set up on wallet page

Go to settings/wallet/choose-transfer-account

Verify that we have everything works fine and we now have the SelectionList instead of the Radio button

Verify that no errors appear in the JS console

Offline tests

QA Steps

N/A This is Internal QA

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-18.at.12.34.21.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-09-18.at.12.39.11.AM.mov

iOS: Native

Screen.Recording.2024-09-18.at.12.25.35.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-09-18.at.12.26.09.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-17.at.11.50.14.PM.mov

MacOS: Desktop

Screen.Recording.2024-09-18.at.12.31.34.AM.mov

melvin-bot · 2024-09-17T13:35:09Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2024-09-17T19:11:14Z

Running a build so we can test this one internally

github-actions · 2024-09-17T19:45:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49339/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/49339/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49339/NewExpensify.dmg	https://49339.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny

Changes look good to me, @DylanDylann will you be able to review and test this out too?

I am trying to find someone internal to try the build

DylanDylann · 2024-09-18T08:34:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-18.at.15.45.40.mov

Android: mWeb Chrome

Screen.Recording.2024-09-18.at.15.44.21.mov

iOS: Native

Screen.Recording.2024-09-18.at.15.46.11.mov

iOS: mWeb Safari

Screen.Recording.2024-09-18.at.15.42.14.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-18.at.15.35.10.mov

MacOS: Desktop

Screen.Recording.2024-09-18.at.15.43.39.mov

DylanDylann · 2024-09-18T08:46:54Z

@allgandalf Warning on IOS and Android

Screen.Recording.2024-09-18.at.15.46.11.mov

allgandalf · 2024-09-18T08:54:10Z

@DylanDylann, we can ignore that warning, we get the same in settlement account for expensify cards,

Screen.Recording.2024-09-18.at.2.23.50.PM.mov

DylanDylann · 2024-09-18T08:56:08Z

-                    shouldShowAddPaymentMethodButton={false}
-                    shouldShowAddBankAccount={false}
-                    shouldShowRightIcon={false}
+            <ScrollView>


Why do we need to add ScrollView wrapper?

Otherwise the add bank account button would be at the bottom of the screen, do you have any other idea ? I tried a few but only with scrollview I was able to put the button after the list ends

DylanDylann · 2024-09-18T08:58:27Z

@DylanDylann, we can ignore that warning, we get the same in settlement account for expensify cards

Hmm, @mountiny Did we accept this warning or should we fix this warning?

allgandalf · 2024-09-18T09:02:15Z

Hmm, @mountiny Did we accept this warning or should we fix this warning?

the warning is that we cannot use some functionality like windowing, but our use case is only to select the options so imo we should be fine here, but curious to hear what @mountiny says

DylanDylann

Only have a small above problem. Waiting for @mountiny to confirm. The rest looks good

mountiny

Thanks for the quick work. Shawn also confirmed this works well

OSBotify · 2024-09-18T14:09:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-18T22:53:49Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-19T23:35:08Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.38-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

refactor wallet bank transfer page to use SelectionList

0439b29

allgandalf requested a review from a team as a code owner September 17, 2024 13:35

melvin-bot Bot requested review from DylanDylann and removed request for a team September 17, 2024 13:35

allgandalf added 8 commits September 17, 2024 19:09

fix lint

88fc164

use useOnyx

bcc3c95

fix initial focus

7e1ad70

fix useOnyx

d6a368a

hopefully fixed the compiler

a7ce9d9

try fix

a570c6d

fix compiler error

ec32225

use scrollView

b596737

mountiny assigned allgandalf Sep 17, 2024

mountiny self-requested a review September 17, 2024 19:10

mountiny added Ready To Build InternalQA This pull request required internal QA labels Sep 17, 2024

mountiny previously approved these changes Sep 17, 2024

View reviewed changes

DylanDylann reviewed Sep 18, 2024

View reviewed changes

Comment thread src/pages/settings/Wallet/ChooseTransferAccountPage.tsx Outdated

Comment thread src/pages/settings/Wallet/ChooseTransferAccountPage.tsx

DylanDylann reviewed Sep 18, 2024

View reviewed changes

Comment thread src/pages/settings/Wallet/ChooseTransferAccountPage.tsx

DylanDylann reviewed Sep 18, 2024

View reviewed changes

Comment thread src/pages/settings/Wallet/ChooseTransferAccountPage.tsx

implement suggestions

3102125

allgandalf dismissed mountiny’s stale review via 3102125 September 18, 2024 08:18

fix lint

1260999

DylanDylann reviewed Sep 18, 2024

View reviewed changes

DylanDylann approved these changes Sep 18, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny September 18, 2024 09:23

mountiny approved these changes Sep 18, 2024

View reviewed changes

mountiny merged commit b7c0055 into Expensify:main Sep 18, 2024

github-actions Bot mentioned this pull request Sep 18, 2024

Deploy Checklist: New Expensify 2024-09-18 #49427

Closed

43 tasks

allgandalf mentioned this pull request Sep 25, 2024

[HOLD for payment 2024-10-04] [$250] [Workspace Feeds] There's no checkmark next to the current settlement account being used. #48974

Closed

6 tasks

Uh oh!

Conversation

allgandalf commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 17, 2024

Uh oh!

mountiny commented Sep 17, 2024

Uh oh!

github-actions Bot commented Sep 17, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Sep 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Sep 18, 2024

Uh oh!

allgandalf commented Sep 18, 2024

Uh oh!

DylanDylann Sep 18, 2024

Choose a reason for hiding this comment

Uh oh!

allgandalf Sep 18, 2024

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Sep 18, 2024

Uh oh!

allgandalf commented Sep 18, 2024

Uh oh!

DylanDylann left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Sep 18, 2024

Uh oh!

OSBotify commented Sep 18, 2024

Uh oh!

OSBotify commented Sep 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

allgandalf commented Sep 17, 2024 •

edited

Loading

DylanDylann commented Sep 18, 2024 •

edited

Loading

DylanDylann left a comment •

edited

Loading