Skip to content

fix: prevent crash due to empty report #47997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aldo-expensify merged 2 commits into from
Sep 17, 2024
Merged

fix: prevent crash due to empty report #47997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80a8f35
fix: prevent crash due to empty report
dominictb Aug 26, 2024
f97ad25
Merge remote-tracking branch 'origin/main' into fix/46980-distance-req
dominictb Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/home/report/ReportActionItemContentCreated.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ function ReportActionItemContentCreated({contextValue, parentReportAction, trans
if (ReportUtils.isExpenseReport(report) || ReportUtils.isIOUReport(report) || ReportUtils.isInvoiceReport(report)) {
return (
<OfflineWithFeedback pendingAction={action.pendingAction}>
{transactionThreadReport && !isEmptyObject(transactionThreadReport) ? (
{!isEmptyObject(transactionThreadReport?.reportID) ? (

@mollfpr mollfpr Aug 28, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make sense to me we using isEmptyObject to check a string.

@dominictb dominictb Aug 29, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mollfpr

App/src/pages/iou/request/IOURequestStartPage.tsx

Line 60 in b9af3d1

const isFromGlobalCreate = isEmptyObject(report?.reportID);
we are using this pattern to check if a report is a valid report.

<>
<MoneyReportView
report={report}
Expand Down
6 changes: 4 additions & 2 deletions src/pages/iou/request/step/IOURequestStepDistance.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,11 @@ function IOURequestStepDistance({
*/
const navigateToWaypointEditPage = useCallback(
(index: number) => {
Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_WAYPOINT.getRoute(action, CONST.IOU.TYPE.SUBMIT, transactionID, report?.reportID, index.toString(), Navigation.getActiveRoute()));
Navigation.navigate(
ROUTES.MONEY_REQUEST_STEP_WAYPOINT.getRoute(action, CONST.IOU.TYPE.SUBMIT, transactionID, report?.reportID ?? reportID, index.toString(), Navigation.getActiveRoute()),
);
},
[action, transactionID, report?.reportID],
[action, transactionID, report?.reportID, reportID],
);

const navigateToParticipantPage = useCallback(() => {
Expand Down