Skip to content

fix: separate address line 1 and address line 2 #47709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcochavezf merged 1 commit into from
Aug 28, 2024
Merged

fix: separate address line 1 and address line 2 #47709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/pages/AddressPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ function AddressPage({title, address, updateAddress, isLoadingApp = true}: Addre
const {translate} = useLocalize();

// Check if country is valid
const {street, street2} = address ?? {};
const {street} = address ?? {};
const [street1, street2] = street ? street.split('\n') : [undefined, undefined];

@Pujan92 Pujan92 Sep 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On updating the logic here, we also need to make it work for the WorkspaceProfileAddressPage(now WorkspaceOverviewAddressPage) component. This caused an issue #68887

const [currentCountry, setCurrentCountry] = useState(address?.country);
const [state, setState] = useState(address?.state);
const [city, setCity] = useState(address?.city);
Expand Down Expand Up @@ -95,7 +96,7 @@ function AddressPage({title, address, updateAddress, isLoadingApp = true}: Addre
country={currentCountry}
onAddressChanged={handleAddressChange}
state={state}
street1={street}
street1={street1}
street2={street2}
zip={zipcode}
/>
Expand Down