-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Adjust the Guided Setup Flow based on user's Sign Up Qualifier #47619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+63
−2
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
a458840
grabbing signupqualifer param
carlosmiceli adffd52
Merge branch 'main' into cm-guided-setup-flow
carlosmiceli 108229b
adding new onyx key
carlosmiceli 1f70dec
setting new onboarding choices/purpose nvp
carlosmiceli 34c67a2
set nvp values with actions
carlosmiceli e13c625
fix prettier
carlosmiceli b4510f1
Merge branch 'main' into cm-guided-setup-flow
carlosmiceli e1eaefb
fix missing signupQualifier case
carlosmiceli d639cbe
fix lint
carlosmiceli ffc3d00
merge main, resolving conflicts
carlosmiceli c17d7c1
add setOnboardingCustomChoices
carlosmiceli 80536b4
filter onboarding choices based for individual signups
carlosmiceli 8b9d014
fix lint
carlosmiceli 706a735
improving constants and types
carlosmiceli 444208c
cleanup constants
carlosmiceli cd773f1
use constants and set custom choices
carlosmiceli 0db9204
remove back button from onboarding work
carlosmiceli 3051ffa
prettier
carlosmiceli b61e243
cleanup withOnyx
carlosmiceli 600fe90
Merge branch 'main' into cm-guided-setup-flow
carlosmiceli 4a79b6a
add route to onboarding work
carlosmiceli 24cccd9
suggestions
carlosmiceli 99a50d2
fix prettier
carlosmiceli 1eeab2b
fix prettier
carlosmiceli 9dbc6d7
Merge branch 'main' of github.com:Expensify/App into cm-guided-setup-…
carlosmiceli adb2cde
refactor code
carlosmiceli e8b7582
fix prettier again
carlosmiceli 36b4cbf
code cleanup
carlosmiceli 1da543a
fix double submit routing issue
carlosmiceli 783f518
fix prettier
carlosmiceli ca04353
eslint
carlosmiceli f0c2b2a
Update src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx
carlosmiceli 7622e11
minor refactoring per suggestions
carlosmiceli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,16 @@ | ||
| import type {ValueOf} from 'type-fest'; | ||
| import type CONST from '@src/CONST'; | ||
|
|
||
| /** Model of onboarding */ | ||
| type Onboarding = { | ||
| /** ID of the report used to display the onboarding checklist message */ | ||
| chatReportID?: string; | ||
|
|
||
| /** A Boolean that informs whether the user has completed the guided setup onboarding flow */ | ||
| hasCompletedGuidedSetupFlow: boolean; | ||
|
|
||
| /** A string that informs which qualifier the user selected during sign up */ | ||
| signupQualifier: ValueOf<typeof CONST.ONBOARDING_SIGNUP_QUALIFIERS>; | ||
| }; | ||
|
|
||
| export default Onboarding; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.