Skip to content

Use Share instead of Share Somewhere #47361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 1 commit into from
Aug 13, 2024
Merged

Use Share instead of Share Somewhere #47361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3612,7 +3612,6 @@ export default {
confirmTask: 'Confirm task',
confirmError: 'Please enter a title and select a share destination.',
descriptionOptional: 'Description (optional)',
shareSomewhere: 'Share somewhere',
pleaseEnterTaskName: 'Please enter a title',
pleaseEnterTaskDestination: 'Please select where you want to share this task.',
},
Expand Down
1 change: 0 additions & 1 deletion src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3666,7 +3666,6 @@ export default {
confirmTask: 'Confirmar tarea',
confirmError: 'Por favor, introduce un título y selecciona un destino de tarea.',
descriptionOptional: 'Descripción (opcional)',
shareSomewhere: 'Compartir en algún lugar',
pleaseEnterTaskName: 'Por favor, introduce un título',
pleaseEnterTaskDestination: 'Por favor, selecciona dónde deseas compartir esta tarea.',
},
Expand Down
4 changes: 2 additions & 2 deletions src/pages/tasks/NewTaskPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,9 @@ function NewTaskPage({task, reports, personalDetails}: NewTaskPageProps) {
titleWithTooltips={assigneeTooltipDetails}
/>
<MenuItem
label={shareDestination?.displayName ? translate('newTaskPage.shareSomewhere') : ''}
label={shareDestination?.displayName ? translate('common.share') : ''}
title={shareDestination?.displayName ?? ''}
description={shareDestination?.displayName ? shareDestination.subtitle : translate('newTaskPage.shareSomewhere')}
description={shareDestination?.displayName ? shareDestination.subtitle : translate('common.share')}
icon={shareDestination?.icons}
onPress={() => Navigation.navigate(ROUTES.NEW_TASK_SHARE_DESTINATION)}
interactive={!task?.parentReportID}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/tasks/TaskShareDestinationSelectorModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ function TaskShareDestinationSelectorModal() {
>
<>
<HeaderWithBackButton
title={translate('newTaskPage.shareSomewhere')}
title={translate('common.share')}
onBackButtonPress={() => Navigation.goBack(ROUTES.NEW_TASK)}
/>
<View style={[styles.flex1, styles.w100, styles.pRelative]}>
Expand Down