Skip to content

fix: Selecting yourself as the assignee should default Share somewhere to your self-DM #47291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 2 commits into from
Aug 14, 2024
Merged

fix: Selecting yourself as the assignee should default Share somewhere to your self-DM #47291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3633559
fix: Selecting yourself as the assignee should default Share somewher…
nkdengineer Aug 13, 2024
1530104
clean code
nkdengineer Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/libs/actions/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,14 @@ function setAssigneeValue(
skipShareDestination = false,
): OnyxEntry<OnyxTypes.Report> | undefined {
let report: OnyxEntry<OnyxTypes.Report> | undefined = chatReport;
if (!isCurrentUser) {
if (isCurrentUser) {
const selfDMReportID = ReportUtils.findSelfDMReportID();
// If there is no share destination set, automatically set it to the assignee chat report
// This allows for a much quicker process when creating a new task and is likely the desired share destination most times
if (!shareToReportID && !skipShareDestination) {
setShareDestinationValue(selfDMReportID ?? '-1');
}
} else {
// Check for the chatReport by participants IDs
if (!report) {
report = ReportUtils.getChatByParticipants([assigneeAccountID, currentUserAccountID]);
Expand Down