Update Xero-Troubleshooting.md#47285
Conversation
Adding contents to Xero-Troubleshooting Help Site page, as discussed in this GH - Expensify/Expensify#413228
|
@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://9f25469a.helpdot.pages.dev ⚡️ |
|
@yuwenmemon could you please review this? 🙏 |
|
Yuwen has just returned from ooo so I'm reassigning this |
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@VictoriaExpensify I'm confused... I just reviewed this 😄 |
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
|
I'm so sorry @yuwenmemon ! I have definitely created confusion here. Please ignore my comment about reassigning 😅 |
yuwenmemon
left a comment
There was a problem hiding this comment.
There are still some more edits to apply from my review.
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.21-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀
|
Adding contents to Xero-Troubleshooting Help Site page, as discussed in this GH - https://github.com/Expensify/Expensify/issues/413228
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop