feat: show last message while loading others by kirillzyusko · Pull Request #47243 · Expensify/App

kirillzyusko · 2024-08-12T15:47:33Z

Details

Show last message while we load others.

Fixed Issues

$ #43656
PROPOSAL: #43656 (comment)

Tests

Alice texts message A to Bob in their DM
Bob replies in a thread to the message A, which creates a new chat in their LHN
Alice and Bob then continue to chat in their DM and end the conversation with the message B
Bob signs out and then signs in again
Bob now sees the DM and the thread of the message A in the LHN
The DM has the preview of the message B in the LHN
Bob opens the DM
Bob should see the message B as the last message on the report page and a loading skeleton above it, indicating that the report actions are being fetched

Offline tests

Do not repeat steps with message sending, but when Bob opens a report, he should see a prefetched last message, i. e.:

Bob now sees the DM and the thread of the message A in the LHN
The DM has the preview of the message B in the LHN
Bob opens the DM
Bob should see the message B as the last message on the report page and a loading skeleton above it, indicating that the report actions are being fetched

QA Steps

Alice texts message A to Bob in their DM
Bob replies in a thread to the message A, which creates a new chat in their LHN
Alice and Bob then continue to chat in their DM and end the conversation with the message B
Bob signs out and then signs in again
Bob now sees the DM and the thread of the message A in the LHN
The DM has the preview of the message B in the LHN
Bob opens the DM
Bob should see the message B as the last message on the report page and a loading skeleton above it, indicating that the report actions are being fetched

PR Author Checklist

Screenshots/Videos

Android: Native

telegram-cloud-document-2-5321328488194526974.mp4

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-08-12.at.16.45.02.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-08-12.at.17.33.39.mov

MacOS: Desktop

Screen.Recording.2024-08-12.at.17.37.49.mov

melvin-bot · 2024-08-12T15:47:38Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kirillzyusko · 2024-08-13T15:34:02Z

@allroundexperts would you mind to review this PR? I fixed eslint and TS 👀

allroundexperts · 2024-08-14T22:10:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-15.at.3.35.18.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-08-15.at.3.34.35.AM.mov

iOS: Native

Screen.Recording.2024-08-15.at.3.33.32.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-08-15.at.3.32.16.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-15.at.3.29.11.AM.mov

MacOS: Desktop

Screen.Recording.2024-08-15.at.3.31.05.AM.mov

allroundexperts

Works good. Awesome work!

OSBotify · 2024-08-15T08:02:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-15T18:19:39Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.0.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-19T16:00:43Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

OSBotify · 2024-08-19T16:25:07Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2025-01-17T12:58:44Z

+                                        <ReportActionsSkeletonView />
+                                        {!!firstReportAction && (
+                                            <ReportActionsListItemRenderer
+                                                reportAction={firstReportAction}


While report is loading the UI break the Export Button on action. #51763

kirillzyusko added 2 commits August 12, 2024 17:14

feat: show last message while loading others

5f60c0b

fix: web, prettier

b3a8b56

kirillzyusko requested a review from a team as a code owner August 12, 2024 15:47

melvin-bot Bot requested review from allroundexperts and removed request for a team August 12, 2024 15:47

chore: code cleanup

0828a2d

kirillzyusko marked this pull request as draft August 12, 2024 16:36

fix: eslint, ts

1580522

kirillzyusko marked this pull request as ready for review August 13, 2024 15:33

allroundexperts approved these changes Aug 14, 2024

View reviewed changes

melvin-bot Bot requested a review from cristipaval August 14, 2024 22:38

cristipaval approved these changes Aug 15, 2024

View reviewed changes

cristipaval merged commit 4eb10d6 into Expensify:main Aug 15, 2024

github-actions Bot mentioned this pull request Aug 15, 2024

Deploy Checklist: New Expensify 2024-08-15 #47512

Closed

74 tasks

This was referenced Aug 26, 2024

Delegate access: Add account switcher #47338

Merged

[HOLD FOR PAYMENT 9/26] [$250] CRITICAL: [UX Reliability] Old messages show up as most recent, and the new messages didn't load for several minutes #43656

Closed

garrettmknight mentioned this pull request Oct 15, 2024

[HOLD for payment 2024-12-03] [$250] Hybrid app - Loading skeleton when notification tapped and app is killed state #49964

Closed

6 tasks

daledah mentioned this pull request Dec 18, 2024

[$500] Only the latest message is loaded, Loading skeleton displayed and chat history is broken #53075

Closed

8 tasks

parasharrajat reviewed Jan 17, 2025

View reviewed changes

parasharrajat mentioned this pull request Jan 17, 2025

[HOLD for payment 2025-01-17] [$250] Android - Accounting-Export button with dropdown goes out of preview component while loading #51763

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: show last message while loading others#47243

feat: show last message while loading others#47243
cristipaval merged 4 commits into
Expensify:mainfrom
margelo:feat/show-last-message-during-loading

kirillzyusko commented Aug 12, 2024 •

edited

Loading

Uh oh!

melvin-bot Bot commented Aug 12, 2024

Uh oh!

kirillzyusko commented Aug 13, 2024

Uh oh!

allroundexperts commented Aug 14, 2024 •

edited

Loading

Uh oh!

allroundexperts left a comment

Uh oh!

OSBotify commented Aug 15, 2024

Uh oh!

OSBotify commented Aug 15, 2024

Uh oh!

OSBotify commented Aug 19, 2024

Uh oh!

OSBotify commented Aug 19, 2024

Uh oh!

parasharrajat Jan 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

kirillzyusko commented Aug 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 12, 2024

Uh oh!

kirillzyusko commented Aug 13, 2024

Uh oh!

allroundexperts commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 15, 2024

Uh oh!

OSBotify commented Aug 15, 2024

Uh oh!

OSBotify commented Aug 19, 2024

Uh oh!

OSBotify commented Aug 19, 2024

Uh oh!

parasharrajat Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kirillzyusko commented Aug 12, 2024 •

edited

Loading

allroundexperts commented Aug 14, 2024 •

edited

Loading