[InternalQA] Fix crash when disconnecting from Netsuite by ShridharGoel · Pull Request #47232 · Expensify/App

ShridharGoel · 2024-08-12T13:33:18Z

Details

Fix crash when disconnecting from Netsuite.

Fixed Issues

$ #46508
PROPOSAL: #46508 (comment)

Tests

Create a new workspace
Go to more features > Enable Accounting
Go to Accounting > Connect to NetSuite
Upgrade the workspace to Control > Navigate back to Accounting > Finish the connection to NetSuite
Go to Accounting > Click on the 3 dot menu next to NetSuite
Click on "Disconnect" > Confirm the disconnection > Check that the integration is removed from the workspace
Navigate back from workspace page and go to FAB
8 Click on FAB > Submit Expense > Manual > Enter an amount
Select the control workspace you disconnected NetSuite from.
Verify the app doesn't crash and the expense is submitted.

QA Steps

Create a new workspace
Go to more features > Enable Accounting
Go to Accounting > Connect to NetSuite
Upgrade the workspace to Control > Navigate back to Accounting > Finish the connection to NetSuite
Go to Accounting > Click on the 3 dot menu next to NetSuite
Click on "Disconnect" > Confirm the disconnection > Check that the integration is removed from the workspace
Navigate back from workspace page and go to FAB
8 Click on FAB > Submit Expense > Manual > Enter an amount
Select the control workspace you disconnected NetSuite from.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-08-12T13:33:23Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak

Waiting for information on how to get access to credentials for integrations (in this case Netsuite).
Meanwhile, @ShridharGoel, could you please take care of the lint error?

ShridharGoel · 2024-10-07T07:18:14Z

Hi, where you able to get the credentials?

ShridharGoel · 2024-10-21T14:57:18Z

Do we have any updates on this?

eVoloshchak · 2024-10-27T20:38:16Z

Finally got my hands on NetSuite credentials and managed to reproduce this scenario, apologies for the delay @ShridharGoel
Could you resolve the conflicts please?

ShridharGoel · 2024-10-29T13:39:01Z

Updated.

eVoloshchak · 2024-10-30T15:22:55Z

@ShridharGoel, could you also populate the Screenshots/Videos section please?

ShridharGoel · 2024-10-30T18:49:41Z

Actually I don't have NetSuite credentials.

eVoloshchak · 2024-10-30T21:40:55Z

@ShridharGoel, the issue is still reproducible with the fix.

I did some more digging since you don't have the test credentials:

The if (!policyTagList) { return false; } condition isn't necessary, you can safely delete it
const policyTagValueList = policyTagList.map(({tags}) => Object.values(tags)).flat(); should be replaced with

    const policyTagValueList = policyTagList
        .filter((tag) => tag && tag.tags)
        .map(({tags}) => Object.values(tags))
        .flat();

This was correctly proposed by you, we should use this condition
3. We also need to make a little change to MoneyRequestConfirmationList (same principle, there is no tagList and we don't check for it correctly). This useEffect should be changed to

    useEffect(() => {
        let updatedTagsString = TransactionUtils.getTag(transaction);
        policyTagLists.forEach((tagList, index) => {
            const isTagListRequired = tagList.required ?? false;
            if (!isTagListRequired) {
                return;
            }
            const enabledTags = Object.values(tagList.tags).filter((tag) => tag.enabled);
            if (enabledTags.length !== 1 || TransactionUtils.getTag(transaction, index)) {
                return;
            }
            updatedTagsString = IOUUtils.insertTagIntoTransactionTagsString(updatedTagsString, enabledTags.at(0)?.name ?? '', index);
        });
        if (updatedTagsString !== TransactionUtils.getTag(transaction) && updatedTagsString) {
            IOU.setMoneyRequestTag(transactionID, updatedTagsString);
        }
        // Keep 'transaction' out to ensure that we autoselect the option only once
        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
    }, [policyTagLists, policyTags]);

eVoloshchak · 2024-11-04T20:03:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-04.at.21.40.34.mov

Android: mWeb Chrome

Screen.Recording.2024-11-04.at.21.50.17.mov

iOS: Native

Screen.Recording.2024-11-04.at.21.32.40.mov

iOS: mWeb Safari

Screen.Recording.2024-11-04.at.21.35.23.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-04.at.21.18.52.mov

MacOS: Desktop

Screen.Recording.2024-11-04.at.21.53.48.mov

eVoloshchak · 2024-11-04T20:05:39Z

@ShridharGoel, please add the following step to test steps:

Verify the app doesn't crash and the expense is submitted

ShridharGoel · 2024-11-04T20:07:17Z

Added.

eVoloshchak

LGTM!

marcaaron · 2024-11-04T23:39:19Z

Can we fix the eslint warnings?

eVoloshchak · 2024-11-05T18:04:30Z

The error doesn't seem to be related to the changes in this PR, @ShridharGoel, could you pull the latest main please?

… into patch-19

eVoloshchak

@marcaaron, eslint error is gone, this is ready for your review

OSBotify · 2024-11-08T18:28:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

kavimuru · 2024-11-11T18:29:06Z

@ShridharGoel Is this internal QA and can we check it off the list?

github-actions · 2024-11-11T18:38:59Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

ShridharGoel · 2024-11-11T18:40:49Z

@kavimuru You can go ahead with the testing if you have Netsuite access.

github-actions · 2024-11-13T00:42:28Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.60-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

Fix crash when disconnecting from Netsuite

2f11253

ShridharGoel requested a review from a team as a code owner August 12, 2024 13:33

melvin-bot Bot requested a review from eVoloshchak August 12, 2024 13:33

melvin-bot Bot removed the request for review from a team August 12, 2024 13:33

ShridharGoel mentioned this pull request Aug 12, 2024

[HOLD for payment 2024-11-20] [$250] Netsuite - App crashes when submitting an expense after disconnecting from NetSuite #46508

Closed

6 tasks

eVoloshchak reviewed Aug 14, 2024

View reviewed changes

Update

19b7eb2

ShridharGoel force-pushed the patch-19 branch from 71d8806 to 19b7eb2 Compare November 1, 2024 02:39

ShridharGoel added 2 commits November 1, 2024 09:05

Merge

2951d1a

Lint fix

bb44c95

ShridharGoel requested a review from eVoloshchak November 4, 2024 20:03

eVoloshchak approved these changes Nov 4, 2024

View reviewed changes

melvin-bot Bot requested a review from marcaaron November 4, 2024 20:55

ShridharGoel added 2 commits November 8, 2024 21:01

Merge branch 'main' of https://github.com/Expensify/App into patch-19

c4de7f6

Merge branch 'patch-19' of https://github.com/ShridharGoel/ExpensifyApp…

02d6c4f

… into patch-19

eVoloshchak reviewed Nov 8, 2024

View reviewed changes

marcaaron assigned ShridharGoel Nov 8, 2024

marcaaron approved these changes Nov 8, 2024

View reviewed changes

marcaaron merged commit e4cdb42 into Expensify:main Nov 8, 2024

github-actions Bot mentioned this pull request Nov 11, 2024

[HOLD for payment 2024-11-21] Deploy Checklist: New Expensify 2024-11-11 #52320

Closed

95 tasks

Uh oh!

Conversation

ShridharGoel commented Aug 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 12, 2024

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Oct 7, 2024

Uh oh!

ShridharGoel commented Oct 21, 2024

Uh oh!

eVoloshchak commented Oct 27, 2024

Uh oh!

ShridharGoel commented Oct 29, 2024

Uh oh!

eVoloshchak commented Oct 30, 2024

Uh oh!

ShridharGoel commented Oct 30, 2024 via email

Uh oh!

eVoloshchak commented Oct 30, 2024

Uh oh!

eVoloshchak commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented Nov 4, 2024

Uh oh!

ShridharGoel commented Nov 4, 2024

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

marcaaron commented Nov 4, 2024

Uh oh!

eVoloshchak commented Nov 5, 2024

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 8, 2024

Uh oh!

kavimuru commented Nov 11, 2024

Uh oh!

github-actions Bot commented Nov 11, 2024

Uh oh!

ShridharGoel commented Nov 11, 2024

Uh oh!

github-actions Bot commented Nov 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ShridharGoel commented Aug 12, 2024 •

edited

Loading

eVoloshchak commented Nov 4, 2024 •

edited

Loading