Skip to content

[CP Staging] Revert "fix: add receipt name when track expense"#46751

Merged
roryabraham merged 1 commit into
mainfrom
revert-45752-fix/43579-no-image
Aug 2, 2024
Merged

[CP Staging] Revert "fix: add receipt name when track expense"#46751
roryabraham merged 1 commit into
mainfrom
revert-45752-fix/43579-no-image

Conversation

@cristipaval

Copy link
Copy Markdown
Contributor

Reverts #45752 to fix #46718

@cristipaval cristipaval self-assigned this Aug 2, 2024
@cristipaval cristipaval requested a review from a team as a code owner August 2, 2024 19:38
@melvin-bot melvin-bot Bot removed the request for review from a team August 2, 2024 19:38
@melvin-bot

melvin-bot Bot commented Aug 2, 2024

Copy link
Copy Markdown

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested a review from deetergp August 2, 2024 19:38
@cristipaval cristipaval changed the title Revert "fix: add receipt name when track expense" [CP Staging] Revert "fix: add receipt name when track expense" Aug 2, 2024
@roryabraham

Copy link
Copy Markdown
Contributor

skipping checklists for straight revert

@roryabraham roryabraham merged commit f77bb40 into main Aug 2, 2024
@roryabraham roryabraham deleted the revert-45752-fix/43579-no-image branch August 2, 2024 19:51
@melvin-bot melvin-bot Bot added the Emergency label Aug 2, 2024
@melvin-bot

melvin-bot Bot commented Aug 2, 2024

Copy link
Copy Markdown

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify pushed a commit that referenced this pull request Aug 2, 2024
[CP Staging] Revert "fix: add receipt name when track expense"

(cherry picked from commit f77bb40)
@OSBotify

OSBotify commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.16-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify

OSBotify commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.16-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track expense -Self DM turns to skeleton loading with RBR on LHN when submitting track expense

4 participants