fix: remove popstate listener in popover#46357
Merged
Merged
Conversation
avoid auto-dismissal issue in some browser
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
hungvu193
reviewed
Jul 29, 2024
Contributor
|
@dominictb I know that taking screenshots for different platforms takes a lot of time, but please don’t just inspect the website and pretend that’s the screenshots/videos for iOS and Android. 😂 |
Contributor
Author
|
On Android/iOS, you can add |
Contributor
|
I'm not sure what you mean 🤔 I'm saying you should record video/screenshots correctly for each platform |
Contributor
Author
|
@hungvu193 what I mean is the videos are recorded correctly. And in case you wonder how I could manipulate the native platform to record the evidence then this is how I did it. |
Contributor
|
Sorry for this confusion but if you record screenshots/videos for a native platform, you should run it on their simulator/emulator, I see you're using web inspector instead. |
Contributor
Author
|
@hungvu193 both Android/iOS videos are on simulators. I'm not sure from where did you come into that conclusion. |
Contributor
|
You're using mSafari for both mSafari and IOS, and android native for both mChrome and Android right? 🤔 |
Contributor
Author
|
@hungvu193 alright, I re-uploaded the iOS and android video including the login step to differentiate. I'm not sure what's the implication/confusion here but it doesn't make sense to me to prolong this conversation without getting anywhere. |
Contributor
|
Thanks for understanding. |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-07-29.at.14.36.15.mov
Android: mWeb ChromeScreen.Recording.2024-07-29.at.14.14.23.moviOS: Native// running issue iOS: mWeb SafarimSafari.movMacOS: Chrome / SafariWebchrome.movMacOS: DesktopDesktop.mov |
hungvu193
approved these changes
Jul 29, 2024
puneetlath
approved these changes
Jul 29, 2024
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
84 tasks
Contributor
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.14-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
6 tasks
Contributor
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid auto-dismissal issue in some browser
Details
Fixed Issues
$ #44082
PROPOSAL: #44082 (comment)
Tests
Verify that: Modal with Got it button should appear and user should tap Got it to dismiss the modal
Offline tests
QA Steps
Verify that: Modal with Got it button should appear and user should tap Got it to dismiss the modal
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
compressed_android1.mov.mp4
Android: mWeb Chrome
compressed_android.mov.mp4
iOS: Native
ios.mov
iOS: mWeb Safari
compressed_ios.mp4.mp4
MacOS: Chrome / Safari
compressed_web.mov.mp4
MacOS: Desktop
compressed_web.mov.mp4