Navigate to singleExpenseReport by luacmartins · Pull Request #46324 · Expensify/App

luacmartins · 2024-07-26T19:48:09Z

Details

If the selected transaction is on a single expense report, we should navigate the user to the expense report, instead of the transaction thread

Fixed Issues

$ #45408
$ #46192
$ #46772

Tests

Submit an expense to userA
Submit 2 expenses to userB
Open the Search page
Verify that when you press on the expense submitted to userA, you're navigated to the one expense report view
Verify that when you press on either expense submitted to userB, you're navigated to the transaction thread
Note: you can verify that by comparing the reportIDs in the onyxData response from Search OR the report header subtitle

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2024-07-26.at.1.48.30.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-07-30T19:05:35Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-d · 2024-08-06T10:55:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-13.at.12.51.59.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-08-13.at.12.50.22.AM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-13.at.00.50.10.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-13.at.00.48.35.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-08-12.at.10.39.59.PM.mov

MacOS: Desktop

Screen.Recording.2024-08-13.at.12.45.32.AM.mov

rayane-d · 2024-08-06T15:45:16Z

@luacmartins - Backend is returning isFromSingleExpenseReport as false for me for a transaction from a one expense report:

Screen.Recording.2024-08-06.at.4.41.11.PM.mov

Here is my onyx state: onyx-state.txt
onyx-state.json

API response

{
    "accountID": 18064690,
    "authToken": "",
    "email": "rayanetesting1+456688@gmail.com",
    "onyxData": [
        {
            "key": "snapshot_422547233",
            "onyxMethod": "merge",
            "value": {
                "data": {
                    "personalDetailsList": {
                        "17822766": {
                            "accountID": 17822766,
                            "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_7.png",
                            "displayName": "Test",
                            "firstName": "Test",
                            "lastName": "",
                            "login": "rayanetesting1+1@gmail.com"
                        },
                        "17822775": {
                            "accountID": 17822775,
                            "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_16.png",
                            "displayName": "Test",
                            "firstName": "Test",
                            "lastName": "",
                            "login": "rayanetesting1+2@gmail.com"
                        },
                        "18064690": {
                            "accountID": 18064690,
                            "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_11.png",
                            "displayName": "Test",
                            "firstName": "Test",
                            "lastName": "",
                            "login": "rayanetesting1+456688@gmail.com"
                        }
                    },
                    "report_4203351885235509": {
                        "accountID": 18064690,
                        "action": "view",
                        "created": "2024-08-06 13:15:30",
                        "currency": "DZD",
                        "managerID": 17822766,
                        "policyID": "C4E664368DE59EEE",
                        "reportID": "4203351885235509",
                        "reportName": "IOU",
                        "total": 300,
                        "type": "iou"
                    },
                    "report_7085201317468860": {
                        "accountID": 18064690,
                        "action": "view",
                        "created": "2024-08-06 13:15:18",
                        "currency": "DZD",
                        "managerID": 17822775,
                        "policyID": "C4E664368DE59EEE",
                        "reportID": "7085201317468860",
                        "reportName": "IOU",
                        "total": 100,
                        "type": "iou"
                    },
                    "transactions_3410334514555133836": {
                        "accountID": 18064690,
                        "action": "view",
                        "amount": 100,
                        "canDelete": true,
                        "canHold": true,
                        "canUnhold": false,
                        "category": "",
                        "comment": {
                            "comment": ""
                        },
                        "created": "2024-08-06",
                        "currency": "DZD",
                        "hasEReceipt": false,
                        "isFromSingleExpenseReport": false,
                        "managerID": 17822766,
                        "merchant": "(none)",
                        "modifiedAmount": 0,
                        "modifiedCreated": "",
                        "modifiedCurrency": "",
                        "modifiedMerchant": "",
                        "parentTransactionID": "",
                        "policyID": "C4E664368DE59EEE",
                        "reportID": "4203351885235509",
                        "reportType": "iou",
                        "tag": "",
                        "transactionID": "3410334514555133836",
                        "transactionThreadReportID": "6715848638806335",
                        "transactionType": "cash"
                    },
                    "transactions_4414662765998918427": {
                        "accountID": 18064690,
                        "action": "view",
                        "amount": 100,
                        "canDelete": true,
                        "canHold": true,
                        "canUnhold": false,
                        "category": "",
                        "comment": {
                            "comment": ""
                        },
                        "created": "2024-08-06",
                        "currency": "DZD",
                        "hasEReceipt": false,
                        "isFromSingleExpenseReport": false,
                        "managerID": 17822775,
                        "merchant": "(none)",
                        "modifiedAmount": 0,
                        "modifiedCreated": "",
                        "modifiedCurrency": "",
                        "modifiedMerchant": "",
                        "parentTransactionID": "",
                        "policyID": "C4E664368DE59EEE",
                        "reportID": "7085201317468860",
                        "reportType": "iou",
                        "tag": "",
                        "transactionID": "4414662765998918427",
                        "transactionThreadReportID": "1096493056793",
                        "transactionType": "cash"
                    },
                    "transactions_5598384376207739393": {
                        "accountID": 18064690,
                        "action": "view",
                        "amount": 200,
                        "canDelete": true,
                        "canHold": true,
                        "canUnhold": false,
                        "category": "",
                        "comment": {
                            "comment": ""
                        },
                        "created": "2024-08-06",
                        "currency": "DZD",
                        "hasEReceipt": false,
                        "isFromSingleExpenseReport": false,
                        "managerID": 17822766,
                        "merchant": "(none)",
                        "modifiedAmount": 0,
                        "modifiedCreated": "",
                        "modifiedCurrency": "",
                        "modifiedMerchant": "",
                        "parentTransactionID": "",
                        "policyID": "C4E664368DE59EEE",
                        "reportID": "4203351885235509",
                        "reportType": "iou",
                        "tag": "",
                        "transactionID": "5598384376207739393",
                        "transactionThreadReportID": "5314195857522704",
                        "transactionType": "cash"
                    }
                },
                "search": {
                    "columnsToShow": {
                        "shouldShowCategoryColumn": true,
                        "shouldShowTagColumn": false,
                        "shouldShowTaxColumn": false
                    },
                    "hasMoreResults": false,
                    "offset": 0,
                    "statusToShow": {
                        "expense": {
                            "all": true,
                            "approved": false,
                            "drafts": false,
                            "outstanding": true,
                            "paid": true
                        }
                    },
                    "type": "transaction"
                }
            }
        }
    ],
    "httpCode": 200,
    "jsonCode": 200,
    "authResponseMessage": "200 OK",
    "requestID": "8af0300cdc6eb6c5-AAE"
}

luacmartins · 2024-08-07T08:01:20Z

Ah nice catch! There was a bug in the backend that returned false for transactions that were initially created before their report. I put up a PR to fix that.

rayane-d · 2024-08-07T23:24:27Z

Please let me know when this is ready for another review

luacmartins · 2024-08-08T12:53:20Z

PR should be deployed in a few hours. I'll ping it here once it's ready.

luacmartins · 2024-08-09T08:49:51Z

The PR was not deployed yesterday, so the next deploy will be on Monday. I'll ping this PR once that's ready.

luacmartins · 2024-08-12T20:26:18Z

This is ready to be tested again

rayane-d

LGTM and tests well

melvin-bot · 2024-08-13T00:13:04Z

@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NikkiWines

Looks good - but iirc we were previously using oneTransactionReport to denote reports with only one expense on them. Either works, but we should be consistent with the terminology

luacmartins · 2024-08-13T14:10:29Z

hmm makes sense, we can rename that.

luacmartins · 2024-08-13T14:33:52Z

Ok, API PR renaming the param is merged. It should be deployed today. Meanwhile, I updated this PR to use the new name. @NikkiWines could you please review again? 🙇

NikkiWines

👍

luacmartins · 2024-08-13T22:14:36Z

Backend is deployed. Removing hold and merging.

OSBotify · 2024-08-15T18:18:18Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-19T15:59:22Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

OSBotify · 2024-08-19T16:23:46Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

navigate to singleExpenseReport

ed81dd9

luacmartins self-assigned this Jul 26, 2024

luacmartins changed the title ~~Navigate to singleExpenseReport~~ [HOLD Auth #11814] Navigate to singleExpenseReport Jul 26, 2024

luacmartins changed the title ~~[HOLD Auth #11814] Navigate to singleExpenseReport~~ Navigate to singleExpenseReport Jul 30, 2024

luacmartins marked this pull request as ready for review July 30, 2024 19:05

luacmartins requested a review from a team as a code owner July 30, 2024 19:05

melvin-bot Bot removed the request for review from a team July 30, 2024 19:05

melvin-bot Bot requested a review from getusha July 30, 2024 19:05

luacmartins requested review from rayane-d and removed request for getusha August 6, 2024 07:03

luacmartins mentioned this pull request Aug 6, 2024

[Hold for #46324] Search - Draft message inside the composer disappears in expense details page #46772

Closed

6 tasks

rayane-d approved these changes Aug 13, 2024

View reviewed changes

melvin-bot Bot requested a review from yuwenmemon August 13, 2024 00:13

NikkiWines previously approved these changes Aug 13, 2024

View reviewed changes

luacmartins added 2 commits August 13, 2024 08:32

Merge branch 'main' into cmartins-openSingleExpenseReport

8b3dae1

rename param

5d2a28f

luacmartins dismissed NikkiWines’s stale review via 5d2a28f August 13, 2024 14:33

luacmartins requested a review from NikkiWines August 13, 2024 14:33

NikkiWines approved these changes Aug 13, 2024

View reviewed changes

luacmartins changed the title ~~Navigate to singleExpenseReport~~ [HOLD] Navigate to singleExpenseReport Aug 13, 2024

luacmartins changed the title ~~[HOLD] Navigate to singleExpenseReport~~ Navigate to singleExpenseReport Aug 13, 2024

luacmartins merged commit 0964ee9 into main Aug 13, 2024

luacmartins deleted the cmartins-openSingleExpenseReport branch August 13, 2024 22:14

github-actions Bot mentioned this pull request Aug 15, 2024

Deploy Checklist: New Expensify 2024-08-15 #47512

Closed

74 tasks

MonilBhavsar mentioned this pull request Aug 16, 2024

Search-Expense report opens instead of transaction thread when expense with comment is deleted #47538

Closed

6 tasks

rayane-d mentioned this pull request Aug 20, 2024

[HOLD for Payment 2024-08-26] Accessing one expense reports from search opening transaction view instead of report view #45408

Closed

6 tasks

luacmartins mentioned this pull request Aug 26, 2024

[HOLD #45408] Expense - Currently opened expense report is not displayed in LHN after returning from Search #46192

Closed

6 tasks

c3024 mentioned this pull request May 4, 2025

[$250] Reports - Expense report opens when individual expense row is clicked #61321

Closed

8 tasks

jayeshmangwani mentioned this pull request Sep 24, 2025

[$250] Pay with Wallet - Messages are not shown in Expense RHP in Reports when user paid with wallet #70236

Closed

8 tasks

Uh oh!

Conversation

luacmartins commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 30, 2024

Uh oh!

rayane-d commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rayane-d commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Aug 7, 2024

Uh oh!

rayane-d commented Aug 7, 2024

Uh oh!

luacmartins commented Aug 8, 2024

Uh oh!

luacmartins commented Aug 9, 2024

Uh oh!

luacmartins commented Aug 12, 2024

Uh oh!

rayane-d left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Aug 13, 2024

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Aug 13, 2024

Uh oh!

luacmartins commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Aug 13, 2024

Uh oh!

OSBotify commented Aug 15, 2024

Uh oh!

OSBotify commented Aug 19, 2024

Uh oh!

OSBotify commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

luacmartins commented Jul 26, 2024 •

edited

Loading

rayane-d commented Aug 6, 2024 •

edited

Loading

rayane-d commented Aug 6, 2024 •

edited

Loading

luacmartins commented Aug 13, 2024 •

edited

Loading