fix: accounting is not enable when connection made from OD by NJ-2020 · Pull Request #45667 · Expensify/App

NJ-2020 · 2024-07-18T10:25:07Z

Details

Fixed Issues

$ #45080
PROPOSAL: #45080 (comment)

Tests

Create new workspace
Go to OD select the created workspace, go to the Connections tab, click Connect to Quickbooks
Go back to New Dot inside Workspace

Accounting features are enabled

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create new workspace
Go to OD select the created workspace, go to the Connections tab, click Connect to Quickbooks
Go back to New Dot

Accounting features are enabled

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2024-07-18T10:25:21Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

NJ-2020 · 2024-07-19T08:56:04Z

I have read the CLA Document and I hereby sign the CLA

NJ-2020 · 2024-07-19T08:57:52Z

Sorry I do not have any recording video for MacOS, IOS, and Android, because I have a billing issue when trying to purchase Scaleway
This is my first PR

melvin-bot · 2024-07-19T08:59:05Z

@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

techievivek · 2024-07-19T12:01:38Z

Assigned @carlosmiceli since they are the assigned internal engineer for this issue.

NJ-2020 · 2024-07-19T13:36:53Z

+    const [, setEnabledItemState] = useState(enabledItem);
+
+    useEffect(() => {
+        setEnabledItemState(enabledItem);
+    }, [enabledItem]);


This is to prevent infinite rendering for the HighlightableMenuItem file

When toggling features inside the More Features tab the enabled item value changed and the highlight property will be true and re-render the WorkspaceInitialPage and the enabled item will be empty again

But when the Accountant tab is enabled the enabled item doesn't get empty again so the highlight property returns true and it causes infinite rendering

@NJ-2020 Could you explain how the setEnabledItemState is preventing the infinite rendering?

When the Accountant tab is enabled the enabled item doesn't get empty again so inside the highlight property when we're checking if enabledItem.routeName is equal to the current item routeName it will return true and cause infinite rendering, to avoid that we can re-render the WorkspaceInitialPage by using setEnabledItemState so the enabledItem will get empty again

Regarding this issue, I don't think force re-render is the correct solution. If the issue is not caused by this PR, we should handle the issue separately and try to find the right root cause.

I think this is not caused by my PR, but just need your thoughts first.
So when the accountant tab is enabled, if we go back from the Workspace clear the cache & restart, and go back to the workspace, the accountant tab is not showing until we go to another page to re-render the WorkspaceInitialPage

This is because here

@mollfpr How do you think?
Please let me know your thought

Sorry for the delay.

I understand the issue, but it's not only happening on the accountant tab and I don't think this is the correct solution moreover just a workaround.

So, I think we should do nothing here.

@mollfpr Ok.
I've removed the code
Thank you

carlosmiceli · 2024-07-19T20:16:16Z

@mallenexpensify Hey Matt, thought I'd get your advice here to make sure it's ok to review this PR already? Considering @NJ-2020 is new and there's no videos, just thought I'd confirm with you first.

mallenexpensify · 2024-07-20T00:27:10Z

@mollfpr 👀 plz since you're the assigned C+ on the issue. Unsure why you weren't requested for review here.

I included screenshots or videos for tests on all platforms

Yes, we want vids for tests on all platforms (emulators can be used if needed)

mollfpr · 2024-07-20T06:02:00Z

Sorry, I didn't get the notification for the PR. I'll finish the review in few hours.

mollfpr

There's an issue with toggling off the accounting feature after enabling it. On staging we can still toggle it on/off.

Disconnecting the connections still disabled the toggle too.

Screen.Recording.2024-07-21.at.22.14.47.mp4

mollfpr · 2024-07-21T14:30:42Z

        return !!policy?.tax?.trackingEnabled;
    }
+    if (featureName === CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED) {
+        return policy?.[featureName] ? !!policy?.[featureName] : !!policy?.connections;


Double negation on empty array will return true.

mollfpr · 2024-07-21T14:37:59Z

+    const [, setEnabledItemState] = useState(enabledItem);
+
+    useEffect(() => {
+        setEnabledItemState(enabledItem);
+    }, [enabledItem]);


@NJ-2020 Could you explain how the setEnabledItemState is preventing the infinite rendering?

mollfpr · 2024-07-21T14:40:32Z

    const {translate} = useLocalize();
    const {canUseReportFieldsFeature, canUseWorkspaceFeeds} = usePermissions();
-    const hasAccountingConnection = !!policy?.areConnectionsEnabled && !isEmptyObject(policy?.connections);
+    const hasAccountingConnection = policy?.areConnectionsEnabled ? policy?.areConnectionsEnabled : !isEmptyObject(policy?.connections);


I think using logical OR is enough here. Is there any difference using the ternary operator here?

Oh sorry my mistake, Done

mollfpr · 2024-07-21T14:42:29Z

            titleTranslationKey: 'workspace.moreFeatures.connections.title',
            subtitleTranslationKey: 'workspace.moreFeatures.connections.subtitle',
-            isActive: !!policy?.areConnectionsEnabled,
+            isActive: policy?.areConnectionsEnabled ? policy?.areConnectionsEnabled : !isEmptyObject(policy?.connections),


We can use hasAccountingConnection here.

mollfpr · 2024-07-21T14:43:00Z

+        const isConnectionDataFetchNeeded =
+            !isOffline &&
+            props.policy &&
+            (props.policy.areConnectionsEnabled ? props.policy.areConnectionsEnabled : !isEmptyObject(props.policy.connections)) &&


Same question with the logical OR.

NJ-2020 · 2024-07-22T05:03:21Z

There's an issue with toggling off the accounting feature after enabling it. On staging we can still toggle it on/off.

Disconnecting the connections still disabled the toggle too.

@mollfpr This is because we already have connections for our Accountant tab if we do the same thing inside the staging Expensify website it will be the exact same

2024-07-22.12-01-26.mp4

mollfpr · 2024-07-22T05:24:05Z

This is because we already have connections for our Accountant tab if we do the same thing inside the staging Expensify website it will be the exact same

Even when there are no connections the toggle is still disabled. You can observed the test on staging that after disconecting the connection, the toggle is not disabled.

Screen.Recording.2024-07-22.at.12.20.16.mp4

mollfpr · 2024-07-22T07:08:43Z

@NJ-2020 I think we should update the disabled property here.

App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

Line 237 in 0673b9b

disabled: hasAccountingConnection,

We should disable the toggle if there are connections made before.

-            disabled: hasAccountingConnection,
+            disabled: !isEmptyObject(policy?.connections),

NJ-2020 · 2024-07-22T07:45:22Z

@NJ-2020 I think we should update the disabled property here.

App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

Line 237 in 0673b9b

disabled: hasAccountingConnection,

We should disable the toggle if there are connections made before.
-            disabled: hasAccountingConnection,
+            disabled: !isEmptyObject(policy?.connections),

@mollfpr Thank you
But the other setting features will still be disabled

I just pushed a new commit and it resolved the issue
Please kindly take a look
Thanks

NJ-2020 · 2024-07-24T11:43:03Z

requested a review from molfpr

Sorry above request, accidentally mistaken

mollfpr · 2024-07-24T12:17:49Z

@NJ-2020 No worries! I think the changes look good, I just need to finish the recordings.

mollfpr · 2024-07-26T14:50:30Z

I included screenshots or videos for tests on all platforms

@NJ-2020 Could you complete the recordings on all platforms? It's part of the checklist. Thanks!

NJ-2020 · 2024-07-26T15:14:32Z

@mollfpr Sorry, I am using Windows right now, and when trying to purchase Scaleway or other platforms I have a billing issue. It's my first PR.

Is that okay?

mollfpr · 2024-07-26T15:35:49Z

@NJ-2020 I'm personally okay. Maybe you can record the platform you can on Windows.

mollfpr · 2024-07-26T15:36:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

45667.Android.mp4

Android: mWeb Chrome

45667.mWeb-Chrome.mp4

iOS: Native

45667.iOS.mov

iOS: mWeb Safari

45667.mWeb-Safari.mov

MacOS: Chrome / Safari

45667.Web.mp4

MacOS: Desktop

45667.Desktop.mp4

mollfpr · 2024-07-26T15:39:08Z

@carlosmiceli I have completed the reviewer checklist and you can remove the checklist #45667 (comment) so melvin can check the updated checklist.

carlosmiceli · 2024-07-26T16:39:33Z

Looks like some typescript test is not passing.

NJ-2020 · 2024-07-26T16:41:59Z

Looks like some typescript test is not passing.

@carlosmiceli But the typescript failing is not from my changes

NJ-2020 · 2024-07-30T14:21:01Z

@carlosmiceli Any update?

carlosmiceli · 2024-07-30T17:36:31Z

@NJ-2020 can you try merging main again? I think we had a few issues with performance regressions that I think are fixed now.

NJ-2020 · 2024-07-31T03:52:50Z

@NJ-2020 can you try merging main again? I think we had a few issues with performance regressions that I think are fixed now.

@carlosmiceli Done

OSBotify · 2024-07-31T05:29:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-31T19:30:54Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.0.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-02T02:18:52Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.15-9 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: accounting not enable connection made from od

e0fc8d8

NJ-2020 and others added 2 commits July 19, 2024 09:22

Merge branch 'Expensify:main' into fix/45080

1f3b101

fix infinite rendering

c470b80

NJ-2020 marked this pull request as ready for review July 19, 2024 08:58

NJ-2020 requested a review from a team as a code owner July 19, 2024 08:58

melvin-bot Bot removed the request for review from a team July 19, 2024 08:59

melvin-bot Bot requested a review from techievivek July 19, 2024 08:59

fix animate

237a3ea

techievivek requested review from carlosmiceli and removed request for techievivek July 19, 2024 12:01

NJ-2020 and others added 2 commits July 19, 2024 19:08

Merge branch 'Expensify:main' into fix/45080

85f36cc

improve code

8d60718

NJ-2020 commented Jul 19, 2024

View reviewed changes

Merge branch 'Expensify:main' into fix/45080

65b1c3a

mollfpr reviewed Jul 21, 2024

View reviewed changes

fix requested changes

c8fdc55

Merge branch 'Expensify:main' into fix/45080

dd58339

fix accounting disabled when there is no connection

b11c5a6

NJ-2020 added 3 commits July 22, 2024 14:50

fix ternary operator

723024b

fix hasAccountingConnection

d12061b

remove setEnabledItemState and useEffect

b1b27f1

NJ-2020 requested a review from mollfpr July 24, 2024 11:41

NJ-2020 added 2 commits July 26, 2024 17:02

Merge branch 'Expensify:main' into fix/45080

7f2f3b3

Merge branch 'Expensify:main' into fix/45080

3ae94d8

Merge branch 'Expensify:main' into fix/45080

03be9ed

Merge branch 'Expensify:main' into fix/45080

8c687c2

carlosmiceli approved these changes Jul 31, 2024

View reviewed changes

carlosmiceli merged commit 8e79c59 into Expensify:main Jul 31, 2024

github-actions Bot mentioned this pull request Jul 31, 2024

Deploy Checklist: New Expensify 2024-07-31 #46607

Closed

arosiclair mentioned this pull request Aug 1, 2024

[$250] Accounting - Not here page opens after disconnecting QBO when it is connected via Old Dot #46618

Closed

6 tasks

Uh oh!

Conversation

NJ-2020 commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NJ-2020 commented Jul 19, 2024

Uh oh!

NJ-2020 commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Jul 19, 2024

Uh oh!

techievivek commented Jul 19, 2024

Uh oh!

NJ-2020 Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carlosmiceli commented Jul 19, 2024

Uh oh!

mallenexpensify commented Jul 20, 2024

Uh oh!

mollfpr commented Jul 20, 2024

Uh oh!

mollfpr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NJ-2020 commented Jul 22, 2024

Uh oh!

mollfpr commented Jul 22, 2024

Uh oh!

mollfpr commented Jul 22, 2024

Uh oh!

NJ-2020 commented Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NJ-2020 commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

NJ-2020 commented Jul 18, 2024 •

edited

Loading

github-actions Bot commented Jul 18, 2024 •

edited

Loading

NJ-2020 commented Jul 19, 2024 •

edited

Loading

NJ-2020 Jul 19, 2024 •

edited

Loading

mollfpr left a comment •

edited

Loading

NJ-2020 commented Jul 22, 2024 •

edited

Loading

NJ-2020 commented Jul 24, 2024 •

edited

Loading

NJ-2020 commented Jul 26, 2024 •

edited

Loading