Fix navigating between CentralPane screens by WojtekBoman · Pull Request #44444 · Expensify/App

WojtekBoman · 2024-06-26T11:07:42Z

Details

This PR fixes issues with navigating to CentralPane screens, also includes one performance improvement in NavigationUtils.ts, now CENTRAL_PANE_SCREEN_NAMES is stored as a Set instead of an array.

App behaviour after fixing:

iOS - Hold - Back button on transaction thread returns to Hold - Reason page after holding it

Screen.Recording.2024-06-26.at.13.04.56.mov

Search - Workspace switcher on Search is not synchronized with workspace switcher in Inbox

Screen.Recording.2024-06-26.at.13.28.14.mov

Fixed Issues

$ #44423
$ #44433
PROPOSAL:

Tests

Verify that no errors appear in the JS console

iOS - Hold - Back button on transaction thread returns to Hold - Reason page after holding it

Launch New Expensify app.
Go to workspace chat.
Submit an expense.
Go to transaction thread.
Tap 3-dot menu > Hold.
Enter reason > Save.
Tap on the back button.
Verify if the Hold - Reason page is not displayed

Search - Workspace switcher on Search is not synchronized with workspace switcher in Inbox

Launch New Expensify app.
Open workspace switcher.
Select any workspace other than Expensify.
Go to Search.
Open the workspace switcher on Search.
Verify if the workspace switcher on Search is synchronized with that on Inbox.

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

adamgrzybowski

LGTM! 🎸

melvin-bot · 2024-06-26T14:18:19Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2024-06-26T19:44:47Z

Gonna reassign C+ since this is urgent

allgandalf · 2024-06-26T19:45:02Z

Reviewing now 🔁

allgandalf · 2024-06-26T19:47:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-27.at.1.39.36.AM.mov

Screen.Recording.2024-06-27.at.1.36.23.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-06-27.at.1.43.57.AM.mov

Screen.Recording.2024-06-27.at.1.45.45.AM.mov

iOS: Native

Screen.Recording.2024-06-27.at.1.30.28.AM.mov

Screen.Recording.2024-06-27.at.1.32.22.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-06-27.at.1.46.44.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-27.at.1.27.15.AM.mov

MacOS: Desktop

Screen.Recording.2024-06-27.at.1.28.41.AM.mov

allgandalf · 2024-06-26T19:51:56Z

    // If action type is different than NAVIGATE we can't change it to the PUSH safely
    if (action?.type === CONST.NAVIGATION.ACTION_TYPE.NAVIGATE) {
-        const actionParams: ActionPayloadParams = action.payload.params;
+        const actionPayloadParams: ActionPayloadParams = action.payload.params;


Not a blocker but i think we should instead use action?.payload?.params to avoid any kind of crash(IDK if ever the params would be undefined but better to have), as this is related to deploy blocker i won't focus on this much though, we can come up with a follow up PR for this @luacmartins @WojtekBoman

allgandalf

Tests well on all platforms, other then the changes i suggested above (NAB), this LGTM!

allgandalf · 2024-06-26T20:22:21Z

Pr reviewer check list still checks for this [comment](https://github.com//pull/44444#issuecomment-2191910248) as @hoangzinh posted their checklist above, i think we can merge this anyway

luacmartins · 2024-06-26T20:23:11Z

I deleted their checklist

allgandalf

Approving again for the checklist check to run again, thanks @luacmartins

OSBotify · 2024-06-26T20:33:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…out-central-pane Fix navigating between CentralPane screens (cherry picked from commit f757005)

OSBotify · 2024-06-26T21:23:06Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.2-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-03T19:41:51Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:01:50Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

WojtekBoman added 2 commits June 26, 2024 13:06

Add actionName and actionParams variables to linkTo

cd7f4b2

Refactor CENTRAL_PANE_SCREEN_NAMES to set

6e63dff

adamgrzybowski approved these changes Jun 26, 2024

View reviewed changes

WojtekBoman added 2 commits June 26, 2024 16:06

Merge branch 'main' into fix/link-to-without-central-pane

8898f18

Rename actionName and actionParams variables in linkTo

89b6676

WojtekBoman marked this pull request as ready for review June 26, 2024 14:18

WojtekBoman requested a review from a team as a code owner June 26, 2024 14:18

melvin-bot Bot requested review from hoangzinh and removed request for a team June 26, 2024 14:18

WojtekBoman changed the title ~~Fix/link to without central pane~~ Fix navigating between CentralPane screens Jun 26, 2024

luacmartins requested review from allgandalf and luacmartins June 26, 2024 15:46

luacmartins removed the request for review from hoangzinh June 26, 2024 19:44

allgandalf reviewed Jun 26, 2024

View reviewed changes

allgandalf approved these changes Jun 26, 2024

View reviewed changes

melvin-bot Bot requested a review from grgia June 26, 2024 20:18

Expensify deleted a comment from hoangzinh Jun 26, 2024

allgandalf approved these changes Jun 26, 2024

View reviewed changes

luacmartins approved these changes Jun 26, 2024

View reviewed changes

luacmartins merged commit f757005 into Expensify:main Jun 26, 2024

OSBotify pushed a commit that referenced this pull request Jun 26, 2024

Merge pull request #44444 from software-mansion-labs/fix/link-to-with…

d7542be

…out-central-pane Fix navigating between CentralPane screens (cherry picked from commit f757005)

github-actions Bot mentioned this pull request Jun 26, 2024

Deploy Checklist: New Expensify 2024-06-25 #44406

Closed

92 tasks

yuwenmemon mentioned this pull request Jun 26, 2024

iOS - Search - App redirects to the report several times when tapping on header subtitle #44422

Closed

6 tasks

MonilBhavsar mentioned this pull request Jun 27, 2024

Revert "Fix navigating between CentralPane screens" #44550

Closed

luacmartins mentioned this pull request Jun 27, 2024

[HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] iOS - Hold - Back button on transaction thread returns to Hold - Reason page after holding it #44423

Closed

6 tasks

allgandalf mentioned this pull request Jun 27, 2024

[HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] [$250] [Search v1] - Workspace switcher on Search is not synchronized with workspace switcher in Inbox #44433

Closed

6 tasks

Uh oh!

Conversation

WojtekBoman commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

adamgrzybowski left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jun 26, 2024

Uh oh!

luacmartins commented Jun 26, 2024

Uh oh!

allgandalf commented Jun 26, 2024

Uh oh!

allgandalf commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf Jun 26, 2024

Choose a reason for hiding this comment

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Jun 26, 2024

Uh oh!

luacmartins commented Jun 26, 2024

Uh oh!

allgandalf left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 26, 2024

Uh oh!

OSBotify commented Jun 26, 2024

Uh oh!

OSBotify commented Jul 3, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WojtekBoman commented Jun 26, 2024 •

edited

Loading

allgandalf commented Jun 26, 2024 •

edited

Loading

allgandalf left a comment •

edited

Loading