Skip to content

[fix]: [DEV] Console Warning when opening FAB menu #43984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewGable merged 3 commits into from
Jun 20, 2024
Merged

[fix]: [DEV] Console Warning when opening FAB menu #43984

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
321294f
update to unique key for each option
allgandalf Jun 19, 2024
2241a07
Disable lint error
allgandalf Jun 20, 2024
a90c0d9
fix prettier
allgandalf Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/PopoverMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ function PopoverMenu({
{enteredSubMenuIndexes.length > 0 && renderBackButtonItem()}
{currentMenuItems.map((item, menuIndex) => (
<FocusableMenuItem
key={item.text}
// eslint-disable-next-line react/no-array-index-key
key={`${item.text}_${menuIndex}`}

@allgandalf allgandalf Jun 20, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishpaul777 , do you think we should disable the rule here? We do the same at one other place:

App/src/components/MentionSuggestions.tsx

Lines 99 to 100 in 66870b4

// eslint-disable-next-line react/no-array-index-key
key={`${text}${i}`}

If no then we can try using item.label instead, what do you think ?

@ishpaul777 ishpaul777 Jun 20, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think disabling rule should be enough 👍

icon={item.icon}
iconWidth={item.iconWidth}
iconHeight={item.iconHeight}
Expand Down