Skip to content

Fix new offline chat image on android #43895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flodnv merged 1 commit into from
Jun 24, 2024
Merged

Fix new offline chat image on android #43895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/home/report/AnimatedEmptyStateBackground.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ function AnimatedEmptyStateBackground() {
}, [isReducedMotionEnabled]);

return (
<View style={StyleUtils.getReportWelcomeBackgroundContainerStyle(isSmallScreenWidth)}>
<View style={StyleUtils.getReportWelcomeBackgroundContainerStyle()}>
<Animated.Image
source={illustrations.EmptyStateBackgroundImage}
style={[StyleUtils.getReportWelcomeBackgroundImageStyle(isSmallScreenWidth), animatedStyles]}
Expand Down
1 change: 0 additions & 1 deletion src/pages/home/report/ReportActionItemCreated.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ function ReportActionItemCreated(props: ReportActionItemCreatedProps) {
errors={props.report?.errorFields?.addWorkspaceRoom ?? props.report?.errorFields?.createChat}
errorRowStyles={[styles.ml10, styles.mr2]}
onClose={() => navigateToConciergeChatAndDeleteReport(props.report?.reportID ?? props.reportID)}
needsOffscreenAlphaCompositing
>
<View style={[styles.pRelative]}>
<AnimatedEmptyStateBackground />
Expand Down
10 changes: 1 addition & 9 deletions src/styles/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,15 +800,7 @@ function getReportWelcomeBackgroundImageStyle(isSmallScreenWidth: boolean): Imag
/**
* Gets the style for the container of the empty state background image that overlap the created report action
*/
function getReportWelcomeBackgroundContainerStyle(isSmallScreenWidth: boolean): ViewStyle {
if (isSmallScreenWidth) {
return {
position: 'absolute',
top: CONST.EMPTY_STATE_BACKGROUND.OVERLAP,
width: '100%',
};
}

function getReportWelcomeBackgroundContainerStyle(): ViewStyle {
return {
position: 'absolute',
top: CONST.EMPTY_STATE_BACKGROUND.OVERLAP,
Expand Down