Integrate MoneyRequestConfirmationListFooter by rezkiy37 · Pull Request #43749 · Expensify/App

rezkiy37 · 2024-06-14T09:52:52Z

Details

The PR creates and integrates a new component - MoneyRequestConfirmationListFooter. It takes responsibility for rendering footer content on the Money Request Confirmation page. This change decreases the parent component by 410 lines with some onyx getters, useMemo, etc. Also, I've applied React.memo().

I did some measures and recorded the mean value. So It really improves the rendering.

Send Invoice to a person - Open the page - Before 141,8ms / After 108ms / Diff 33,8ms - 31.3%
Send Invoice to a person - Update a workspace - Before 181,8ms / After 155,1ms / Diff 26,7ms - 17.21%
Submit expense - Click on "Show more" - Before 44,6ms / After 42,1ms / Diff 2,5ms 5.94%
Pay someone - Edit a description - Before 105ms / After 55,3ms / Diff 49,7ms - 111.27%

Fixed Issues

$ #43663
PROPOSAL: https://callstack-hq.slack.com/archives/C05LX9D6E07/p1718204702743269

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…actor/43663-split-money-request-confirmation-list

melvin-bot · 2024-06-17T10:26:12Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt

Code-wise this looks good to me. Will complete the checklist / test asap

…actor/43663-split-money-request-confirmation-list

s77rt · 2024-06-18T14:17:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

mountiny · 2024-06-20T22:23:28Z

@rezkiy37 can you please fix the conflicts? thanks

…ation-list' of https://github.com/rezkiy37/Expensify into refactor/43663-split-money-request-confirmation-list

rezkiy37 · 2024-06-21T11:39:02Z

@mountiny I've fixed the conflicts 🙂

mountiny

Thanks, I wish we could get rid of the large memos

OSBotify · 2024-06-24T13:13:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-25T20:09:10Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.2-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

MonilBhavsar · 2024-06-26T15:59:39Z

@rezkiy37 not completely sure, but this PR might have introduced this deploy blocker. Can anyone please take a look cc @s77rt #44437

rezkiy37 · 2024-06-26T16:15:08Z

@rezkiy37 not completely sure, but this PR might have introduced this deploy blocker. Can anyone please take a look cc @s77rt #44437

yes, sure.

OSBotify · 2024-07-03T19:38:15Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T10:56:29Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ikevin127 · 2024-12-19T03:11:53Z

+                        onToggle={(isOn) => onToggleBillable?.(isOn)}
+                        isActive={iouIsBillable}
+                        disabled={isReadOnly}
+                        titleStyle={!iouIsBillable && {color: theme.textSupporting}}


The conditional titleStyle here led to this issue:

[HOLD for payment 2024-12-25] [$250] Billable-Billable and "members must categorize all expense" on toggle off text color behavior #53460

which was fixed by removing the style completely.

rezkiy37 added 12 commits June 14, 2024 11:16

integrate MoneyRequestConfirmationListFooter

de807ff

Merge branch 'main' of https://github.com/rezkiy37/Expensify into ref…

9e02c35

…actor/43663-split-money-request-confirmation-list

Add display name to MoneyRequestConfirmationListFooter component

0bcdeee

selectedParticipants prop in MoneyRequestConfirmationList

4abda46

optimize setBillable function in IOURequestStepConfirmation

60fd288

comments for props

efa991d

Optimize MoneyRequestConfirmationList component via memo

4ab8d32

Merge branch 'main' of https://github.com/rezkiy37/Expensify into ref…

0892187

…actor/43663-split-money-request-confirmation-list

remove todo

f6a5773

use forEach instead of filter and map

b79a0f1

add comments

84a8bd6

remove useMemo

e6309d3

rezkiy37 changed the title ~~[WIP] Integrate MoneyRequestConfirmationListFooter~~ Integrate MoneyRequestConfirmationListFooter Jun 17, 2024

rezkiy37 marked this pull request as ready for review June 17, 2024 10:26

rezkiy37 requested a review from a team as a code owner June 17, 2024 10:26

melvin-bot Bot requested review from s77rt and removed request for a team June 17, 2024 10:26

s77rt reviewed Jun 18, 2024

View reviewed changes

Comment thread src/components/MoneyRequestConfirmationListFooter.tsx Outdated

Comment thread src/components/MoneyRequestConfirmationListFooter.tsx Outdated

rezkiy37 added 3 commits June 18, 2024 10:25

Merge branch 'main' of https://github.com/rezkiy37/Expensify into ref…

2f7647c

…actor/43663-split-money-request-confirmation-list

simplify shouldShowReceiptEmptyState

167be33

add memo for MoneyRequestConfirmationListFooter

d859d14

rezkiy37 requested a review from s77rt June 18, 2024 10:35

s77rt approved these changes Jun 18, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny June 18, 2024 14:18

mountiny assigned rezkiy37 Jun 20, 2024

Merge branches 'main' and 'refactor/43663-split-money-request-confirm…

0a12fbd

…ation-list' of https://github.com/rezkiy37/Expensify into refactor/43663-split-money-request-confirmation-list

mountiny approved these changes Jun 24, 2024

View reviewed changes

mountiny merged commit ccebefa into Expensify:main Jun 24, 2024

github-actions Bot mentioned this pull request Jun 25, 2024

Deploy Checklist: New Expensify 2024-06-25 #44406

Closed

92 tasks

This was referenced Jun 26, 2024

[$250] iOS - Expense - App crashes when opening Description and saving it a few times #44437

Closed

Revert "Integrate MoneyRequestConfirmationListFooter" #44482

Closed

s77rt mentioned this pull request Jul 1, 2024

[HOLD for payment 2024-07-10] [HOLD for payment 2024-06-28] [LOW] [Performance] Refactor ReportActionItem.tsx and MoneyRequestConfirmationList.tsx #43663

Closed

ikevin127 reviewed Dec 19, 2024

View reviewed changes

Uh oh!

Conversation

rezkiy37 commented Jun 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 17, 2024

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

s77rt commented Jun 18, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny commented Jun 20, 2024

Uh oh!

rezkiy37 commented Jun 21, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 24, 2024

Uh oh!

OSBotify commented Jun 25, 2024

Uh oh!

MonilBhavsar commented Jun 26, 2024

Uh oh!

rezkiy37 commented Jun 26, 2024

Uh oh!

OSBotify commented Jul 3, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

ikevin127 Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rezkiy37 commented Jun 14, 2024 •

edited

Loading