Skip to content

fix: unsub userIsTyping event on report screen unmount #43542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 4 commits into from
Jun 23, 2024
Merged

fix: unsub userIsTyping event on report screen unmount #43542

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bfc997d
fix: unsub userIsTyping event on report screen unmount
dominictb Jun 10, 2024
8ff0eff
chore: optimize the logic of sub/unsub report pusher events
dominictb Jun 11, 2024
44314da
Revert "chore: optimize the logic of sub/unsub report pusher events"
dominictb Jun 12, 2024
ae03a7f
fix: revert to simple solution
dominictb Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/pages/home/report/UserTypingEventListener.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,23 @@ function UserTypingEventListener({report, lastVisitedPath}: UserTypingEventListe
const reportID = report.reportID;
const isFocused = useIsFocused();
const route = useRoute<RouteProp<CentralPaneNavigatorParamList, typeof SCREENS.REPORT>>();

useEffect(
() => () => {
if (!didSubscribeToReportTypingEvents.current) {
return;
}

// unsubscribe from report typing events when the component unmounts
didSubscribeToReportTypingEvents.current = false;
InteractionManager.runAfterInteractions(() => {
Report.unsubscribeFromReportChannel(reportID);
});
},
// eslint-disable-next-line react-hooks/exhaustive-deps
[],
);

useEffect(() => {
// Ensures any optimistic report that is being created (ex: a thread report) gets created and initialized successfully before subscribing
if (route?.params?.reportID !== reportID) {
Expand Down