Skip to content

Use gh cli for production deploy #43516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 2 commits into from
Jun 12, 2024
Merged

Use gh cli for production deploy #43516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4649bdb
Use gh cli for production deploy
AndrewGable Jun 11, 2024
1ead9e7
Adjust assertions and mocks to make tests pass
AndrewGable Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
with:
ref: staging
token: ${{ secrets.OS_BOTIFY_TOKEN }}

- name: Setup git for OSBotify
uses: ./.github/actions/composite/setupGitForOSBotifyApp
id: setupGitForOSBotify
Expand Down Expand Up @@ -65,9 +65,6 @@ jobs:
PR_LIST: ${{ steps.getReleasePRList.outputs.PR_LIST }}

- name: 🚀 Create release to trigger production deploy 🚀
uses: softprops/action-gh-release@affa18ef97bc9db20076945705aba8c516139abd
with:
tag_name: ${{ env.PRODUCTION_VERSION }}
body: ${{ steps.getReleaseBody.outputs.RELEASE_BODY }}
run: gh release create ${{ env.PRODUCTION_VERSION }} --notes ${{ steps.getReleaseBody.outputs.RELEASE_BODY }}
env:
GITHUB_TOKEN: ${{ steps.setupGitForOSBotify.outputs.OS_BOTIFY_API_TOKEN }}
5 changes: 1 addition & 4 deletions workflow_tests/assertions/deployAssertions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,7 @@ function assertDeployProductionJobExecuted(workflowResult: Step[], didExecute =
null,
'DEPLOY_PRODUCTION',
'Creating release to trigger production deploy',
[
{key: 'tag_name', value: '1.2.3'},
{key: 'body', value: 'Release body'},
],
[],
[{key: 'GITHUB_TOKEN', value: 'os_botify_api_token'}],
),
] as const;
Expand Down
2 changes: 1 addition & 1 deletion workflow_tests/mocks/deployMocks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const DEPLOY_PRODUCTION__CREATE_RELEASE__STEP_MOCK = createMockStep(
'🚀 Create release to trigger production deploy 🚀',
'Creating release to trigger production deploy',
'DEPLOY_PRODUCTION',
['tag_name', 'body'],
[],
['GITHUB_TOKEN'],
);
const DEPLOY_PRODUCTION_STEP_MOCKS = [
Expand Down