Skip to content

Fix long pressing the comment reaction does not open the reactions modal the first time you do it #43464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 3 commits into from
Jun 12, 2024
Merged

Fix long pressing the comment reaction does not open the reactions modal the first time you do it #43464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c23b6b
always render the popover component
bernhardoj Jun 11, 2024
7e8985f
set visible if reportActionID and emojiName is set
bernhardoj Jun 11, 2024
6d719bb
only show the popover when the information is ready
bernhardoj Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/hooks/useBasePopoverReactionList/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export default function useBasePopoverReactionList({emojiName, emojiReactions, a
emojiCodes: [],
hasUserReacted: false,
users: [],
isReady: false,
};
}

Expand All @@ -34,6 +35,7 @@ export default function useBasePopoverReactionList({emojiName, emojiReactions, a
reactionCount,
hasUserReacted,
users,
isReady: true,
};
}

Expand Down
5 changes: 2 additions & 3 deletions src/pages/home/report/ReactionList/PopoverReactionList/BasePopoverReactionList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,12 @@ function BasePopoverReactionList(props: BasePopoverReactionListPropsWithLocalWit
preferredLocale,
});
// Get the reaction information
const {emojiCodes, reactionCount, hasUserReacted, users} = getReactionInformation();

const {emojiCodes, reactionCount, hasUserReacted, users, isReady} = getReactionInformation();
useImperativeHandle(ref, () => ({hideReactionList, showReactionList}));

return (
<PopoverWithMeasuredContent
isVisible={isPopoverVisible}
isVisible={isPopoverVisible && isReady}

@bernhardoj bernhardoj Jun 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that it's possible the other information isn't ready yet when the popover is visible, instead of checking each information one-by-one, I returned the isReady variable from getReactionInformation.

Screen.Recording.2024-06-11.at.19.53.03.mov

onClose={hideReactionList}
anchorPosition={popoverAnchorPosition}
animationIn="fadeIn"
Expand Down
4 changes: 0 additions & 4 deletions src/pages/home/report/ReactionList/PopoverReactionList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ function PopoverReactionList(props: unknown, ref: ForwardedRef<ReactionListRef>)

useImperativeHandle(ref, () => ({showReactionList, hideReactionList, isActiveReportAction}));

if (reactionListReportActionID === '' || reactionListEmojiName === '') {
return null;
}

return (
<BasePopoverReactionList
ref={innerReactionListRef}
Expand Down