fix: mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview. by Krishna2323 · Pull Request #43249 · Expensify/App

Krishna2323 · 2024-06-07T09:53:53Z

Details

Fixed Issues

$ #42657
PROPOSAL: #42657 (comment)

Tests

Go offline
Open a report
Tap plus icon - upload an attachment image
Verify offline message is not shown

Verify that no errors appear in the JS console

Offline tests

Go offline
Open a report
Tap plus icon - upload an attachment image
Verify offline message is not shown

QA Steps

Go offline
Open a report
Tap plus icon - upload an attachment image
Verify offline message is not shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…offline message in the preview. Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-06-07T09:53:58Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-06-07T10:10:37Z

        };
    }, [canUseTouchScreen, trackMovement, trackPointerPosition]);

+    const isLocalFile = url.startsWith('blob:') || url.startsWith('file:');


Do you think the above two cases cover every type?

For example, here's one example from IOURequestStepConfirmation.tsx, they have extra type check and / check, is the same applicable here?

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 206 in a67be2f

const isLocalFile = typeof receiptPath === 'number' || receiptPath?.startsWith('blob:') || receiptPath?.startsWith('file:') || receiptPath?.startsWith('/');

Note
I haven't reviewed the code from laptop cause i'm a little under the weather, so might take the day off, but if you address the above comments of whether those additional checks are necessary, i will try to review the PR over the weekend.

I'm not completely sure about the other checks, with the current changes it works fine on all platforms but we can consider adding those checks also, WDYT?

i think the typeof check would unnecessary here because it will always be true i checked the type ofurl it's string so then isLocalFile would always be true so no need to be redundant.

But startsWith('/') is something i'm not sure about, can you check and see if that is needed? if not then the current implementation is complete, and i will complete the checklist then, let me know :)

@Krishna2323 bump on the comments above :)

will test for / again on all platforms today

bump @Krishna2323 , lets get this merged before the week closes 💪

Can we move these checks to a shared helper function? @Krishna2323

@arosiclair, I've updated the code to add a util function for determining local files. @allgandalf, could you please take a look at the updated code? Thanks.

Krishna2323 · 2024-06-13T05:58:42Z

@allgandalf, I have already replied to your comment, looks like I started a review instead of adding a comment, sorry for that.

@allgandalf, I checked on all platforms and the localfiles only starts with file:// or blob://

Monosnap fix: mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview by Krishna2323 · Pull Requ… 2024-06-13 11-28-17

allgandalf · 2024-06-14T14:23:42Z

Ahh that is alright, will review this today 👍

allgandalf · 2024-06-14T19:27:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-15.at.1.19.00.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-06-15.at.1.22.06.PM.mov

iOS: Native

Screen.Recording.2024-06-15.at.1.07.43.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-06-15.at.1.04.49.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-15.at.1.01.51.PM.mov

MacOS: Desktop

afs.mov

allgandalf

Code LGTM, tests well on all platforms 👍

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

allgandalf · 2024-06-19T10:57:09Z

+    if (!receiptUri) {
+        return false;
+    }
+    return typeof receiptUri === 'number' || receiptUri?.startsWith('blob:') || receiptUri?.startsWith('file:') || receiptUri?.startsWith('/');


I am not sure with the type check here @Krishna2323 @arosiclair ?

What are the cases where a URI would be a number ?!

@allgandalf, we can leave that as it is. This isn't added in our PR, and it is an optional check, so it won't affect our use case.

umm, if @arosiclair approves this then i would have no issue haha..., rest code LGTM!

IIRC it's a number on some platforms (iOS/Android I think). It should be fine to keep that here.

OSBotify · 2024-06-19T13:49:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-19T21:52:22Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-19T22:17:04Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-19T22:51:03Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.86-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-21T21:21:41Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.0-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: mWeb - Chat - Uploading an image while offline briefly shows an …

27809d6

…offline message in the preview. Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner June 7, 2024 09:53

melvin-bot Bot requested review from allgandalf and removed request for a team June 7, 2024 09:53

Krishna2323 mentioned this pull request Jun 7, 2024

[HOLD for payment 2024-06-28] [$250] mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview #42657

Closed

6 tasks

allgandalf reviewed Jun 7, 2024

View reviewed changes

allgandalf approved these changes Jun 15, 2024

View reviewed changes

melvin-bot Bot requested a review from arosiclair June 15, 2024 07:58

Krishna2323 added 2 commits June 19, 2024 03:26

Merge branch 'Expensify:main' into krishna2323/issue/42657

02edb5f

add util function for checking local files.

1047f73

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

allgandalf reviewed Jun 19, 2024

View reviewed changes

arosiclair approved these changes Jun 19, 2024

View reviewed changes

arosiclair merged commit a66ed89 into Expensify:main Jun 19, 2024

github-actions Bot mentioned this pull request Jun 19, 2024

Deploy Checklist: New Expensify 2024-06-19 #44047

Closed

59 tasks

Uh oh!

Conversation

Krishna2323 commented Jun 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 7, 2024

Uh oh!

allgandalf Jun 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allgandalf commented Jun 14, 2024

Uh oh!

allgandalf commented Jun 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 19, 2024

Uh oh!

OSBotify commented Jun 19, 2024

Uh oh!

OSBotify commented Jun 19, 2024

Uh oh!

OSBotify commented Jun 19, 2024

Uh oh!

OSBotify commented Jun 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Krishna2323 commented Jun 7, 2024 •

edited

Loading

allgandalf Jun 7, 2024 •

edited

Loading

Krishna2323 commented Jun 13, 2024 •

edited

Loading

allgandalf commented Jun 14, 2024 •

edited

Loading