Associate crashes with user info by ShridharGoel · Pull Request #43063 · Expensify/App

ShridharGoel · 2024-06-04T19:43:10Z

Details

Associate crashes with user info.

Fixed Issues

Testing

Update firebase.json to set crashlytics_debug_enabled to true.
Update platformSetup/index.native.ts to this:

import crashlytics from '@react-native-firebase/crashlytics';
import Performance from '@libs/Performance';

export default function () {
    crashlytics().setCrashlyticsCollectionEnabled(true);
    Performance.setupPerformanceObserver();
}

Create a new Android build.
Open the app on native Android.
Go to troubleshoot menu.
Click on "Test crash".
Wait for few seconds, then open the app again.
Leave the app open for 1 minute.
Check on crashlytics dashboard.

Native crash would not work on iOS debug build because we are on an old version. See invertase/react-native-firebase#6226

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-06-04T19:43:17Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

getusha · 2024-06-05T14:47:48Z

@ShridharGoel don't we need the crash buttons in Troubleshoot section to test it on staging?

…e-info

ShridharGoel · 2024-06-06T20:38:50Z

I've updated this locally, will update the PR once tested.

ShridharGoel · 2024-06-07T19:19:24Z

@getusha Updated.

roryabraham · 2024-06-11T00:16:02Z

@ShridharGoel you've got lint errors here

…e-info

getusha · 2024-06-17T18:30:49Z

@ShridharGoel we have a couple of checks failing and a conflict!

roryabraham · 2024-07-12T17:43:27Z

@getusha thanks for your review. Looks like all your comments have been addressed and it's ready for another review

getusha · 2024-07-13T12:14:07Z

+
+    return (
+        <View>
+            {isCrashlyticsDebugEnabled ? (


Don't we want this button to show on staging?

This will show in staging if crashlytics_debug_enabled is true.

This will show in staging if crashlytics_debug_enabled is true.

So we don't need to set that in firebase.json for staging?

I think we want to show this option only when a developer manually enables the crashlytics_debug_enabled flag. Do let me know your thoughts.

I think we want to show this option only when a developer manually enables the crashlytics_debug_enabled flag. Do let me know your thoughts.

On staging how are we going to enable it?

We want this PR to work for both staging and production, but not for dev or AdHoc builds by default

@ShridharGoel, the button will show for both staging and production, right? I don't see the changes to firebase.json in this PR

The user ID changes will work for staging and production. The testing button would show only when firebase.json is updated manually.

The user ID changes will work for staging and production. The testing button would show only when firebase.json is updated manually.

Sorry i am confused here, then why not remove the testing button after confirming the data is being sent to firebase is correct? if it will only be visible only on dev (which i assume is the only way to update firebase.json)

I think having the button would help us in testing it if needed in the future. Though it wouldn't be needed by QA team.

getusha · 2024-07-13T12:19:34Z

Note that local logs will show what data is being sent to Firebase, we can use that to verify the changes.

@ShridharGoel i am not seeing any logs that shows the data being sent

Screen.Recording.2024-07-13.at.3.16.44.in.the.afternoon.mov

getusha · 2024-07-16T09:46:33Z

Bump @ShridharGoel

ShridharGoel · 2024-07-17T09:50:23Z

@getusha You need to check in Android Studio logcat.

getusha · 2024-07-18T13:20:42Z

@ShridharGoel i'll check it thanks, we have a couple of comments ^

getusha · 2024-07-22T06:34:30Z

@ShridharGoel lets add steps for staging, otherwise mark this as No QA

ShridharGoel · 2024-07-22T07:06:21Z

Updated.

muttmuure · 2024-07-24T10:55:27Z

@getusha can you take a look at @ShridharGoel's changes?

getusha · 2024-07-25T21:12:28Z

lgtm i will need to confirm the logs from logcat

getusha

Wasn't able to confirm the data being sent to Firebase, but the rest looks good to me.
https://expensify.slack.com/archives/C01GTK53T8Q/p1722351381164999?thread_ts=1722282113.203869&cid=C01GTK53T8Q

getusha · 2024-07-30T19:42:29Z

@ShridharGoel could you please update the PR description? thanks!

ShridharGoel · 2024-07-30T21:11:07Z

Updated.

roryabraham · 2024-07-31T17:10:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-07-31T17:23:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-31T19:30:25Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-02T02:18:19Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.15-9 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Associate crashes with user info

49691ca

ShridharGoel requested a review from a team as a code owner June 4, 2024 19:43

melvin-bot Bot requested review from getusha and removed request for a team June 4, 2024 19:43

Merge branch 'main' of https://github.com/Expensify/App into associat…

6a87f2b

…e-info

ShridharGoel added 4 commits June 8, 2024 00:44

Update

e7c6950

Update

4ff36f0

Update

5a4322c

Update

a07c2df

ShridharGoel force-pushed the associate-info branch from c02b28c to a07c2df Compare June 7, 2024 19:18

This was referenced Jun 11, 2024

[HOLD for payment 2024-08-19] [HOLD for payment 2024-08-09] [$250] Associate crashes with specific logins #42651

Closed

Associate crashes with user info #43061

Closed

roryabraham reviewed Jun 11, 2024

View reviewed changes

Comment thread src/libs/testCrash/index.ts Outdated

roryabraham reviewed Jun 11, 2024

View reviewed changes

Comment thread src/components/TestToolMenu.tsx Outdated

Comment thread src/components/TestToolMenu.tsx Outdated

ShridharGoel added 2 commits June 13, 2024 12:06

Merge branch 'main' of https://github.com/Expensify/App into associat…

782dbd1

…e-info

Update

c0615dd

ShridharGoel force-pushed the associate-info branch from 8bc7e4f to c0615dd Compare June 14, 2024 19:25

ShridharGoel force-pushed the associate-info branch from 8f4e5ff to c0615dd Compare June 17, 2024 19:13

ShridharGoel requested a review from a team as a code owner June 17, 2024 19:14

ShridharGoel marked this pull request as draft June 17, 2024 19:14

ShridharGoel force-pushed the associate-info branch from 3cb9b38 to c0615dd Compare June 17, 2024 19:17

ShridharGoel added 2 commits June 18, 2024 00:49

Update

1038428

Update

af7b29d

ShridharGoel marked this pull request as ready for review June 17, 2024 19:22

Update

4d26455

ShridharGoel force-pushed the associate-info branch from 818b10e to 4d26455 Compare July 11, 2024 18:47

ShridharGoel added 2 commits July 12, 2024 20:47

Update

50ab2dd

Update

e71d115

getusha reviewed Jul 13, 2024

View reviewed changes

Delete src/libs/setCrashlyticsUserId/types.ts

d4e3795

ShridharGoel requested a review from getusha July 19, 2024 11:33

ShridharGoel changed the title ~~Associate crashes with user info~~ [NoQA] Associate crashes with user info Jul 22, 2024

getusha approved these changes Jul 30, 2024

View reviewed changes

ShridharGoel changed the title ~~[NoQA] Associate crashes with user info~~ [InternalQA] Associate crashes with user info Jul 31, 2024

roryabraham added the InternalQA This pull request required internal QA label Jul 31, 2024

roryabraham changed the title ~~[InternalQA] Associate crashes with user info~~ Associate crashes with user info Jul 31, 2024

roryabraham approved these changes Jul 31, 2024

View reviewed changes

roryabraham merged commit 3b7e02b into Expensify:main Jul 31, 2024

github-actions Bot mentioned this pull request Jul 31, 2024

Deploy Checklist: New Expensify 2024-07-31 #46607

Closed

Uh oh!

Conversation

ShridharGoel commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Testing

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 4, 2024

Uh oh!

getusha commented Jun 5, 2024

Uh oh!

ShridharGoel commented Jun 6, 2024

Uh oh!

ShridharGoel commented Jun 7, 2024

Uh oh!

roryabraham commented Jun 11, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

getusha commented Jun 17, 2024

Uh oh!

roryabraham commented Jul 12, 2024

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

getusha Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

getusha commented Jul 13, 2024

Uh oh!

getusha commented Jul 16, 2024

Uh oh!

ShridharGoel commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

getusha commented Jul 18, 2024

Uh oh!

getusha commented Jul 22, 2024

Uh oh!

ShridharGoel commented Jul 22, 2024

Uh oh!

muttmuure commented Jul 24, 2024

Uh oh!

getusha commented Jul 25, 2024

Uh oh!

getusha left a comment

Choose a reason for hiding this comment

Uh oh!

getusha commented Jul 30, 2024

Uh oh!

ShridharGoel commented Jul 30, 2024

Uh oh!

roryabraham commented Jul 31, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Jul 31, 2024

ShridharGoel commented Jun 4, 2024 •

edited

Loading

getusha Jul 24, 2024 •

edited

Loading

ShridharGoel commented Jul 17, 2024 •

edited

Loading