Incorrect video is paused after turning on and off full screen mode by jacobnguyen0000 · Pull Request #43025 · Expensify/App

jacobnguyen0000 · 2024-06-04T09:34:44Z

Details

Fixed Issues

$ #42427
PROPOSAL: #42427 (comment)

Tests

Upload two videos (Video1, Video2)
Play Video1
Play Video2
Click full screen mode button of Video1 while Video2 is playing
Exit full screen mode by pressing Esc key
Click play button of Video1
Check that Video1 is played correctly.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

ios.mp4

MacOS: Chrome / Safari

bandicam.2024-05-31.01-12-01-386.mp4

MacOS: Desktop

bandicam.2024-06-04.17-35-28-579.mp4

melvin-bot · 2024-06-04T09:34:50Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-06-04T09:34:57Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

jacobnguyen0000 · 2024-06-04T09:36:23Z

I have read the CLA Document and I hereby sign the CLA

hoangzinh · 2024-06-04T11:15:14Z

        }
-        shareVideoPlayerElements(videoPlayerRef.current, videoPlayerElementParentRef.current, videoPlayerElementRef.current, isUploading);
-    }, [currentlyPlayingURL, shouldUseSharedVideoElement, shareVideoPlayerElements, url, isUploading, isFullScreenRef]);
+        shareVideoPlayerElements(videoPlayerRef.current, videoPlayerElementParentRef.current, videoPlayerElementRef.current, isUploading || isFullScreenRef.current);


@jacobnguyen0000 why do we need to check isFullScreenRef.current here?

@hoangzinh
Let's assume this test case.

Upload two videos (Video1, Video2)

Play Video1

Play Video2

Click full screen mode button of Video1 while Video2 is playing

In this case, Video1 is auto played when entering fullscreen mode without isFullScreenRef check.
I thought this is not the result that we expect.
Adding isFullScreenRef.current prevent auto playing in above steps, as last parameter of shareVideoPlayerElements is determining whether play or not play play.

Thanks for update I will take a look at this soon.

Make sense, then I think we can rename the last param to shouldNotAutoPlay, what do you think?

hoangzinh · 2024-06-06T17:17:32Z

+
+        // don't include `isFullScreenRef.current` in dependency array as we don't have to update shared video elements when it is changed
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, [currentlyPlayingURL, shouldUseSharedVideoElement, shareVideoPlayerElements, url, isUploading]);


Suggested change

}, [currentlyPlayingURL, shouldUseSharedVideoElement, shareVideoPlayerElements, url, isUploading]);

}, [currentlyPlayingURL, shouldUseSharedVideoElement, shareVideoPlayerElements, url, isUploading, isFullScreenRef]);

I think we can keep isFullScreenRef as the previous code. It still works because isFullScreenRef is a ref then it won't change.

jacobnguyen0000 · 2024-06-07T00:29:40Z

@hoangzinh
Thank you for your suggestions. I've pushed updates.

hoangzinh · 2024-06-07T10:36:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-07.at.18.02.46.android.mov

Android: mWeb Chrome

Screen.Recording.2024-06-07.at.17.49.37.android.chrome.mov

iOS: Native

Screen.Recording.2024-06-07.at.17.47.13.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-06-07.at.17.45.18.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-07.at.17.38.40.web.mp4

MacOS: Desktop

Screen.Recording.2024-06-07.at.17.41.42.desktop.mov

hoangzinh · 2024-06-07T10:36:43Z

@jacobnguyen0000 can you add expectation result to your test steps? Thanks

hoangzinh · 2024-06-07T11:06:24Z

@jacobnguyen0000 can you also add recordings for mweb + native please? It helps us to ensure we won't break anything on other platforms

jacobnguyen0000 · 2024-06-07T13:25:20Z

@hoangzinh
I've added expectation result for test cases.
I'm sorry but currently it's difficult to upload test videos for other platforms due to some problems.

hoangzinh · 2024-06-07T14:33:38Z

I've added expectation result for test cases.

The expectation result should be step 7.

I'm sorry but currently it's difficult to upload test videos for other platforms due to some problems

Are you able to complete it this weekend?

jacobnguyen0000 · 2024-06-07T15:32:56Z

@hoangzinh

The expectation result should be step 7.

Updated!

Now it's very difficult to login on my side(maybe due to network problem).
Anyway I will try to upload video for ios by this weekend. But for android, actually I haven't build dev env yet.

hoangzinh · 2024-06-07T16:00:16Z

Let's try to complete it @jacobnguyen0000. You can always try to find experienced errors or ask your errors in Slack #expensify-open-source

jacobnguyen0000 · 2024-06-12T07:29:03Z

@hoangzinh
I've uploaded video for mWeb safari. But my macos is broken unexpectedly.
I wonder if we can go further with current status. Thank you.

hoangzinh · 2024-06-12T11:15:36Z

@jacobnguyen0000 It's sad to hear that. Sure it's fine to me.

OSBotify · 2024-06-12T14:07:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-14T23:03:31Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.83-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix issue

70bfcf0

jacobnguyen0000 requested a review from a team as a code owner June 4, 2024 09:34

melvin-bot Bot requested review from hoangzinh and removed request for a team June 4, 2024 09:34

hoangzinh reviewed Jun 4, 2024

View reviewed changes

hoangzinh reviewed Jun 6, 2024

View reviewed changes

fix issues

82c3c18

hoangzinh approved these changes Jun 12, 2024

View reviewed changes

melvin-bot Bot requested a review from grgia June 12, 2024 11:16

grgia approved these changes Jun 12, 2024

View reviewed changes

grgia merged commit 8e87c07 into Expensify:main Jun 12, 2024

github-actions Bot mentioned this pull request Jun 13, 2024

Deploy Checklist: New Expensify 2024-06-13 #43655

Closed

64 tasks

	}, [currentlyPlayingURL, shouldUseSharedVideoElement, shareVideoPlayerElements, url, isUploading]);
	}, [currentlyPlayingURL, shouldUseSharedVideoElement, shareVideoPlayerElements, url, isUploading, isFullScreenRef]);

Uh oh!

Conversation

jacobnguyen0000 commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 4, 2024

Uh oh!

github-actions Bot commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacobnguyen0000 commented Jun 4, 2024

Uh oh!

hoangzinh Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

jacobnguyen0000 Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoangzinh Jun 5, 2024

Choose a reason for hiding this comment

Uh oh!

hoangzinh Jun 6, 2024

Choose a reason for hiding this comment

Uh oh!

hoangzinh Jun 6, 2024

Choose a reason for hiding this comment

Uh oh!

jacobnguyen0000 commented Jun 7, 2024

Uh oh!

hoangzinh commented Jun 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Jun 7, 2024

Uh oh!

hoangzinh commented Jun 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacobnguyen0000 commented Jun 7, 2024

Uh oh!

hoangzinh commented Jun 7, 2024

Uh oh!

jacobnguyen0000 commented Jun 7, 2024

Uh oh!

hoangzinh commented Jun 7, 2024

Uh oh!

jacobnguyen0000 commented Jun 12, 2024

Uh oh!

hoangzinh commented Jun 12, 2024

Uh oh!

OSBotify commented Jun 12, 2024

Uh oh!

OSBotify commented Jun 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jacobnguyen0000 commented Jun 4, 2024 •

edited

Loading

github-actions Bot commented Jun 4, 2024 •

edited

Loading

jacobnguyen0000 Jun 4, 2024 •

edited

Loading

hoangzinh commented Jun 7, 2024 •

edited

Loading

hoangzinh commented Jun 7, 2024 •

edited

Loading