Skip to content

fix Inconsistency while pasting highlighted mention in room description #42361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoisl merged 5 commits into from
Jun 10, 2024
Merged

fix Inconsistency while pasting highlighted mention in room description #42361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e0968d
fix Inconsistency while pasting highlighted mention in room and expen…
tienifr May 18, 2024
7052246
fix merge main
tienifr May 27, 2024
414a5c2
fix merge main
tienifr May 28, 2024
d3e3e92
fix cannot add new line using enter
tienifr May 28, 2024
902b560
fix add comment to TEXTBOX
tienifr Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3386,6 +3386,11 @@ const CONST = {
* @deprecated Please stop using the accessibilityRole prop and use the role prop instead.
*/
IMAGE: 'image',

/**
* @deprecated Please stop using the accessibilityRole prop and use the role prop instead.
*/
TEXTBOX: 'textbox',

@shubham1206agra shubham1206agra Jun 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give me a small explanation why this will fix the issue?

@tienifr tienifr Jun 3, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we use isMarkdownEnabled: true, the activeElementRole in here is textbox, so shouldDisableEnterShortcut in here is false, that why pressing on enter does not add a new line. So we need to make sure when the markdown input is focused, shouldDisableEnterShortcut is true, by adding texbox to CONST.ACCESSIBILITY_ROLE

@tienifr tienifr Jun 5, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham1206agra Can you help check it?

Comment thread
tienifr marked this conversation as resolved.
},
/**
* Acceptable values for the `role` attribute on react native components.
Expand Down
1 change: 1 addition & 0 deletions src/pages/RoomDescriptionPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ function RoomDescriptionPage({report, policies}: RoomDescriptionPageProps) {
value={description}
onChangeText={handleReportDescriptionChange}
autoCapitalize="none"
isMarkdownEnabled

@QichenZhu QichenZhu Jun 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the newValue argument of Report.updateDescription() to markdown, causing issue #61847. Fixed in PR #62636.

/>
</View>
</FormProvider>
Expand Down
1 change: 1 addition & 0 deletions src/pages/workspace/WorkspaceNewRoomPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ function WorkspaceNewRoomPage({policies, reports, formState, session, activePoli
maxLength={CONST.REPORT_DESCRIPTION.MAX_LENGTH}
autoCapitalize="none"
shouldInterceptSwipe
isMarkdownEnabled
/>
</View>
<View style={[styles.mhn5]}>
Expand Down