Skip to content

[No QA] Add Performance issue template#4128

Merged
tgolen merged 2 commits into
mainfrom
marcaaron-issueTemplate
Jul 20, 2021
Merged

[No QA] Add Performance issue template#4128
tgolen merged 2 commits into
mainfrom
marcaaron-issueTemplate

Conversation

@marcaaron

Copy link
Copy Markdown
Contributor

Details

  • Adding a Performance issue template here to make it easier for contributors to report performance improvements.
  • The only existing option is to use the standard issue template and it doesn't capture the information we need to evaluate these types of conversations and issues.

Fixed Issues

None

Tests

QA Steps

None

@marcaaron marcaaron self-assigned this Jul 17, 2021
@marcaaron marcaaron requested a review from a team as a code owner July 17, 2021 00:26
@MelvinBot MelvinBot requested review from tgolen and removed request for a team July 17, 2021 00:26
Comment thread .github/ISSUE_TEMPLATE/Performance.md Outdated
Comment on lines +28 to +32
Web
iOS
Android
Desktop App
Mobile Web

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make these checkboxes for ease of use.

Comment thread .github/ISSUE_TEMPLATE/Performance.md Outdated
## What performance issue do we need to solve?
e.g. memory consumption, storage read/write times, React native bridge concerns, inefficient React component rendering, etc.

## Is there a specific app feature that will be improved by solving this problem?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To go along with this, what do you think about adding a question like:

What is the impact of this on end-users?

@marcaaron

Copy link
Copy Markdown
Contributor Author

Added checklists and incorporated that suggestion, thanks! I think it's a bit clearer now.

@marcaaron marcaaron requested a review from tgolen July 19, 2021 18:35
@tgolen tgolen merged commit 529262e into main Jul 20, 2021
@tgolen tgolen deleted the marcaaron-issueTemplate branch July 20, 2021 20:39
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging in version: 1.0.79-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production in version: 1.0.80-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants